From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: maciej.piwko@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Wed, 24 Apr 2019 06:45:08 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 06:45:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,389,1549958400"; d="scan'208";a="318558920" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga005.jf.intel.com with ESMTP; 24 Apr 2019 06:45:07 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 24 Apr 2019 14:45:06 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.115]) by irsmsx112.ger.corp.intel.com ([169.254.1.101]) with mapi id 14.03.0415.000; Wed, 24 Apr 2019 14:45:06 +0100 From: "Piwko, Maciej" To: "Gao, Zhichao" , "Bu, Daocheng" , "devel@edk2.groups.io" , "Kwolek, Adam" CC: "Oram, Isaac W" , "Gao, Liming" Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem Thread-Topic: [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem Thread-Index: AQHU8zh19TKpUFqSxEe/+9saICpKFqY8yhCAgAqq3YCAA+wOIA== Date: Wed, 24 Apr 2019 13:45:05 +0000 Message-ID: <57C675345A77FA44B1AA8BC41E368D10A108908D@IRSMSX101.ger.corp.intel.com> References: <20190415030739.14328-1-zhichao.gao@intel.com> <20190415030739.14328-5-zhichao.gao@intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B7C37FA@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B7C37FA@SHSMSX101.ccr.corp.intel.com> Accept-Language: pl-PL, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDJkYTdmMTgtYzZlMS00N2ExLTlhY2YtZjEyMWU0YTE5Y2FiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT0lZbFBSYUtcLzJaXC9PeHNyaHhnS1MyMExiNm1KZnRydmtvUEtQcFV2S0NaeERGMVMzT2FUYXVaUnpnTkVnVW5UIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] MIME-Version: 1.0 Return-Path: maciej.piwko@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, For me the change seems fine. The only concern that I have may be related to the fact, the resetting the = system we may also want to inform the ME engine about that fact and choose = proper reset type. I'm adding Adam, who can comment on the reset functionality from ME UEFIFW = perspective. Adam, could you also look at this change? Thanks, Maciej -----Original Message----- From: Gao, Zhichao = Sent: Monday, April 22, 2019 4:50 AM To: Bu, Daocheng ; devel@edk2.groups.io Cc: Piwko, Maciej ; Oram, Isaac W ; Gao, Liming Subject: RE: [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/Dxe= RuntimeResetSystemLib: Add a new API ResetSystem Hi, I didn't receive any comments with this patch yet. Maybe you missed this em= ail. The new added function is only a few part of the ResetSystemRuntimeDxe to p= rovide the reset function. As I know, platforms always have their own ResetSystemLib instance and do n= ot use the instance in MdeModulePkg. While the platform contains a driver base on the new interface(the driver m= ay be in the edk2 repo), the driver would not find the interface's implemen= t and cause a link error. I suggest all platform code should update it to avoid the link error if the= platform is working with the edk2 master repo. Thanks, Zhichao > -----Original Message----- > From: Bu, Daocheng > Sent: Monday, April 15, 2019 3:56 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Piwko, Maciej ; Oram, Isaac W = > ; Gao, Liming > Subject: RE: [edk2-platforms/devel-MinPlatform][PATCH 3/5] > LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem > = > = > Hi Maciej, > = > Please help review this code from PCH perspective. > If you approve this change , please also help cherry pick this change = > to ServerSiliconPkg\Pch\SouthClusterLbg pkg @10nm trunk. > = > Thanks, > Amos > = > UEFI FW, IAFW or System Firmware is more generic & accurate it's not = > BIOS anymore! > = > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, April 15, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Piwko, Maciej ; Bu, Daocheng = > ; Oram, Isaac W ; Gao, = > Liming > Subject: [edk2-platforms/devel-MinPlatform][PATCH 3/5] > LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem > = > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 > = > Add a new API ResetSystem to this ResetSystemLib instance. > It only adds the basic functions from ResetSystemRuntimeDxe. > Lacking of this interface may cause link error, if some drivers use = > this new API and link to this library instance. > Make the ResetPlatformSpecific's parameters same with the interface in > Edk2 repo. > Notes: > This library API only provide a basic function of reset. If the = > consumers want full functions, they should use the instance in the = > MdeModulePkg and make sure the depex driver is dispatched. > = > Cc: "Piwko, Maciej" > Cc: "Bu, Daocheng" > Cc: "Oram, Isaac W" > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > .../DxeRuntimeResetSystemLib/PchReset.c | 47 +++++++++++++++++-- > 1 file changed, 44 insertions(+), 3 deletions(-) > = > diff --git > a/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchReset. > c > b/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchReset. > c > index cdc0f19c17..673f42e72c 100644 > --- > a/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchReset. > c > +++ > b/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchRes > +++ et.c > @@ -1,6 +1,6 @@ > /** @file > = > -Copyright (c) 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2018 - 2019, Intel Corporation. All rights = > +reserved.
> This program and the accompanying materials are licensed and made = > available under the terms and conditions of the BSD License that = > accompanies this distribution. > The full text of the license may be found at @@ -255,7 +255,6 @@ = > ResetShutdown ( > /** > Calling this function causes the system to enter a power state for = > platform specific. > = > - @param[in] ResetStatus The status code for the reset. > @param[in] DataSize The size of ResetData in bytes. > @param[in] ResetData Optional element used to introduce a p= latform > specific reset. > The exact type of the reset is = > defined by the EFI_GUID that follows @@ -265,7 +264,6 @@ ResetShutdown = > ( VOID EFIAPI ResetPlatformSpecific ( > - IN EFI_STATUS ResetStatus, > IN UINTN DataSize, > IN VOID *ResetData OPTIONAL > ) > @@ -306,6 +304,49 @@ EnterS3WithImmediateWake ( > PchReset (mPchResetInstance, (PCH_RESET_TYPE) EfiResetWarm); } > = > +/** > + The ResetSystem function resets the entire platform. > + > + @param[in] ResetType The type of reset to perform. > + @param[in] ResetStatus The status code for the reset. > + @param[in] DataSize The size, in bytes, of ResetData. > + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWar= m, > or EfiResetShutdown > + the data buffer starts with a Null-terminate= d string, optionally > + followed by additional binary data. The stri= ng is a description > + that the caller may use to further indicate = the reason for the > + system reset. > +**/ > +VOID > +EFIAPI > +ResetSystem ( > + IN EFI_RESET_TYPE ResetType, > + IN EFI_STATUS ResetStatus, > + IN UINTN DataSize, > + IN VOID *ResetData OPTIONAL > + ) > +{ > + switch (ResetType) { > + case EfiResetWarm: > + ResetWarm (); > + break; > + > + case EfiResetCold: > + ResetCold (); > + break; > + > + case EfiResetShutdown: > + ResetShutdown (); > + return ; > + > + case EfiResetPlatformSpecific: > + ResetPlatformSpecific (DataSize, ResetData); > + return; > + > + default: > + return ; > + } > +} > + > /** > PchReset Runtime DXE Driver Entry Point\n > - Introduction\n > -- > 2.21.0.windows.1 -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.