From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.3794.1689237771148829570 for ; Thu, 13 Jul 2023 01:42:51 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34EB71570; Thu, 13 Jul 2023 01:43:33 -0700 (PDT) Received: from [10.34.100.101] (e126645.nice.arm.com [10.34.100.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0EB1A3F73F; Thu, 13 Jul 2023 01:42:49 -0700 (PDT) Message-ID: <57cda140-59a9-1491-e928-3acb37b361f0@arm.com> Date: Thu, 13 Jul 2023 10:42:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 0/4] Add support for generating ACPI ThermalZones To: Jeff Brasen , devel@edk2.groups.io Cc: Alexei.Fedorov@arm.com, Sami.Mujawar@arm.com References: From: "PierreGondois" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Jeff, Thanks for the new version: Reviewed-by: Pierre Gondois On 7/11/23 00:25, Jeff Brasen wrote: > Add APIs needed to create thermal zones dynamically. > Does not add a generator for this as creating the TMP method generically may > be difficult. > > Change log: > > v2 - renamed NameString function and added goto dones in a couple error cases > > Jeff Brasen (4): > DynamicTablesPkg: Add ThermalZone CodeGen function > DynamicTablesPkg: Add support for simple method invocation. > DynamicTablesPkg: Add support to add Strings to package > DynamicTablesPkg: Add Aml NameUnicodeString API > > .../Include/Library/AmlLib/AmlLib.h | 130 +++++ > .../Common/AmlLib/CodeGen/AmlCodeGen.c | 508 ++++++++++++++++++ > 2 files changed, 638 insertions(+) >