From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.841.1623790647114976234
 for <devel@edk2.groups.io>;
 Tue, 15 Jun 2021 13:57:27 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=UJXXlxk0;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [10.124.238.202] (unknown [167.220.2.74])
	by linux.microsoft.com (Postfix) with ESMTPSA id 4F96220B6AEE;
	Tue, 15 Jun 2021 13:57:26 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4F96220B6AEE
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1623790646;
	bh=p6louI/CqX83LYvUronrDGgt05NyA4jb6UApk/ppRX0=;
	h=Subject:From:To:Cc:Reply-To:References:Date:In-Reply-To:From;
	b=UJXXlxk0RGlSefQzSCmhhLBZ810IoIO8yarrKAn58livN86ZpJiXVLSfM0ARqqF57
	 RohWn0Jq9nTx4Mn487T20z8hBUG2Uyt57U3YZN+l+hR7/WsdmPOTGjkjsLhzziTQsj
	 3hmeAwhpSZE3JfNzLJsvRq9xW59HmJfHuvoyqIPA=
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] MinPlatformPkg: Add TPM platform hier disable support
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Chasel Chiu <chasel.chiu@intel.com>,
 Nate DeSimone <nathaniel.l.desimone@intel.com>,
 Liming Gao <gaoliming@byosoft.com.cn>, Eric Dong <eric.dong@intel.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Jeremiah Cox <jerecox@microsoft.com>
Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com
References: <1686586931DF02F0.1698@groups.io>
Message-ID: <57e1ea1f-cdb3-2860-b99c-2867cfe512ae@linux.microsoft.com>
Date: Tue, 15 Jun 2021 16:57:26 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <1686586931DF02F0.1698@groups.io>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

It's been a week and I haven't seen any feedback. Please review when 
possible.

Thanks,
Michael

On 6/7/2021 12:05 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3411
> 
> This patch series adds support in TpmPlatformHierarchyLib to either
> randomize the platform auth (current behavior) or disable the
> platform auth (new behavior) based on a new PCD introduced to
> MinPlatformPkg: PcdRandomizePlatformHierarchy.
> 
> Some platforms that would like to adopt MinPlatformPkg prefer to
> disable the platform hierarchy as opposed to the randomization
> approach.
> 
> Minor changes are included to eliminate code duplication in impacted
> code.
> 
> V2 changes:
> 1. Update code that randomizes the platform auth in Tcg2PlatformPei
>     to use the TpmPlatformHierarchyLib interface for platform
>     hierarchy configuration.
> 2. Remove pre-existing redundant code in Tcg2PlatformPei.
> 3. Add a PCD to allow the platform integrator to choose how to
>     configure the TPM platform hierarchy.
>     
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jeremiah Cox <jerecox@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (4):
>    MinPlatformPkg: Add TpmPlatformHierarchyLib to Components in DSC
>    MinPlatformPkg/TpmPlatformHierarchyLib: Add PEI support
>    MinPlatformPkg/Tcg2PlatformPei: Use TpmPlatformHierarchyLib
>    MinPlatformPkg/TpmPlatformHierarchyLib: Add disable support
> 
>   Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlatformHierarchyLib.c => PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c}     |  72 +++++++++--
>   Platform/Intel/MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.c                                                                                                | 130 +-------------------
>   Platform/Intel/MinPlatformPkg/Include/Library/TpmPlatformHierarchyLib.h                                                                                            |   4 +-
>   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                                                                                                   |   1 +
>   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc                                                                                                                   |   4 +-
>   Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlatformHierarchyLib.inf => PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf} |  22 ++--
>   Platform/Intel/MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf                                                                                              |   2 +
>   7 files changed, 85 insertions(+), 150 deletions(-)
>   rename Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlatformHierarchyLib.c => PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c} (70%)
>   rename Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlatformHierarchyLib.inf => PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf} (66%)
>