From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 17BC97803EA for ; Fri, 17 Nov 2023 11:42:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qNGwjPAypUG0tw/Cm1U6tnucJlFIr1Owiii1TKg5EVY=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1700221373; v=1; b=OUwfRrv0ICYK5Wbvd4r1TQyBoTpAhvnqmYfHWP7GKjSTSg1D8shSe0MUMlEjX7sPBDWpLtN0 8UJNgPTip/dzzDN5sU8bUgndExVtTGTlsrTAqaQz6ziDbOY29aIOkhuQmZS20UvgweyJ/75/zsx o9oQYlfNvRvQR6zm+UtNGu+k= X-Received: by 127.0.0.2 with SMTP id tuGVYY7687511xNDJ5yqr0fX; Fri, 17 Nov 2023 03:42:53 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.9771.1700221372873405386 for ; Fri, 17 Nov 2023 03:42:53 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-YYSOOSBvN5KNndLPmh8B1g-1; Fri, 17 Nov 2023 06:42:50 -0500 X-MC-Unique: YYSOOSBvN5KNndLPmh8B1g-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 18A5180C343; Fri, 17 Nov 2023 11:42:50 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96F582166B28; Fri, 17 Nov 2023 11:42:49 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 343A518012CD; Fri, 17 Nov 2023 12:42:48 +0100 (CET) Date: Fri, 17 Nov 2023 12:42:48 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Michael Roth , Ray Ni , Erdem Aktas , Jiewen Yao , Min Xu , Tom Lendacky , "Liming Gao (Byosoft address)" , Michael Kinney Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE Message-ID: <57te454l357zkcgohbee4afjsyyllvvhh4dcc3rfde54se6pvh@q2rcfktmjvc6> References: <20231115175153.813213-1-michael.roth@amd.com> <6f62e3d2-cf82-a23b-174a-fa24dd94fbe1@redhat.com> MIME-Version: 1.0 In-Reply-To: <6f62e3d2-cf82-a23b-174a-fa24dd94fbe1@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5CdX00jx2eUTbi7dH8YiWSC7x7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OUwfRrv0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Nov 17, 2023 at 10:16:10AM +0100, Laszlo Ersek wrote: > (+Liming +Mike) > > On 11/16/23 10:01, Gerd Hoffmann wrote: > > On Wed, Nov 15, 2023 at 11:51:53AM -0600, Michael Roth wrote: > >> The struct used for GHCB-based page-state change requests uses a 40-bit > >> bit-field for the GFN, which is shifted by PAGE_SHIFT to generate a > >> 64-bit address. However, anything beyond 40-bits simply gets shifted off > >> when doing this, which will cause issues when dealing with 1TB+ > >> addresses. Fix this by casting the 40-bit GFN values to 64-bit ones > >> prior to shifting it by PAGE_SHIFT. > >> > >> Fixes: ade62c18f474 ("OvmfPkg/MemEncryptSevLib: add support to validate system RAM") > >> Signed-off-by: Michael Roth > > > > Reviewed-by: Gerd Hoffmann > > > > take care, > > Gerd > > Is this hard feature freeze material? It is a clear bugfix, so IMHO it qualifies. > Also, the patch looks garbled to me on-list (superfluous line breaks). Patch applies fine here. I see mutt breaking the long line, but that is just the local display rendering, the mail good. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111396): https://edk2.groups.io/g/devel/message/111396 Mute This Topic: https://groups.io/mt/102610323/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-