From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.3725.1585012998612308441 for ; Mon, 23 Mar 2020 18:23:18 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: bob.c.feng@intel.com) IronPort-SDR: jO0DGgnwlIsH4/IltA9DZljFUeKKB92caTqtZZIP7LB+6kkNnnovxD46H0ac18D88rYImJc3S9 VhVdv6OIo8lg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 18:23:17 -0700 IronPort-SDR: f2Ri6q02a7sM0lB755VFB8bcbZaBa5a+x7JMR0bSXyTXX5F5wXwz93ia5THXjY+pfJSDZuk0WF +GwUSefgD7jw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,298,1580803200"; d="scan'208";a="264972401" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 23 Mar 2020 18:23:17 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Mar 2020 18:23:16 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 24 Mar 2020 09:23:14 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Tue, 24 Mar 2020 09:23:14 +0800 From: "Bob Feng" To: "Fan, ZhijuX" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH V2] BaseTools:fix issue for decode the stdout/stderr byte arrays Thread-Topic: [PATCH V2] BaseTools:fix issue for decode the stdout/stderr byte arrays Thread-Index: AdWow6zLWhkckwaqR32YMcpXNMH3rBYtxgnw Date: Tue, 24 Mar 2020 01:23:14 +0000 Message-ID: <58169e613928489dbd96a789fb785ac1@intel.com> References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Fan, ZhijuX=20 Sent: Monday, December 2, 2019 11:51 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V2] BaseTools:fix issue for decode the stdout/stderr byte a= rrays BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2365 This patch is to fix a build tool regression issue which was introduced by = commit 8ddec24dea74. compiler output message includes localized string. So build failed when code decode the stdout/stderr byte arrays. The cause of the build failed is that Commit 8ddec24dea74 removed "errors= =3D'ignore'". The build tool does not need to deal with localized string, so we need to a= dd "errors=3D'ignore'". this function is only invoked for structure PCDs. Build failed if structurePcd is used in platform dsc file. The patch is going to fixed this issue Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/= Source/Python/Workspace/DscBuildData.py index 9192077f90..901d95a413 100644 --- a/BaseTools/Source/Python/Workspace/DscBuildData.py +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py @@ -1752,7 +1752,7 @@ class DscBuildData(PlatformBuildClassObject): except: EdkLogger.error('Build', COMMAND_FAILURE, 'Can not execute com= mand: %s' % Command) Result =3D Process.communicate() - return Process.returncode, Result[0].decode(), Result[1].decode() + return Process.returncode, Result[0].decode(errors=3D'ignore'),=20 + Result[1].decode(errors=3D'ignore') =20 @staticmethod def IntToCString(Value, ValueSize): -- 2.14.1.windows.1