From: "Laszlo Ersek" <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>
Subject: Re: [Patch v2 0/2] UefiCpuPkg: Remove debug message.
Date: Wed, 7 Aug 2019 19:11:02 +0200 [thread overview]
Message-ID: <5823fbce-edda-e7f9-8740-bbcdda920804@redhat.com> (raw)
In-Reply-To: <20190805064359.29332-1-eric.dong@intel.com>
On 08/05/19 08:43, Eric Dong wrote:
> This debug message may be called by BSP and APs. It may
> caused ASSERT when APs call this debug code.
>
> In order to avoid system boot assert, Remove this debug
> message.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
>
> Eric Dong (2):
> UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message.
> UefiCpuPkg/PiSmmCpuDxeSmm: Remove debug message.
>
> .../CpuFeaturesInitialize.c | 22 -------------------
> UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 22 +------------------
> 2 files changed, 1 insertion(+), 43 deletions(-)
>
It seems to me that, after these patches are applied, no uses of
"ConsoleLogLock" remain, in either module (RegisterCpuFeaturesLib and
PiSmmCpuDxeSmm).
Can we eliminate the field from both modules? Otherwise we'll be left
with a useless, initialized spinlock, in each of these modules.
Thanks
Laszlo
next prev parent reply other threads:[~2019-08-07 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 6:43 [Patch v2 0/2] UefiCpuPkg: Remove debug message Dong, Eric
2019-08-05 6:43 ` [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: " Dong, Eric
2019-08-07 17:17 ` [edk2-devel] " rebecca
2019-08-08 18:53 ` Laszlo Ersek
2019-08-05 6:43 ` [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: " Dong, Eric
2019-08-05 9:21 ` [Patch v2 0/2] UefiCpuPkg: " Ni, Ray
2019-08-07 17:11 ` Laszlo Ersek [this message]
2019-08-07 18:14 ` Laszlo Ersek
2019-08-08 0:07 ` Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5823fbce-edda-e7f9-8740-bbcdda920804@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox