From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 07 Aug 2019 10:11:04 -0700
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id CFAEB30253EC;
	Wed,  7 Aug 2019 17:11:03 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.2])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 04F2E60A97;
	Wed,  7 Aug 2019 17:11:02 +0000 (UTC)
Subject: Re: [Patch v2 0/2] UefiCpuPkg: Remove debug message.
To: Eric Dong <eric.dong@intel.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>
References: <20190805064359.29332-1-eric.dong@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <5823fbce-edda-e7f9-8740-bbcdda920804@redhat.com>
Date: Wed, 7 Aug 2019 19:11:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190805064359.29332-1-eric.dong@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 07 Aug 2019 17:11:03 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 08/05/19 08:43, Eric Dong wrote:
> This debug message may be called by BSP and APs. It may
> caused ASSERT when APs call this debug code.
> 
> In order to avoid system boot assert, Remove this debug
> message.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> 
> Eric Dong (2):
>   UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message.
>   UefiCpuPkg/PiSmmCpuDxeSmm: Remove debug message.
> 
>  .../CpuFeaturesInitialize.c                   | 22 -------------------
>  UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c             | 22 +------------------
>  2 files changed, 1 insertion(+), 43 deletions(-)
> 

It seems to me that, after these patches are applied, no uses of
"ConsoleLogLock" remain, in either module (RegisterCpuFeaturesLib and
PiSmmCpuDxeSmm).

Can we eliminate the field from both modules? Otherwise we'll be left
with a useless, initialized spinlock, in each of these modules.

Thanks
Laszlo