public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Pierre.Gondois@arm.com, devel@edk2.groups.io,
	thomas.abraham@arm.com, leif@nuviainc.com
Cc: sami.mujawar@arm.com
Subject: Re: [PATCH v2 edk2-platforms 0/2] Fix Ecc reported errors from ArmPlatformPkg
Date: Mon, 4 Jan 2021 18:49:56 +0100	[thread overview]
Message-ID: <5843e61c-55ac-1c50-8b6c-263ae08bbfb2@arm.com> (raw)
In-Reply-To: <20201211103827.5820-1-Pierre.Gondois@arm.com>

On 12/11/20 11:38 AM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
> 
> The Ecc tools available in the BaseTools package checks for
> good practice coding standards. Some errors reported while
> running Ecc on edk2/ArmPlatformPkg require modifications
> in the edk2-platforms.
> 
> This patch set has a dependency over a similar patch set
> named "Fix Ecc reported errors in ArmPlatformPkg" for edk2
> and should not be merged independently.
> 
> The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tree/pg/1537_Ecc_ArmPlatformPkg_v2
> 
> Pierre Gondois (2):
>   Platform/ARM/VExpressPkg: Remove LcdPlatformLib.h
>   Platform/ARM: Fix Ecc error 8005
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as 3ada6025ce23..162f4a41a860

Thanks,
Ard.


>  .../Library/HdLcdArmJunoLib/HdLcdArmJuno.c    |   4 +-
>  .../Library/HdLcdArmSgiLib/HdLcdArmSgi.c      |   4 +-
>  Platform/ARM/VExpressPkg/ArmVExpressPkg.dec   |   3 +-
>  .../Include/Library/LcdPlatformLib.h          | 215 ------------------
>  .../Library/ArmMaliDpLib/ArmMaliDpLib.c       |   4 +-
>  .../HdLcdArmVExpressLib/HdLcdArmVExpress.c    |   4 +-
>  .../PL111LcdArmVExpress.c                     |  34 +--
>  7 files changed, 26 insertions(+), 242 deletions(-)
>  delete mode 100644 Platform/ARM/VExpressPkg/Include/Library/LcdPlatformLib.h
> 
> --
> 2.17.1
> 


      parent reply	other threads:[~2021-01-04 17:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 10:38 [PATCH v2 edk2-platforms 0/2] Fix Ecc reported errors from ArmPlatformPkg PierreGondois
2020-12-11 10:38 ` [PATCH v2 edk2-platforms 1/2] Platform/ARM/VExpressPkg: Remove LcdPlatformLib.h PierreGondois
2020-12-11 10:38 ` [PATCH v2 edk2-platforms 2/2] Platform/ARM: Fix Ecc error 8005 PierreGondois
2021-01-04 17:49 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5843e61c-55ac-1c50-8b6c-263ae08bbfb2@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox