Re: [edk2-devel] [PATCH v1 1/3] ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c

["Stuart Yoder" <stuart.yoder@arm.com>]

Hi Sam,

See inline comments...

On 1/24/24 2:56 PM, Sam Kaynor wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
> 
> Implemented the dumping of the UEFI RT Properties Table using Dmem.c
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Sam Kaynor <Sam.Kaynor@arm.com>
> ---
>   ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c                         | 62 ++++++++++++++++++++
>   ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni | 22 ++++++-
>   2 files changed, 82 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> index a609971f345e..1ae7b1f3d85c 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> @@ -84,8 +84,63 @@ DisplayMmioMemory (
>     return (ShellStatus);
>   }
>   
> +/**
> +  Display the RtPropertiesTable entries
> +
> +  @param[in] Address    The pointer to the RtPropertiesTable.
> +**/
> +SHELL_STATUS
> +DisplayRtProperties (
> +  IN UINT64 Address
> +  )
> +{
> +  EFI_RT_PROPERTIES_TABLE *RtPropertiesTable;
> +  UINT32                  RtServices;
> +  SHELL_STATUS            ShellStatus;
> +  EFI_STATUS              Status;
> +
> +  ShellStatus = SHELL_SUCCESS;
> +
> +  if (Address != 0) {
> +    Status = EfiGetSystemConfigurationTable (&gEfiRtPropertiesTableGuid, (VOID **)&RtPropertiesTable);

Why do you get the table address here, when it was already passed as an
argument to this function.

Thanks,
Stuart



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116342): https://edk2.groups.io/g/devel/message/116342
Mute This Topic: https://groups.io/mt/103940858/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-