From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 866E87803D0 for ; Mon, 4 Mar 2024 19:32:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QPkrUCNR2QgjD9o18Vrvg5Lh7tDm/+jteTO+z+xN7Cg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709580765; v=1; b=SKcLlsLycIu7oZlRX+V4KUxa7X9F6w65LAPwbOA80vB/4a5awoOqq0I6VuxkqRlToeGwSV/5 rdovkA0btOrrBgNtNlGZBsoc9WaORK+DinsGs42CEdGjiUZQPYFdt3tjl5FaYRLPXA6loDLdeTK 4ZOpvQ1G5u50opf15JE8QP/k= X-Received: by 127.0.0.2 with SMTP id Kd56YY7687511xK3CYA4w8XR; Mon, 04 Mar 2024 11:32:45 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.862.1709580764690333521 for ; Mon, 04 Mar 2024 11:32:44 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C4062F4; Mon, 4 Mar 2024 11:33:21 -0800 (PST) X-Received: from [10.119.35.208] (unknown [10.119.35.208]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D716F3F738; Mon, 4 Mar 2024 11:32:42 -0800 (PST) Message-ID: <584da36e-10b0-46d6-a660-29fae1eded85@arm.com> Date: Mon, 4 Mar 2024 13:32:42 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/3] ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c To: Sam Kaynor , devel@edk2.groups.io Cc: Ray Ni , Zhichao Gao References: <20240124205605.69439-1-Sam.Kaynor@arm.com> <20240124205605.69439-2-Sam.Kaynor@arm.com> From: "Stuart Yoder" In-Reply-To: <20240124205605.69439-2-Sam.Kaynor@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,stuart.yoder@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QBP4gLbb6ZRxwdxKOcNrFONcx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SKcLlsLy; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Sam, See inline comments... On 1/24/24 2:56 PM, Sam Kaynor wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4352 >=20 > Implemented the dumping of the UEFI RT Properties Table using Dmem.c >=20 > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Sam Kaynor > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c = | 62 ++++++++++++++++++++ > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.= uni | 22 ++++++- > 2 files changed, 82 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c b/ShellPk= g/Library/UefiShellDebug1CommandsLib/Dmem.c > index a609971f345e..1ae7b1f3d85c 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > @@ -84,8 +84,63 @@ DisplayMmioMemory ( > return (ShellStatus); > } > =20 > +/** > + Display the RtPropertiesTable entries > + > + @param[in] Address The pointer to the RtPropertiesTable. > +**/ > +SHELL_STATUS > +DisplayRtProperties ( > + IN UINT64 Address > + ) > +{ > + EFI_RT_PROPERTIES_TABLE *RtPropertiesTable; > + UINT32 RtServices; > + SHELL_STATUS ShellStatus; > + EFI_STATUS Status; > + > + ShellStatus =3D SHELL_SUCCESS; > + > + if (Address !=3D 0) { > + Status =3D EfiGetSystemConfigurationTable (&gEfiRtPropertiesTableGui= d, (VOID **)&RtPropertiesTable); Why do you get the table address here, when it was already passed as an argument to this function. Thanks, Stuart -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116342): https://edk2.groups.io/g/devel/message/116342 Mute This Topic: https://groups.io/mt/103940858/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-