From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.55]) by mx.groups.io with SMTP id smtpd.web11.5746.1676407581027846152 for ; Tue, 14 Feb 2023 12:46:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=FWlcyLlK; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.101.55, mailfrom: pankaj.gupta@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IVKtBvRz9Y3yQSQtfV1mzlNvUeL/0lV0hwRms5pMri6qsPZjwngM9Zur9rLJWW1UeXl930jTvxoApvgrCcqO0YR2hrpc0MOvbqfk8sUQWN4rCfZBZB/FS1UHqiLMdGtcwM9SYKxL4Z5nHEp4ZMC3yxGm5wpgVVlu2VRbvjPE5xB2slNxgfcOG0PWTqi49fwttMVZyfjXBG97SR2TTKHQ5xftIUSzuD2fwRIkqPaSH7ydb3cvv8sDJqPEGxS19lZFQ3in+7KsZPt1UXVRHmLzBBOzelZQboMQG+a/ls8B9olEntAKGIlejXM+udD2n+9RNqCMVvHq28FB+O0z3BLYTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oVlWYd2qykWV4qKkMMhKoqhawMR8dZ97c2/ppD7KvXs=; b=bBMZH0Qt1rZtIFmF/itfZ6oEA8dzqBfZI49B3Uq2ljlby6x4smJ9RD2wbcLZ9eUrd3HtAZZbbN6ewHIhCcnQHbv8pvT5tjPleE/M0/gA4g1UzUo3/lOSetWLViyZll+pBQQ3BMaGbxnwgq057Q9zzz7quhaou5KnDDQA6Yd5ans3+y5LJXuMibURj311dIadsQbiT+yEBASwbaWQDHdRPZiDqnBFWCJN6RTH7sN9C5jpUaHPNSP937ShYaTaj+EGNK8QdrM1Tt2X3KHa2naQHikUZ0vVwzl0g/eZ8Q2FIGYchJsGheKfXVCaLG0xmq/Ag0mKVyyLYek7XEHk9k+wdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oVlWYd2qykWV4qKkMMhKoqhawMR8dZ97c2/ppD7KvXs=; b=FWlcyLlKGI6MAxQx5w9HAg9NE+j2f/hvdQsKOA3MQmuCgczTXNM9+CfwzknxF69+hFfhaRdttpZfb+P5tJ1IXEf6aOk7FQfvta/gmextbHuMsBSdX5V15x5AU2RFHXVe9Dn/bUQLaGDFO5dCjULSiY8EiHMQK+VcMjGhm8tHr5g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) by CY5PR12MB6549.namprd12.prod.outlook.com (2603:10b6:930:43::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 20:46:18 +0000 Received: from DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef]) by DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef%6]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 20:46:18 +0000 Message-ID: <5869d0a1-619a-52c2-81d8-81a2851e1585@amd.com> Date: Tue, 14 Feb 2023 21:46:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe To: Dionna Amalie Glaze Cc: devel@edk2.groups.io, Gerd Hoffmann , James Bottomley , Jiewen Yao , Tom Lendacky , Ard Biesheuvel , "Min M. Xu" , Andrew Fish , "Michael D. Kinney" References: <20230126005647.3019225-1-dionnaglaze@google.com> <20230126005647.3019225-2-dionnaglaze@google.com> <0d8f2b0b-1d62-3db6-34c9-e9ce39838bce@amd.com> <9ea61013-e2c1-30a4-3be7-feed537c035a@amd.com> <52c7d139-3763-b4f2-ab5c-a0a925a1a3ff@amd.com> <39f4b07d-43ce-904c-991d-4789384c496c@amd.com> <9a8e1ab8-c430-0a54-11be-581a2d9b6221@amd.com> From: "Gupta, Pankaj" In-Reply-To: X-ClientProxiedBy: FR2P281CA0103.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::13) To DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) Return-Path: Pankaj.Gupta@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB2810:EE_|CY5PR12MB6549:EE_ X-MS-Office365-Filtering-Correlation-Id: 08b31084-ab51-422a-420e-08db0ecc85d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0fA8UNXnU9Du/quU+KzxQrsdDS67ALCMUFUfSkWATbvx9pdPqO/RHmtx6YK4U0HTGK2C2wlvc3YtU02Too1IwwtZ/sbxOPn2LRUX9sfimot926UVwQglCoGXadCyYE5JQRcAu1GnGYuJYHHDVTQ3vHlVPsxN7fJZTrf8uiCDomC+T66Yf13BrNTp6KnNXTdo61nxB2lRT2IDAYObYxma36+N7fsgl95a76vWHWKlVAHRgdYf6jzNAbv4xFw+jtUaUxkZkcXBN152BlJKeNqv2fvApN4Fw9esdIfT7ajCFXXm3wvEk5mGeObEC8F1usDOw/4HSsI5Qlz1QQQ8MulsE8hGilcyFVn0MD7RZcWpC4vDZdahdYdCwNHRWe0UibZ+Tq7W7JIq3Tla6jza2e7ItmvoMtFyGZr2JayCnjaUlxIq2kil7HWJAUuqPeqjVNF4dqedI3YJEsvSQZlEMLRpA9kJxgW12aLLyVRTbMS0f1G6HF7f9H1IBn8wWK22+nzwTPfPVLcfAZVsEIdvCnVxzFrunRLhHelX6Uin70hVVxDPCECxIwT2i4+ypJUusXXye961DRVp+7utfg1tqgDoKgU6j/IwPvawHd+dE9KNa8MpqU2n3cdNK36iaKDrMpChnjIqAN4Kb4ABZY1dG3DHESInGl5sgQ/g+fNtDDwDCMbqUcCTRAhf5VvbfhoqUJ+G2P3jgtG3cWF0iceN4nigWzc3smiyZivn0twJgJM5cl0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2810.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(451199018)(4326008)(316002)(8676002)(66946007)(6916009)(31686004)(66476007)(66556008)(36756003)(41300700001)(54906003)(83380400001)(4744005)(5660300002)(53546011)(8936002)(478600001)(6486002)(2616005)(2906002)(38100700002)(31696002)(6512007)(86362001)(6666004)(26005)(186003)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1NWeDVwcUdmWXREU2sxV0oydU1hZk1qd29qSXIyVUFsNDcrcUd4bzlsdmtL?= =?utf-8?B?d2FvTmxPTllHN3BkN3lKTzE4alZ1dzVVelNwcVJsK1RrdWJJbk9CV3lORHVt?= =?utf-8?B?RkVxUG50UkJ0c0JkdkFZZkhXNDBqREdYUWRhUGNzNTFkcTRCb2dUVzFMZnVu?= =?utf-8?B?czkvZklhNlBtM2pQMWpLR3M4R0Z4d0xUdDBMUWNLVGh2dFpXSEdFY1M0dUl0?= =?utf-8?B?TWR3NWd3TU5yOWVnVWdLQlBWZ2wrTVZPZGtuZXRwRXNSQVByZUVaVlcxTysx?= =?utf-8?B?R0lFSCtWTm54R1hHNGdjRHVNVnFRN1FIQS9TallCWmRQK1hyK1dWZnl5R3N6?= =?utf-8?B?d05LempqS2RlUHdnMDU1V3RlTUFGUGpTL1ZKQVNHTnNNKzllNkNWZXFGWENI?= =?utf-8?B?R2U3eVRWQkFROFZ4N2pwSmNqUFdDanZzZVFoTXprS1RibGJIZFpBdnEvV0dR?= =?utf-8?B?Y0lPaGxDMWkxNXcrbHdnQW5SRHYwbjJTayt5K2Ftc1NiaWRGV3Jmb3R4S2ZS?= =?utf-8?B?OGVzM3VTQk9HOXpsOWI3M0FXNFFqOXdMdkUyaXpJRXYzOHh4VmNyTytwRDhM?= =?utf-8?B?bkhUeTFJaTZXaDRBT053bDg4bWVyazBPZlVpSHkvZ0dkREVpNC8rUkNJazRk?= =?utf-8?B?M1g1Q0RtNXhMcm1oejBWZHpqQmFOenpjUUo0RjY3WGZYdSs1dzd1WXdRZ1ZN?= =?utf-8?B?MHhtbkN6WkN3OHU3d2NJU0hMVmJ4cUI2SlNneFROYlRkR1p1RURqUkgveHVF?= =?utf-8?B?OWtCMmhFYTdscDhRMlVoR0NPblNzZWxaVGxhbk1lbVpJU0xNSStFREFwRWxL?= =?utf-8?B?djNTYVR3NmZnU0RkdldDemQ4K3Y3c1ZXeDZzeTdhb21zSktXdzdrQXhzcjNI?= =?utf-8?B?bGhKRmk1WkpXZ05YV0NWSFVGOGZ6eld2NEVMMlhDTlRSNE1IbjY5c281aUNX?= =?utf-8?B?WGYxY2MvU0RuaWVIcm9jS3U5RGtpWmpoQjNLZnB6TDdkSGFXcWFTYzR6MUV0?= =?utf-8?B?WVdTM0VablBTY0ZPQXp0UEpaVUZjK2dOZmNiWXVlM3M3QlF0bkFtcFVFOGps?= =?utf-8?B?a3JUUFF1dnBEUHZ4dHBDakRFdUFzLzNGZlN2eGJXUjkzRkVjUlVvdnpMRUgr?= =?utf-8?B?eHFrcUZvc3RpVlJyVUp5Q2hwenFzNGlxZ0JYdFNucER3d3N5UTRBcmJFWDA1?= =?utf-8?B?c25yaDVDeEx3WTgxc0dCd3ZuRGZqUkt3QktzemQ2ZUoxWkxnZ2xGN2RBWHly?= =?utf-8?B?cUNuQUxiTzFFbmhzQllPRWpFRXFzcVozY1BmUGFBK0JTUUZNNk9Pc2gvOEhl?= =?utf-8?B?dHZaVGhaU0FMSlJ4T1lQd0pBU1VjL1J3UVpHK3JSeFgvQW9DU3ltRmY4Tzhu?= =?utf-8?B?cS91MFJXRkhTY1pTcnNFaHkya242SisyU0JjeEpocXF1T3ZtYmZVN28wTEFm?= =?utf-8?B?Z28zSitYeENnMitYMkM5Vjg1R0pHbGN6T1VSWFc1TDJSWUJFMzBZeEdvYzRO?= =?utf-8?B?eHYyYmVxN2hmRzFuV2x5aDgyaXF1Vjg2dzUwR25CTEg2ZVI1VG5NV2loNW9F?= =?utf-8?B?MCtPREdIM0h5aEFzcnlSVHNpdjV5K1FqbDJSaUZTSEtPbklHVk1NTk5ZdDlR?= =?utf-8?B?Yzg1b0hpc21WL2JlZXdESjBiaHQwb0FqTkRzZ3RxQU9PbnpMVEZ0dkNXakUw?= =?utf-8?B?Z0NtQWF5Q0xQRnBEdEE5c21jN3VaT1h3RDhtSmZnYThTNWlwdm1LbnAxNXQv?= =?utf-8?B?V2JJKzhLamZTZk10dklBM1UrUmNuMVhLUEhEODVnd0hyTXpXa1hNeHpNWExi?= =?utf-8?B?VGhDRkVOY2JJYStlVnM1MHJPSks5QnhkYm1MRnNMWHp6emF0K0hyZzhRc0k2?= =?utf-8?B?eS9rSkZ6eDI5OC9rVjMrWEorQUNvUUQvcGJUei8yRXdPZUJyaDZGZWRvQjRE?= =?utf-8?B?MkZBL2hoZXpENFN3eENJQWdqNVA5ZlZnNVRxSnkxY2ttajg2NUpkVFFtNTNq?= =?utf-8?B?WG9yTGw5SWxnVHZQWEFMMHRXYjc1cjFKQ3lJL2JBenJWTTVaSHV6U2kzK0JV?= =?utf-8?B?ZDdRRndUZmZKcVJiVys4TkFudzFQUEFIWllBYUJIbHRTUVhPclVBWnBnU09R?= =?utf-8?Q?N0xpMirK2GMrpazeuXpu6nTCh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08b31084-ab51-422a-420e-08db0ecc85d2 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2810.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 20:46:18.6823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: feAHKGjytwDTuFE25i37HqUQbCCnEpNiT+VDLTCMQNS5y8JoAVaMCdjpGw4RZv67kF+SC9fpddfp/WESxDOrwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6549 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/14/2023 9:44 PM, Dionna Amalie Glaze wrote: >> >> Adding the diff. >> >> diff --git a/OvmfPkg/AmdSevDxe/AmdSevDxe.c b/OvmfPkg/AmdSevDxe/AmdSevDxe.c >> index 6391d1f775..df51c2c050 100644 >> --- a/OvmfPkg/AmdSevDxe/AmdSevDxe.c >> +++ b/OvmfPkg/AmdSevDxe/AmdSevDxe.c >> @@ -123,7 +123,7 @@ AcceptAllMemory ( >> } >> } >> >> - gBS->FreePool (AllDescMap); >> + //gBS->FreePool (AllDescMap);^M >> return Status; >> } >>> >>> Thanks, >>> Pankaj >>> >> > > Do you want to propose this patch or shall I? Seems like a necessary fix. I am doing that. Wanted confirmation from you. Thanks, Pankaj