From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 562187803CF for ; Fri, 1 Mar 2024 11:45:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Pg3Gclmm6RBiRJjlGPXM/ZEFueATRHejEXkCrxeEa68=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709293512; v=1; b=Lhm5QW+r8Zi7EdlKO5grFUC0XXRbsdgdyb9CStmCwlJZek2HPdoqEleTyQxNi/ByKnfzOT3B QmJHEI4Vbe0lM+MPh+X8rvSOyVValDEJH7NjHG0UQMdK+QXEKL8fCziCfCOb+5XatHclP34wDPP epHqrYwTHEdehdn0fDKkO6OQ= X-Received: by 127.0.0.2 with SMTP id 7xmWYY7687511xg4t2Pr8gZD; Fri, 01 Mar 2024 03:45:12 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.20754.1709293512191240858 for ; Fri, 01 Mar 2024 03:45:12 -0800 X-Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 4213a4GX019804; Fri, 1 Mar 2024 11:45:06 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wk7821247-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Mar 2024 11:45:05 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 421Bj4Aq004284 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 1 Mar 2024 11:45:04 GMT X-Received: from [10.251.42.70] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 1 Mar 2024 03:45:02 -0800 Message-ID: <58a4fbc9-36a0-4ebd-93a4-0e00fff7d293@quicinc.com> Date: Fri, 1 Mar 2024 11:45:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [RFC PATCH 1/1] ArmPkg,MdePkg: move ArmLib.h to MdePkg To: "Yao, Jiewen" , Pierre Gondois , "devel@edk2.groups.io" CC: Ard Biesheuvel , Liming Gao , "Kinney, Michael D" , Sami Mujawar , "Liu, Zhiguang" References: <20231121164228.766299-1-quic_llindhol@quicinc.com> <4951c86b-ecd8-4253-95e7-ceb00b8192b9@arm.com> <725dcaa0-8365-46d8-a6fe-f95b1d495518@arm.com> <128c59bc-dd86-4b26-81f7-ecc07f4c72ed@quicinc.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: JQXD5UjKWd7ZG3FwvrV6c2jY0NOr6pN3 X-Proofpoint-GUID: JQXD5UjKWd7ZG3FwvrV6c2jY0NOr6pN3 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 4213a4GX019804 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fdXnrHO8I0AFBGSTF0L53Fcjx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Lhm5QW+r; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thank you. OK, that's logically consistent. So we'd need an ArmLibNull in MdePkg until ArmLib itself migrates there=20 (ideally subsumed into BaseLib). But the dependency in .inf should still be able to be declared under [LibraryClasses.AArch64, LibraryClasses.ARM]? Regards, Leif On 2024-03-01 01:00, Yao, Jiewen wrote: > Sure. >=20 > When we say "dependency", what we really mean is the dependency in INF fi= le, not "dependency" in DSC file. >=20 > From package release perspective, only INF is the interface to other pac= kage. > The DSC is only the package internal stuff, you can create multiple DSCs = or add/remove DSC freely. >=20 > Having "dependency" in DSC does not matter. > Having dependency in INF is something we should care about. >=20 > Thank you > Yao, Jiewen >=20 >=20 >> -----Original Message----- >> From: Leif Lindholm >> Sent: Tuesday, February 13, 2024 1:38 AM >> To: Pierre Gondois ; devel@edk2.groups.io; Yao, >> Jiewen >> Cc: Ard Biesheuvel ; Liming Gao >> ; Kinney, Michael D ; >> Sami Mujawar ; Liu, Zhiguang >> >> Subject: Re: [RFC PATCH 1/1] ArmPkg,MdePkg: move ArmLib.h to MdePkg >> >> Jiewen, can you clarify what you said back in >> https://edk2.groups.io/g/devel/message/111551 >> ? >> >> On 2024-02-12 17:24, Pierre Gondois wrote: >>>>> A ArmLibNull.inf library might also need to be created. If the >>>>> OpensslLibFullAccel.inf module will depend on the ArmLib library, >>>>> a Null implementation will be necessary for non-Arm architectures. >>>> >>>> Can ArmLib be declared under a [LibraryClasses.AArch64, >>>> LibraryClasses.ARM]? Have I forgotten something that we discussed back >>>> in ... November? >>> >>> From [1], it seems the MdePkg/CryptoPkg should build without a depend= ency >>> on the ArmPkg. This is currently not really the case. cf. [2]. >>> >>> However, having a ArmLibNull implementation in the MdePkg would allow t= o >>> avoid going in this direction when providing libraries to CryptoPkg.dsc= . >>> >>> (Just in case, I think this ArmLibNull is a minor point.) >> >> Well, sure, it is now. >> Until we need a RiscV64LibNull, LoongarchLibNull, ... >> >>> [1] https://edk2.groups.io/g/devel/message/111545 >>> [2] >>> >> https://github.com/tianocore/edk2/blob/8801c75b4d77c2e6e06b3ddc8560e0db >> 590f6342/CryptoPkg/CryptoPkg.dsc#L117 >>> >>>> >>>>> Otherwise I could apply and run the CryptoPkg/Arm native instructions >>>>> patchset on top of this patch. >>>>> >>>>> --- >>>>> >>>>> As a side note, it also seems that: >>>>> - ArmPkg/Include/Chipset/ArmCortexA5x.h >>>>> =C2=A0 =C2=A0 isn't used anymore in edk2/edk2-platorms >>>>> - ArmPkg/Include/Chipset/ArmCortexA9.h >>>>> =C2=A0 =C2=A0 is barely used in edk2-platforms. >>>>> Maybe the files should have been removed/simplified as part of >>>>> - cffa7925a293 ("ArmPkg: remove ArmCpuLib header and implementations"= ) >>>>> - a913ad02479d ("ArmPlatformPkg: remove ArmVExpressPkg") >>>> >>>> I think you're right. >>>> Well, ArmCortexA9.h is still *used*, but I can't imagine the Arm branc= h >>>> of ArmVExpressLib has been build by anyone for some time. And surely t= he >>>> inclusion of ArmVExpressLibSec in ArmVExpress-FVP-AArch64.dsc is >>>> superfluous (such that that .inf can be deleted)? >>> >>> The file could just be moved in the Library. I assume you/Sami/Ard >>> will know more on the usage of the library itself, >> >> Sami? >> >> / >> Leif >> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116235): https://edk2.groups.io/g/devel/message/116235 Mute This Topic: https://groups.io/mt/102731845/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-