From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, abner.chang@hpe.com
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>,
Jian J Wang <jian.j.wang@intel.com>,
Xiaoyu Lu <xiaoyux.lu@intel.com>,
Leif Lindholm <leif@nuviainc.com>,
Gilbert Chen <gilbert.chen@hpe.com>
Subject: Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI.
Date: Mon, 13 Jul 2020 20:05:50 +0200 [thread overview]
Message-ID: <58c52e88-7df5-d7e8-56d0-e2e355ba64b9@redhat.com> (raw)
In-Reply-To: <4ec64acb-bd72-40c2-c994-38835cdc0a3e@redhat.com>
On 07/13/20 11:27, Laszlo Ersek wrote:
> Hi Abner,
>
> just noticed the following difference in this patch (now commit
> 9025a014f9d9a):
>
> On 03/06/20 06:36, Abner Chang wrote:
>
>> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
>> index 3fa52f5543..01ee665183 100644
>> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
>> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
>> @@ -661,6 +662,7 @@
>> GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
>> GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=unused-but-set-variable
>> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable
>> + GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable
>> GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>> GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
>
> vs.
>
>> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
>> index f1f9fbb938..5c2206f6fb 100644
>> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
>> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
>> @@ -610,6 +611,7 @@
>> GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
>> GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=unused-but-set-variable
>> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable
>> + GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable
>> GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>> GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
>
> Why do RISCV64_CC_FLAGS differ between "OpensslLib.inf" and
> "OpensslLibCrypto.inf"?
>
> The former has "-Wno-error=format" additionally. I think we should
> either remove it, or else add it to "OpensslLibCrypto.inf" as well.
>
> These INF files should be easily diffable against each other. The only
> differences should be (a) in the generated file list (the
> "OpensslLib.inf" file should list a bunch of "ssl/..." pathnames, while
> the other INF file should list none), and (b) in the BASE_NAME /
> MODULE_UNI_FILE / FILE_GUID defines.
>
> If you agree, can you please submit a patch, for eliminating the
> difference in RISCV64_CC_FLAGS?
I've filed <https://bugzilla.tianocore.org/show_bug.cgi?id=2848> about this.
Thanks
Laszlo
next prev parent reply other threads:[~2020-07-13 18:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 5:36 [edk2/master PATCH RISC-V CI Code Changes v1 00/11] Necessary code changes for RISCV64 CI testing Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 01/11] FatPkg: Add RISC-V architecture for EDK2 CI Abner Chang
2020-03-12 5:39 ` [edk2-devel] " Ni, Ray
2020-03-12 6:27 ` Abner Chang
2020-03-12 6:47 ` Liming Gao
2020-03-20 1:16 ` Michael D Kinney
2020-03-20 3:28 ` Liming Gao
2020-03-20 3:49 ` Bob Feng
2020-03-12 7:07 ` Ni, Ray
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 02/11] FmpDevicePkg: " Abner Chang
2020-03-27 3:20 ` [edk2-devel] " Liming Gao
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 03/11] NetworkPkg: " Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 04/11] NetworkPkg/HttpBootDxe: " Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: " Abner Chang
2020-03-17 9:19 ` Xiaoyu Lu
2020-07-13 9:27 ` [edk2-devel] " Laszlo Ersek
2020-07-13 18:05 ` Laszlo Ersek [this message]
2020-07-14 1:13 ` Abner Chang
2020-07-22 0:58 ` Guomin Jiang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 06/11] MdePkg/Include: Add RISC-V related definitions " Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 07/11] SecurityPkg: Security package changes for RISC-V " Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 08/11] ShellPkg: Shell " Abner Chang
2020-03-12 2:21 ` [edk2-devel] " Gao, Zhichao
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 09/11] UnitTestFrameworkPkg: Add RISC-V architecture " Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 10/11] MdePkg/DxeServicesLib: Add RISC-V architecture Abner Chang
2020-03-27 3:21 ` Liming Gao
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 11/11] MdeModulePkg: Use LockBoxNullLib for RISC-V Abner Chang
2020-03-19 8:01 ` [edk2-devel] " Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58c52e88-7df5-d7e8-56d0-e2e355ba64b9@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox