From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.2472.1594663571923121209 for ; Mon, 13 Jul 2020 11:06:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GVLe6JbI; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594663571; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ttPSKbmBgIocMF8EE4lki2CywICPq2OIjKFHIXx/Os=; b=GVLe6JbIznrGXnbOwUz1VeD1ZBJ8MMkgtwuK3GWVArlAAbd32Ytpnl5yzOMsRRT7sHTBTs cSdkj/OTBrPbiBF3s/m7gPPLswBr6qK1OI8ku5PY9iSD/ok0JZdDx97PTgBVR4JTNS9U3T ezPWgLIBLUBfjAXupG6wOZDVFe+uVpo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-A0xsnP6zMdSdsg4les73zw-1; Mon, 13 Jul 2020 14:06:02 -0400 X-MC-Unique: A0xsnP6zMdSdsg4les73zw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D94951096C68; Mon, 13 Jul 2020 18:05:53 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-183.ams2.redhat.com [10.36.114.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0052D10013C0; Mon, 13 Jul 2020 18:05:51 +0000 (UTC) Subject: Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI. From: "Laszlo Ersek" To: devel@edk2.groups.io, abner.chang@hpe.com Cc: Daniel Schaefer , Jian J Wang , Xiaoyu Lu , Leif Lindholm , Gilbert Chen Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20200306053620.12131-1-abner.chang@hpe.com> <20200306053620.12131-6-abner.chang@hpe.com> <4ec64acb-bd72-40c2-c994-38835cdc0a3e@redhat.com> Message-ID: <58c52e88-7df5-d7e8-56d0-e2e355ba64b9@redhat.com> Date: Mon, 13 Jul 2020 20:05:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4ec64acb-bd72-40c2-c994-38835cdc0a3e@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 07/13/20 11:27, Laszlo Ersek wrote: > Hi Abner, > > just noticed the following difference in this patch (now commit > 9025a014f9d9a): > > On 03/06/20 06:36, Abner Chang wrote: > >> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf >> index 3fa52f5543..01ee665183 100644 >> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf >> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf >> @@ -661,6 +662,7 @@ >> GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-error=unused-but-set-variable -DNO_MSABI_VA_FUNCS >> GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=unused-but-set-variable >> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable >> + GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable >> GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >> GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > > vs. > >> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >> index f1f9fbb938..5c2206f6fb 100644 >> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >> @@ -610,6 +611,7 @@ >> GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-error=unused-but-set-variable -DNO_MSABI_VA_FUNCS >> GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=unused-but-set-variable >> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable >> + GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable >> GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >> GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > > Why do RISCV64_CC_FLAGS differ between "OpensslLib.inf" and > "OpensslLibCrypto.inf"? > > The former has "-Wno-error=format" additionally. I think we should > either remove it, or else add it to "OpensslLibCrypto.inf" as well. > > These INF files should be easily diffable against each other. The only > differences should be (a) in the generated file list (the > "OpensslLib.inf" file should list a bunch of "ssl/..." pathnames, while > the other INF file should list none), and (b) in the BASE_NAME / > MODULE_UNI_FILE / FILE_GUID defines. > > If you agree, can you please submit a patch, for eliminating the > difference in RISCV64_CC_FLAGS? I've filed about this. Thanks Laszlo