From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web10.67005.1600106667504104532 for ; Mon, 14 Sep 2020 11:04:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bB4AG8cP; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600106666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IHiafz4deDfl5aiAFScjx+gh+6z0R9JdErgabqgcTts=; b=bB4AG8cPLsKEEubRb5zyS0SoRTnJayOTMNOhwiGu3fEwrYXP2UBWoq8P7rpPvgPrIV8H4N ca4joXIHdLyMbjsylFdNC28VaOIpROQX1I/WXILVmooa/oh0+Ys5T6xml4qKyDZdnykdI1 0+zPLNib46oRgwJt4Nuki1QohYmCerU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-H_zcoXKSPlWJski-s-dWTw-1; Mon, 14 Sep 2020 14:04:24 -0400 X-MC-Unique: H_zcoXKSPlWJski-s-dWTw-1 Received: by mail-wm1-f69.google.com with SMTP id y18so286781wma.4 for ; Mon, 14 Sep 2020 11:04:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=IHiafz4deDfl5aiAFScjx+gh+6z0R9JdErgabqgcTts=; b=oIAiZJIKgHZrjhD0n6+QM9MAIpxb2ImXYhrrxuuaIJ7KOl3D1yM8Ac6qeIpPPdHvt4 pyJZgKGv3SGy003Z67IfiOn9zjGSo62x6pmCD8X6FAxZKDR9yyS8HUaMn+nPwEufVR4R o+FST8R7HAjuoP5x20dxv0hYKwe3PbPOw5viiinLwI5Wh53sC67un+FXWR6xBUCnlv8w LMPo0UXieoIaN3WFlDuDsPmFQNhttBRoKVRMhc2vSjj57cI0qzZYjNj0vsM4t65vytiP O1AUzzZ8viL/IJkHt9Ig/MCepvXU0PPB4tcwoYJkyBtkUTbjFqsnj+sGL8nxMqfbBG0P +JwA== X-Gm-Message-State: AOAM532pUvLuqC5xUUY1cX97XqXhNw2kAU0aNLCeuwzjkHwgI8J6Inng kGKP9/oWKVK3SaZxRbpbOXmPnLyzpkztPJOxfkKEKAq3M1FjaP7Od9Sny2LPKEkL0ux/NmajgOk m/wBIc97TSMuQRw== X-Received: by 2002:a05:600c:2118:: with SMTP id u24mr553647wml.59.1600106663536; Mon, 14 Sep 2020 11:04:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztbijh+VhaKDx/DDs8F03oFzjr8O99eJsz2ZCqMrObdJuisrZy2KBgPhfnVTu+bz4vgKU+pQ== X-Received: by 2002:a05:600c:2118:: with SMTP id u24mr553619wml.59.1600106663251; Mon, 14 Sep 2020 11:04:23 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id b187sm19968559wmb.8.2020.09.14.11.04.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2020 11:04:22 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: drop redundant VendorID check in VirtioMmioDeviceLib To: devel@edk2.groups.io, leif@nuviainc.com Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel References: <20200912164022.5048-1-leif@nuviainc.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <58d1de2f-a48b-6563-684c-657a0ef99b0a@redhat.com> Date: Mon, 14 Sep 2020 20:04:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200912164022.5048-1-leif@nuviainc.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US On 9/12/20 6:40 PM, Leif Lindholm wrote: > There is a DEBUG warning printout in VirtioMmioDeviceLib if the current > device's VendorID does not match the traditional 16-bit Red Hat PCIe > vendor ID used with virtio-pci. The virtio-mmio vendor ID is 32-bit and > has no connection to the PCIe registry. > > Most specifically, this causes a bunch of noise when booting an AArch64 > QEMU platform, since QEMU's virtio-mmio implementation used 'QEMU' as > the vendor ID: > VirtioMmioInit: Warning: > The VendorId (0x554D4551) does not match the VirtIo VendorId (0x1AF4). > > Drop the warning message. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Leif Lindholm Reviewed-by: Philippe Mathieu-Daudé > --- > .../VirtioMmioDeviceLib/VirtioMmioDevice.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c > index 2f20272c1445..6dbbba008c75 100644 > --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c > +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c > @@ -58,7 +58,6 @@ VirtioMmioInit ( > ) > { > UINT32 MagicValue; > - UINT32 VendorId; > UINT32 Version; > > // > @@ -84,20 +83,6 @@ VirtioMmioInit ( > return EFI_UNSUPPORTED; > } > > - // > - // Double-check MMIO-specific values > - // > - VendorId = VIRTIO_CFG_READ (Device, VIRTIO_MMIO_OFFSET_VENDOR_ID); > - if (VendorId != VIRTIO_VENDOR_ID) { > - // > - // The ARM Base and Foundation Models do not report a valid VirtIo VendorId. > - // They return a value of 0x0 for the VendorId. > - // > - DEBUG((DEBUG_WARN, "VirtioMmioInit: Warning: The VendorId (0x%X) does not " > - "match the VirtIo VendorId (0x%X).\n", > - VendorId, VIRTIO_VENDOR_ID)); > - } > - > return EFI_SUCCESS; > } > >