Re: [edk2-devel] [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform

["WangYang" <wangyang@bosc.ac.cn>]

> -----原始邮件-----
> 发件人: "Sunil V L" <sunilvl@ventanamicro.com>
> 发送时间: 2024-01-11 23:21:21 (星期四)
> 收件人: devel@edk2.groups.io, andrei.warkentin@intel.com
> 抄送: "Yang Wang" <wangyang@bosc.ac.cn>, "Ran Wang" <wangran@bosc.ac.cn>, "Bamvor Jian ZHANG" <zhangjian@bosc.ac.cn>, "Gao, Liming" <gaoliming@byosoft.com.cn>, "Kinney, Michael D" <michael.d.kinney@intel.com>, "Liu, Zhiguang" <zhiguang.liu@intel.com>
> 主题: Re: [edk2-devel] [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform
> 
> On Fri, Jan 05, 2024 at 03:47:07PM +0000, Andrei Warkentin wrote:
> > Looks reasonable to me.
> > 
> > Reviewed-by: Andrei Warkentin <andrei.warkentin@intel.com>
> > 
> > > -----Original Message-----
> > > From: Yang Wang <wangyang@bosc.ac.cn>
> > > Sent: Wednesday, December 27, 2023 8:57 PM
> > > To: Warkentin, Andrei <andrei.warkentin@intel.com>; devel@edk2.groups.io
> > > Cc: Yang Wang <wangyang@bosc.ac.cn>; Ran Wang <wangran@bosc.ac.cn>;
> > > Bamvor Jian ZHANG <zhangjian@bosc.ac.cn>; Gao, Liming
> > > <gaoliming@byosoft.com.cn>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Sunil V L <sunilvl@ventanamicro.com>; Liu,
> > > Zhiguang <zhiguang.liu@intel.com>
> > > Subject: [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform
> > > 
> > > For scene of
> > > HandOffToDxeCore()->SwitchStack(DxeCoreEntryPoint)->
> > > InternalSwitchStack()->LongJump(),Variable HobList.Raw
> > > will be passed (from *Context1 to register a0) to
> > > DxeMain() in parameter *HobStart.
> > > 
> > > However, meanwhile the function LongJump() overrides
> > > register a0 with a1 (-1)  due to commit (ea628f28e5 "RISCV: Fix
> > > InternalLongJump to return correct value"), then cause hang.
> > > 
> > > Replacing calling LongJump() with new InternalSwitchStackAsm() to pass
> > > addres data in register s0 to register a0 could fix this issue (just
> > > like the solution in MdePkg/Library/BaseLib/AArch64/SwitchStack.S)
> > > 
> > > Signed-off-by: Yang Wang <wangyang@bosc.ac.cn>
> > > Reviewed-by: Ran Wang <wangran@bosc.ac.cn>
> > > Cc: Bamvor Jian ZHANG <zhangjian@bosc.ac.cn>
> > > Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > ---
> Thanks for the patch!. Merged this as #5255 after fixing a minor
> formatting issue.

Thank you.

> 
> Thanks,
> Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113785): https://edk2.groups.io/g/devel/message/113785
Mute This Topic: https://groups.io/mt/103395756/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-