From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, benjamin.doron00@gmail.com
Cc: Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Isaac Oram <isaac.w.oram@intel.com>,
Michael Kubacki <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 3/7] KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files
Date: Thu, 19 Aug 2021 20:16:23 -0400 [thread overview]
Message-ID: <58f4c098-2eed-c0bb-006f-2aef8ba06f46@linux.microsoft.com> (raw)
In-Reply-To: <20210818184903.7445-4-benjamin.doron00@gmail.com>
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
Carrying forward R-b from v2.
On 8/18/2021 2:48 PM, Benjamin Doron wrote:
> This makes diffing the follow-up board changes in these files easier.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
> ---
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/{DxeKabylakeRvp3AcpiTableLib.c => DxeAspireVn7Dash572GAcpiTableLib.c} | 0
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/{SmmKabylakeRvp3AcpiEnableLib.c => SmmAspireVn7Dash572GAcpiEnableLib.c} | 0
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/{KabylakeRvp3GpioTable.c => AspireVn7Dash572GGpioTable.c} | 0
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/{KabylakeRvp3HdaVerbTables.c => AspireVn7Dash572GHdaVerbTables.c} | 0
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/{KabylakeRvp3HsioPtssTables.c => AspireVn7Dash572GHsioPtssTables.c} | 0
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/{KabylakeRvp3SpdTable.c => AspireVn7Dash572GSpdTable.c} | 0
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/{PeiKabylakeRvp3Detect.c => PeiAspireVn7Dash572GDetect.c} | 0
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/{PeiKabylakeRvp3InitLib.h => PeiAspireVn7Dash572GInitLib.h} | 0
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/{PeiKabylakeRvp3InitPostMemLib.c => PeiAspireVn7Dash572GInitPostMemLib.c} | 0
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/{PeiKabylakeRvp3InitPreMemLib.c => PeiAspireVn7Dash572GInitPreMemLib.c} | 0
> 10 files changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeKabylakeRvp3AcpiTableLib.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeAspireVn7Dash572GAcpiTableLib.c
> similarity index 100%
> rename from Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeKabylakeRvp3AcpiTableLib.c
> rename to Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeAspireVn7Dash572GAcpiTableLib.c
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmKabylakeRvp3AcpiEnableLib.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c
> similarity index 100%
> rename from Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmKabylakeRvp3AcpiEnableLib.c
> rename to Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/KabylakeRvp3GpioTable.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GGpioTable.c
> similarity index 100%
> rename from Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/KabylakeRvp3GpioTable.c
> rename to Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GGpioTable.c
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/KabylakeRvp3HdaVerbTables.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GHdaVerbTables.c
> similarity index 100%
> rename from Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/KabylakeRvp3HdaVerbTables.c
> rename to Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GHdaVerbTables.c
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/KabylakeRvp3HsioPtssTables.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GHsioPtssTables.c
> similarity index 100%
> rename from Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/KabylakeRvp3HsioPtssTables.c
> rename to Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GHsioPtssTables.c
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/KabylakeRvp3SpdTable.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GSpdTable.c
> similarity index 100%
> rename from Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/KabylakeRvp3SpdTable.c
> rename to Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GSpdTable.c
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiKabylakeRvp3Detect.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GDetect.c
> similarity index 100%
> rename from Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiKabylakeRvp3Detect.c
> rename to Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GDetect.c
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiKabylakeRvp3InitLib.h b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitLib.h
> similarity index 100%
> rename from Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiKabylakeRvp3InitLib.h
> rename to Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitLib.h
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiKabylakeRvp3InitPostMemLib.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitPostMemLib.c
> similarity index 100%
> rename from Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiKabylakeRvp3InitPostMemLib.c
> rename to Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitPostMemLib.c
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiKabylakeRvp3InitPreMemLib.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitPreMemLib.c
> similarity index 100%
> rename from Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiKabylakeRvp3InitPreMemLib.c
> rename to Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitPreMemLib.c
>
next prev parent reply other threads:[~2021-08-20 0:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 18:48 [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Benjamin Doron
2021-08-18 18:48 ` [edk2-platforms][PATCH v3 1/7] KabylakeOpenBoardPkg/BaseEcLib: Add some common EC commands Benjamin Doron
2021-08-20 0:15 ` [edk2-devel] " Michael Kubacki
2021-08-26 3:49 ` Nate DeSimone
2021-08-18 18:48 ` [edk2-platforms][PATCH v3 2/7] KabylakeOpenBoardPkg/AspireVn7Dash572G: Duplicate KabylakeRvp3 directory Benjamin Doron
2021-08-20 0:16 ` [edk2-devel] " Michael Kubacki
2021-08-26 3:50 ` Nate DeSimone
2021-08-18 18:48 ` [edk2-platforms][PATCH v3 3/7] KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files Benjamin Doron
2021-08-20 0:16 ` Michael Kubacki [this message]
2021-08-26 3:49 ` Nate DeSimone
2021-08-18 18:48 ` [edk2-platforms][PATCH v3 4/7] Platform/Intel: Early hook-up Acer Aspire VN7-572G Benjamin Doron
2021-08-20 0:16 ` [edk2-devel] " Michael Kubacki
2021-08-26 3:49 ` Nate DeSimone
2021-08-18 18:49 ` [edk2-platforms][PATCH v3 5/7] KabylakeOpenBoardPkg/AspireVn7Dash572G: Add initial support Benjamin Doron
2021-08-20 0:17 ` [edk2-devel] " Michael Kubacki
2021-08-26 3:50 ` Nate DeSimone
2021-08-18 18:49 ` [edk2-platforms][PATCH v3 6/7] Maintainers.txt: Add myself as reviewer for AspireVn7Dash572G board Benjamin Doron
2021-08-20 0:18 ` [edk2-devel] " Michael Kubacki
2021-08-26 3:49 ` Nate DeSimone
2021-08-18 18:49 ` [edk2-platforms][PATCH v3 7/7] Platform/Intel/Readme.md: Add AspireVn7Dash572G to supported boards Benjamin Doron
2021-08-20 0:19 ` [edk2-devel] " Michael Kubacki
2021-08-26 3:49 ` Nate DeSimone
2021-08-26 3:53 ` [edk2-devel] [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Nate DeSimone
2021-08-26 3:58 ` Nate DeSimone
2021-08-26 4:08 ` Benjamin Doron
2021-08-26 21:19 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58f4c098-2eed-c0bb-006f-2aef8ba06f46@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox