public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.kubacki@outlook.com
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Siyuan Fu <siyuan.fu@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Maciej Rabeda <maciej.rabeda@linux.intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Jiaxin Wu <jiaxin.wu@intel.com>, Hao A Wu <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL
Date: Wed, 1 Apr 2020 01:55:02 +0200	[thread overview]
Message-ID: <58fc3ce6-b279-3974-a43d-803fe75bd964@redhat.com> (raw)
In-Reply-To: <MWHPR07MB3440A69B5AFAD0E373974FBFE9CC0@MWHPR07MB3440.namprd07.prod.outlook.com>

Hi Michael,

On 03/27/20 22:55, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> This patch series updates the GetVariable() implementation
> to return Attributes in the case EFI_BUFFER_TOO_SMALL is returned.
> 
> * [PATCH v3 1/3] Makes the functional change in the DXE/MM variable driver.
> * [PATCH v3 2/3] Makes the functional change in the PEI variable driver.
> * [PATCH v3 3/3] Removes a change made in NetworkPkg that worked around the
>   previous behavior when EFI_BUFFER_TOO_SMALL is returned.
> 
> V3 changes:
> * Apply the same GetVariable() behavior in VariablePei so it is consistent
>   with the DXE/MM variable driver implementation.

Can you please configure your git-send-email machinery to post patch
series with "shallow threading"? Otherwise the patch emails are not
linked under the cover letter, and they fly apart.

I'm asking in particular because this series modifies both MdeModulePkg
and NetworkPkg. In such cases usually one of the affected maintainers
volunteers for merging the full set (once review is complete for the
entire set). And collecting the individual patches without proper
shallow threading is very difficult.

The git options are the following:

git config sendemail.chainreplyto false
git config sendemail.thread       true

They are also put in place (with many other useful settings) by
"BaseTools/Scripts/SetupGit.py".

Or is there another problem with posting the patches? (I assume you post
the full set with a single git-send-email invocation.)

Thanks!
Laszlo


  reply	other threads:[~2020-03-31 23:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 21:55 [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL Michael Kubacki
2020-03-31 23:55 ` Laszlo Ersek [this message]
2020-04-01  1:15   ` [edk2-devel] " Michael Kubacki
2020-04-01  9:00     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58fc3ce6-b279-3974-a43d-803fe75bd964@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox