From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.1106.1585698910237345524 for ; Tue, 31 Mar 2020 16:55:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gFW7cR6L; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585698909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=12fhejv4mWfzn9FQW/XNCJq0pJw/7b4ajTWKOTWS+lo=; b=gFW7cR6LYSdoAJ0XnzjxBbPv+kAAsm4Nt1aJSdE5FoxH6gkcCaSgyMXy7BcsxgOnaXpGDg IRL9XkhEI5TSa3pJhV8F3zq1T8DxFTmWqx6/cjMzDyhjixvQkqpRu5Do3fFr+XWVWbQHSt 6P9CmsUtTFshft4xGtNfR9nzPy6NPyw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-hUVpavTgPcKhjmTHW8tjaQ-1; Tue, 31 Mar 2020 19:55:07 -0400 X-MC-Unique: hUVpavTgPcKhjmTHW8tjaQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 20BC58017CE; Tue, 31 Mar 2020 23:55:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-131.ams2.redhat.com [10.36.115.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED2B65D9C5; Tue, 31 Mar 2020 23:55:02 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL To: devel@edk2.groups.io, michael.kubacki@outlook.com Cc: Bret Barkelew , Siyuan Fu , Liming Gao , Michael D Kinney , Maciej Rabeda , Jian J Wang , Jiaxin Wu , Hao A Wu References: From: "Laszlo Ersek" Message-ID: <58fc3ce6-b279-3974-a43d-803fe75bd964@redhat.com> Date: Wed, 1 Apr 2020 01:55:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Michael, On 03/27/20 22:55, Michael Kubacki wrote: > From: Michael Kubacki > > This patch series updates the GetVariable() implementation > to return Attributes in the case EFI_BUFFER_TOO_SMALL is returned. > > * [PATCH v3 1/3] Makes the functional change in the DXE/MM variable driver. > * [PATCH v3 2/3] Makes the functional change in the PEI variable driver. > * [PATCH v3 3/3] Removes a change made in NetworkPkg that worked around the > previous behavior when EFI_BUFFER_TOO_SMALL is returned. > > V3 changes: > * Apply the same GetVariable() behavior in VariablePei so it is consistent > with the DXE/MM variable driver implementation. Can you please configure your git-send-email machinery to post patch series with "shallow threading"? Otherwise the patch emails are not linked under the cover letter, and they fly apart. I'm asking in particular because this series modifies both MdeModulePkg and NetworkPkg. In such cases usually one of the affected maintainers volunteers for merging the full set (once review is complete for the entire set). And collecting the individual patches without proper shallow threading is very difficult. The git options are the following: git config sendemail.chainreplyto false git config sendemail.thread true They are also put in place (with many other useful settings) by "BaseTools/Scripts/SetupGit.py". Or is there another problem with posting the patches? (I assume you post the full set with a single git-send-email invocation.) Thanks! Laszlo