From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web09.1726.1582796542782174413 for ; Thu, 27 Feb 2020 01:42:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GeHAfgpG; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582796541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sVtqTu0bIGf6mWjGxcEyGioENgHQOby5hfDvvhfOut8=; b=GeHAfgpGibNCvmJBs0W+CwVV8Q6/4WMgcuALBSsu8/yv2cCcTQ/omJRAkv2W8Bhb/YZPEw btgv7pjpBf/rq5NOGy8j3MAkQjLWJvkqHFIaTV8AYbjOgma+xoZTd4eUpjTWrkE3cADlpp 4ckzUOLex5ERxokxeppE3qMDVB7Hj1I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-444-ccGtRmLVPgemTfNCGiTgXQ-1; Thu, 27 Feb 2020 04:42:17 -0500 X-MC-Unique: ccGtRmLVPgemTfNCGiTgXQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7DB021050909; Thu, 27 Feb 2020 09:42:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-46.ams2.redhat.com [10.36.116.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAA861001B2C; Thu, 27 Feb 2020 09:42:14 +0000 (UTC) Subject: Re: [PATCH v3 9/9] ArmVirtPkg/ArmVirtQemu: enable TPM2 based measured boot To: Ard Biesheuvel , devel@edk2.groups.io Cc: eric.auger@redhat.com, philmd@redhat.com, marcandre.lureau@redhat.com, stefanb@linux.ibm.com, leif@nuviainc.com References: <20200226190514.31395-1-ard.biesheuvel@linaro.org> <20200226190514.31395-10-ard.biesheuvel@linaro.org> From: "Laszlo Ersek" Message-ID: <59217645-8f67-aa7f-201b-c7a57a28ccf8@redhat.com> Date: Thu, 27 Feb 2020 10:42:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200226190514.31395-10-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/26/20 20:05, Ard Biesheuvel wrote: > Now that all the TPM2 related plumbing is in place, we can add the > final piece that performs the measurements of loaded images into > the appropriate PCRs. > > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirtQemu.dsc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 7cb2d1b42fb8..a0d179a72b2a 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -346,6 +346,9 @@ [Components.common] > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf { > > NULL|SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.inf > +!if $(TPM2_ENABLE) == TRUE > + NULL|SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf > +!endif > } > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf > OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf > (1) Please state in the commit message: This patch ports commit d5a002aba0aa ("OvmfPkg: plug DxeTpm2MeasureBootLib into SecurityStubDxe", 2018-03-09) to ArmVirtQemu. With that: Reviewed-by: Laszlo Ersek Thanks! Laszlo