Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

["Oliver Smith-Denny" <osde@linux.microsoft.com>]

Hi Mike and Ray,

I'm here to bug you again :). I have another patchset that
unfortunately Liming has not gotten to review in a month's
time frame with weekly pings. When I bugged you last time,
he reviewed the next day, so something must have worked out
there. Can you please help get this merged?

Liming, do you need the community to find another member
to help as a second MdeModulePkg maintainer? It's obviously
a large job and you have been less responsive the past few
months, which has slowed down getting some really
important fixes into MdeModulePkg.

Thanks,
Oliver

On 3/20/2024 10:35 AM, Oliver Smith-Denny wrote:
> Hi Liming,
> 
> Another friendly ping, can you review these patches? 2 RBs and
> conversation has died down.
> 
> Thanks,
> Oliver
> 
> On 3/13/2024 10:33 AM, Oliver Smith-Denny wrote:
>> Hi Liming,
>>
>> Friendly ping, can you please review this patchset?
>>
>> Thanks,
>> Oliver
>>
>> On 3/11/2024 2:29 PM, Oliver Smith-Denny wrote:
>>> ImagePropertiesRecordLib is currently creating Image Records that
>>> are not accurate. It is setting the CodeSegmentSize to be the size
>>> of the raw data in the image file, however, when the image is
>>> loaded into memory, the raw data size is aligned to the
>>> section alignment. This caused the memory attributes table to
>>> have incorrect entries for systems, like ARM64, where the section
>>> alignment is not 4k for all modules.
>>>
>>> In fixing this, I noticed that MemoryProtection.c is using its own
>>> version of image record creation where this logic was actually
>>> correct. ImagePropertiesRecordLib was created to consolidate the
>>> logic around creating and managing image records, so this patchset
>>> also updates MemoryProtection.c to use ImagePropertiesRecordsLib
>>> after making a few small adjustments to ensure the same functionality
>>> is present.
>>>
>>> This patchset was tested on ArmVirtQemu to ensure that all image
>>> records were the same before and after this, other than fixing
>>> the CodeSegmentSize.
>>>
>>> v2:
>>> - Align VirtualSize instead of SizeOfRawData
>>>
>>> Github PR: https://github.com/tianocore/edk2/pull/5402
>>>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>>> Cc: Taylor Beebe <taylor.d.beebe@gmail.com>
>>>
>>> Oliver Smith-Denny (3):
>>>    MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for
>>>      CodeSize
>>>    MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage
>>>    MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib
>>>
>>> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c                            | 241 +++-----------------
>>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c |  86 +++++--
>>>   2 files changed, 94 insertions(+), 233 deletions(-)
>>>
>>
>>
>>
>>
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117178): https://edk2.groups.io/g/devel/message/117178
Mute This Topic: https://groups.io/mt/104873191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-