From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 64E7F7803DA for ; Wed, 27 Mar 2024 18:14:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2tLdoAu+ZI0+eA0d54enZavxS3fjRc5k3RO3m17c8cM=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711563274; v=1; b=NYQCwR19znQIvOv9GDcC6FBywsPP/cTia15nJiqA+fuQe1hPRvZpscwajP23oHtQkCCtR+0m rDWq+ZOjRz90ohq2Ah0JtxgZ6mZ5R8r6We04897w0DgvBkgqqz/g925nM5n9qFAhTtw1zzyJSi0 9dcQBcfDlQ4uGM6lWv0pYdrWdMgcgRqns+LgAuTjobvwTjQQvwaSqSbGJLMqGucNxvUkRORPwCo r6yvDD+q1zxT+eku1XqV2rg/vJ5pBrAAESnVAa2ovtX38TIaVy4s7YJbyFwp2Z74WGRMfwp/L+9 4EmnrTSajILyS6gK/eZxATEPTEBlnRTy+ETODJ/W8joyw== X-Received: by 127.0.0.2 with SMTP id GpaRYY7687511xeoWYJ9r08h; Wed, 27 Mar 2024 11:14:34 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.946.1711563274068310896 for ; Wed, 27 Mar 2024 11:14:34 -0700 X-Received: from [10.137.194.171] (unknown [131.107.159.43]) by linux.microsoft.com (Postfix) with ESMTPSA id 7C4A3209599A; Wed, 27 Mar 2024 11:14:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7C4A3209599A Message-ID: <5931dde2-607e-475e-87b8-4782493f05b3@linux.microsoft.com> Date: Wed, 27 Mar 2024 11:14:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes From: "Oliver Smith-Denny" To: devel@edk2.groups.io, Liming Gao , Michael Kinney , Ray Ni Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Taylor Beebe Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com References: <17BBD31426742776.6798@groups.io> <17BC63588355F2EE.10267@groups.io> <17BE8986E5F1B75A.24580@groups.io> In-Reply-To: <17BE8986E5F1B75A.24580@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 27 Mar 2024 11:14:34 -0700 List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MljlRg0GEp0tyhJ6DkR7A0NVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=NYQCwR19; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Mike and Ray, I'm here to bug you again :). I have another patchset that unfortunately Liming has not gotten to review in a month's time frame with weekly pings. When I bugged you last time, he reviewed the next day, so something must have worked out there. Can you please help get this merged? Liming, do you need the community to find another member to help as a second MdeModulePkg maintainer? It's obviously a large job and you have been less responsive the past few months, which has slowed down getting some really important fixes into MdeModulePkg. Thanks, Oliver On 3/20/2024 10:35 AM, Oliver Smith-Denny wrote: > Hi Liming, >=20 > Another friendly ping, can you review these patches? 2 RBs and > conversation has died down. >=20 > Thanks, > Oliver >=20 > On 3/13/2024 10:33 AM, Oliver Smith-Denny wrote: >> Hi Liming, >> >> Friendly ping, can you please review this patchset? >> >> Thanks, >> Oliver >> >> On 3/11/2024 2:29 PM, Oliver Smith-Denny wrote: >>> ImagePropertiesRecordLib is currently creating Image Records that >>> are not accurate. It is setting the CodeSegmentSize to be the size >>> of the raw data in the image file, however, when the image is >>> loaded into memory, the raw data size is aligned to the >>> section alignment. This caused the memory attributes table to >>> have incorrect entries for systems, like ARM64, where the section >>> alignment is not 4k for all modules. >>> >>> In fixing this, I noticed that MemoryProtection.c is using its own >>> version of image record creation where this logic was actually >>> correct. ImagePropertiesRecordLib was created to consolidate the >>> logic around creating and managing image records, so this patchset >>> also updates MemoryProtection.c to use ImagePropertiesRecordsLib >>> after making a few small adjustments to ensure the same functionality >>> is present. >>> >>> This patchset was tested on ArmVirtQemu to ensure that all image >>> records were the same before and after this, other than fixing >>> the CodeSegmentSize. >>> >>> v2: >>> - Align VirtualSize instead of SizeOfRawData >>> >>> Github PR: https://github.com/tianocore/edk2/pull/5402 >>> >>> Cc: Liming Gao >>> Cc: Leif Lindholm >>> Cc: Ard Biesheuvel >>> Cc: Sami Mujawar >>> Cc: Taylor Beebe >>> >>> Oliver Smith-Denny (3): >>> =C2=A0=C2=A0 MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignme= nt for >>> =C2=A0=C2=A0=C2=A0=C2=A0 CodeSize >>> =C2=A0=C2=A0 MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage >>> =C2=A0=C2=A0 MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesL= ib >>> >>> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 241 +++--= --------------- >>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.= c |=C2=A0 86 +++++-- >>> =C2=A0 2 files changed, 94 insertions(+), 233 deletions(-) >>> >> >> >> >> >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117178): https://edk2.groups.io/g/devel/message/117178 Mute This Topic: https://groups.io/mt/104873191/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-