From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.5371.1588073256153378528 for ; Tue, 28 Apr 2020 04:27:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RVs7T5VH; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588073255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=38yIK/IpXQlUWRCCEpym2oR3MplEiY8VBrFinIqJ6yA=; b=RVs7T5VHlN7rQu3LkgWcLbAJPk4F/jh7R0H5mVBoyMMHdD+1WawpCnsCrEx1Zyvfk9IF+7 en5B+bx0J0ouFi9BLOch10sLZj/FLR5ukrU1PTiAXhS5W5/jjtDhmR8+sFtZZMhqvqR8Do PHZMEK7FQsyh+53CU5e5wVgtY3LvMEY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-ciMlS8ZiO-S83bQkaY6kiQ-1; Tue, 28 Apr 2020 07:27:33 -0400 X-MC-Unique: ciMlS8ZiO-S83bQkaY6kiQ-1 Received: by mail-wr1-f70.google.com with SMTP id r17so12169192wrg.19 for ; Tue, 28 Apr 2020 04:27:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PJ+x8ftQ/hi0JPNSTXPMaDdHBi/4TZgCtAFviCDnq9k=; b=sFGc9YK+6SiQ28cdKDrr1FYooPJaHy68ddauSZRLzDgM4jEjNBn86PewASZcXiVVNm 17uMOmtleXAg4Hh9ftjsBEmtTux2Fzkc4aX3/39+a3yOCopqJmNqxo46OminGaDT6eHW gWQOMv8eYnK5ZvxT0vnpNXCQbBFUClFKAdlVT3P5WWz8rcHq2vQZ/rMdSYBXReWh2OBi JsO3qR0jA/SoR1VweoLGNLWnZMtjcmLe/u4KLpbTfr7q4hwHLqBuQ0io2SG498fwogMU 9MV9uUH1TcdS+e4JFH0CtFOY2G31d9vgPemsXi5VJsYcbPwsENpPIEqjZEiDaO9pZqAY jH3g== X-Gm-Message-State: AGi0Pua3T2lSywTpTNmakbRAYonIxsFBLvdcrO6hMBfGohNM+umz19R/ IRxsxTTYOJC1vudhG94F3VU9LI1vg4lZJX0VdnLLkEU6oNkjG9gX3C0bIMV2YzQI9ly94IG/2rR xREr8jCsDPuin1g== X-Received: by 2002:a05:600c:220c:: with SMTP id z12mr4020646wml.84.1588073252547; Tue, 28 Apr 2020 04:27:32 -0700 (PDT) X-Google-Smtp-Source: APiQypJeUQJ9VwvjI0M5dmmkZgwybSfAph4JAgd8V1Zxe53BIiJg4ahzPKyAJqtDEskmw9sGGfKR7Q== X-Received: by 2002:a05:600c:220c:: with SMTP id z12mr4020622wml.84.1588073252351; Tue, 28 Apr 2020 04:27:32 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (137.red-88-21-205.staticip.rima-tde.net. [88.21.205.137]) by smtp.gmail.com with ESMTPSA id 185sm3337790wmc.32.2020.04.28.04.27.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2020 04:27:31 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull To: Rebecca Cran , devel@edk2.groups.io, Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Andrew Fish , Leif Lindholm , Michael D Kinney References: <20200424182914.138915-1-rebecca@bsdio.com> <20200424182914.138915-3-rebecca@bsdio.com> <654ce10b-e878-64df-9778-122d3454cc89@bsdio.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <5934622c-7235-d073-cdf4-957d6b684c67@redhat.com> Date: Tue, 28 Apr 2020 13:27:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <654ce10b-e878-64df-9778-122d3454cc89@bsdio.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 4/27/20 7:33 PM, Rebecca Cran wrote: > On 4/27/20 3:03 AM, Philippe Mathieu-Daud=E9 wrote: >> >>> +#include >>> +#include >>> +#include >> >> Don't you need ? >=20 >=20 > Hmm, you're right. I'm not sure where I got=20 > "IndustryStandard/QemuFwCfg.h" from, though I noticed QemuFwCfg.h itself= =20 > includes a nonexistent version in IndustryStandard! >=20 >=20 > #ifndef __FW_CFG_LIB__ > #define __FW_CFG_LIB__ >=20 > #include >=20 >=20 > I'll fix this if/when I need to send a v5 series out, or since it=20 > doesn't seem to do any harm in a later patch. >=20 >=20 OK. Changing by : Reviewed-by: Philippe Mathieu-Daude