From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: supreeth.venkatesh@arm.com)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by groups.io with SMTP; Mon, 16 Sep 2019 09:06:25 -0700
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D332728;
	Mon, 16 Sep 2019 09:06:24 -0700 (PDT)
Received: from supven01-thinkstation-p720.austin.arm.com (supven01-thinkstation-p720.austin.arm.com [10.118.28.40])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CEAF63F67D;
	Mon, 16 Sep 2019 09:06:24 -0700 (PDT)
Message-ID: <59424a5d8f9eeb00230255652d0e2857032bd21c.camel@arm.com>
Subject: Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add FMP test to IHV SCT binary package
From: "Supreeth Venkatesh" <supreeth.venkatesh@arm.com>
To: "Jin, Eric" <eric.jin@intel.com>, "devel@edk2.groups.io"
	 <devel@edk2.groups.io>
Cc: shrishail patil <shrishail.patil@microchip.com>
Date: Mon, 16 Sep 2019 11:06:24 -0500
In-Reply-To: <DA72DC7456565B47808A57108259571F63812B64@SHSMSX103.ccr.corp.intel.com>
References: <15C352E4CE8DD33D.22511@groups.io>
	 <DA72DC7456565B47808A57108259571F63812B64@SHSMSX103.ccr.corp.intel.com>
X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


Eric,

Can you commit it as well?

Thanks,
Supreeth

On Mon, 2019-09-16 at 02:27 -0500, Jin, Eric wrote:
> The series is reviewed. 
> Reviewed-by: Eric Jin <eric.jin@intel.com>
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eric
> Jin
> Sent: Wednesday, September 11, 2019 3:51 PM
> To: devel@edk2.groups.io
> Cc: shrishail patil <shrishail.patil@microchip.com>; Supreeth
> Venkatesh <supreeth.venkatesh@arm.com>
> Subject: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add FMP
> test to IHV SCT binary package
> 
> From: shrishail patil <shrishail.patil@microchip.com>
> 
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Eric Jin <eric.jin@intel.com>
> Signed-off-by: shrishail patil <shrishail.patil@microchip.com>
> ---
>  uefi-sct/SctPkg/CommonGenFramework.bat | 3 ++-  uefi-
> sct/SctPkg/CommonGenFramework.sh  | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.bat b/uefi-
> sct/SctPkg/CommonGenFramework.bat
> index 5c614eaa9a74..42aefa8fb479 100644
> --- a/uefi-sct/SctPkg/CommonGenFramework.bat
> +++ b/uefi-sct/SctPkg/CommonGenFramework.bat
> @@ -2,6 +2,7 @@
>  @REM  Copyright 2006 - 2017 Unified EFI, Inc.<BR>  @REM  Copyright
> (c) 2010 - 2018, Intel Corporation. All rights
> reserved.<CR>  @REM  (C) Copyright 2017 Hewlett Packard Enterprise
> Development LP<BR>
> +@REM  Copyright (c) 2019,Microchip Technology Inc.<BR>
>  @REM
>  @REM  This program and the accompanying materials  @REM  are
> licensed and made available under the terms and conditions of the BSD
> License
> @@ -279,7 +280,7 @@ rem  copy
> %ProcessorType%\IhvUsbHcTest.efi                         %Framework%\
> T
>    copy
> %ProcessorType%\IhvUsb2HcTest.efi                        %Framework%\
> Test\ > NUL
>    copy
> %ProcessorType%\IhviScsiInitiatorNameBBTest.efi          %Framework%\
> Test\ > NUL
>    copy
> %ProcessorType%\IhvStorageSecurityCommandBBTest.efi      %Framework%\
> Test\ > NUL
> -  
> +  copy
> %ProcessorType%\IhvFirmwareManagementBBTest.efi          %Framework%\
> Test\ > NUL
>    rem *********************************************
>    rem Copy the UEFI 2.1 Test Cases for IHV
>    rem *********************************************
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-
> sct/SctPkg/CommonGenFramework.sh
> index c422034a6457..ed2b36aec42a 100755
> --- a/uefi-sct/SctPkg/CommonGenFramework.sh
> +++ b/uefi-sct/SctPkg/CommonGenFramework.sh
> @@ -4,6 +4,7 @@
>  #  Copyright (c) 2011 - 2019, ARM Ltd. All rights
> reserved.<BR>  #  Copyright (c) 2014 - 2018, Intel Corporation. All
> rights reserved.<CR>  #  (C) Copyright 2017 Hewlett Packard
> Enterprise Development LP<BR>
> +#  Copyright (c) 2019,Microchip Technology Inc.<BR>
>  #
>  #  This program and the accompanying materials  #  are licensed and
> made available under the terms and conditions of the BSD License @@
> -312,7 +313,7 @@ then
>    cp
> $ProcessorType/IhvUsb2HcTest.efi                        $Framework/Te
> st/ > NUL
>    cp
> $ProcessorType/IhviScsiInitiatorNameBBTest.efi          $Framework/Te
> st/ > NUL
>    cp
> $ProcessorType/IhvStorageSecurityCommandBBTest.efi      $Framework/Te
> st/ > NUL
> -
> +..cp
> $ProcessorType/IhvFirmwareManagementBBTest.efi          $Framework/Te
> st/ > NUL
>    # *********************************************
>    # Copy the UEFI 2.1 Test Cases for IHV
>    # *********************************************
> --
> 2.20.0.windows.1
> 
> 
> 
>