Re: [edk2-devel] [PATCH 07/16] OvmfPkg/CcExitLib: Add support for the SVSM_CORE_PVALIDATE call

["Lendacky, Thomas via groups.io" <thomas.lendacky=amd.com@groups.io>]

On 1/29/24 08:40, Gerd Hoffmann wrote:
>> -/**
>> - This function issues the PVALIDATE instruction to validate or invalidate the memory
>> - range specified. If PVALIDATE returns size mismatch then it retry validating with
>> - smaller page size.
>> -
>> - */
>> -STATIC
>> -VOID
>> -PvalidateRange (
>> -  IN  SNP_PAGE_STATE_CHANGE_INFO  *Info
>> -  )
> 
>> --- a/OvmfPkg/Library/CcExitLib/CcExitSvsm.c
>> +++ b/OvmfPkg/Library/CcExitLib/CcExitSvsm.c
> 
>> +#define PAGES_PER_2MB_ENTRY  512
> 
>> +SvsmTerminate (
>> +SvsmGetCaa (
>> +SvsmMsrProtocol (
> 
> Adding these three funcions can go to a separate patch.

Ok.

> 
>> +SvsmPvalidate (
> 
>> +        GfnEnd = Gfn + 511;
> 
> Use PAGES_PER_2MB_ENTRY here?

Ok.

> 
>> +BasePvalidate (
>> +  IN SNP_PAGE_STATE_CHANGE_INFO  *Info
>> +  )
> 
> So you rename PvalidateRange() to BasePvalidate() and move it to this
> place.  Moving code without functional change should be done as separate
> patch.
> 
> Also I'm wondering why you move the vmpl0 version of the function (which
> does *not* call into the SVSM) into the CcExitSvsm.c file.  The old
> place looks like a better fit to me.

Ok. Let me look at that again. That shouldn't be an issue to leave it 
where it is and do a pre-patch to rename it.

Thanks,
Tom

> 
> take care,
>    Gerd
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114720): https://edk2.groups.io/g/devel/message/114720
Mute This Topic: https://groups.io/mt/103986455/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-