From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5B1D178003C for ; Mon, 29 Jan 2024 17:34:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ERk1JNjFfCumI5HTeJ4X7ZQxOPepfnoNoFNYvd2HA8w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:Autocrypt:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706549662; v=1; b=PT5LG+O2spfYw2QAKNLitB2WmJfaHA0DoGiiL9RqjZoQ3cGP2UPiqIbBfQ7ckFn732nqxazp IJCYD/VevlK+GUPKVrRiDXFiHaRPnx4bq4954GaljYCUh6s3gXE0NqHYpG2vIrz7pDTGDynO9p7 2VPqQsj01Vbiqv9DkaBDFpkY= X-Received: by 127.0.0.2 with SMTP id 6FZaYY7687511xsVAzt4ehqM; Mon, 29 Jan 2024 09:34:22 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.51]) by mx.groups.io with SMTP id smtpd.web10.820.1706549661238972385 for ; Mon, 29 Jan 2024 09:34:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gRrHpHNaCWwG1a+DlvQyH7BMIvZflTEBaMaPGba3KUk0bOCC99SqXb7vG3Iyp6A6aMcN6hckbvbKu/tPu0N1GM5FYsLxQrhackiT51dXD9lRgLgiD/pCU+PLAV7L84ax9GGQe7igp9KOwURq8puxooH8yvN/viZc9X/NDsIbWi8KzjE3p5sOMIPXD59yDPCUh8QEnLen75IUo/L9j4sZHMsuRcFqpEqohnD/mLO8ZDFKqkkonYeFsO3gBT1W15WvOE8GnFihzH/vs3sGoRbUBmPU4zuF2CKpBW4KCgbJ3xYD4rSyyZ++uE+Q9K6s5CYluvfir61ysGtD5nYFhvzWHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RITM+DjFFuz4fwZs0Exrf8/a7cSfDuoXuyPJNUjZPcA=; b=ICkuAWeYQF0oCs6HzdgxlbdmonxE+VevPDae60mzUZBBV0+0WS8V/patZVbK5QkSYWd8D1n1oef+GbkonyL3xRzKnXO1UeYiqQcaOSFgriGPGcric/rBVCDoLIQZ+A3qMzohVmbyPTXp9VNXtOgigomKsK1aJWJwnjAEXiqNsVViDcavnd25B5ybz8DkeAZltin8XDht/RU0b6NSAI8Xz6xUDZctnUNw2eOkdP6zgUKhso3fHJBrR7cuWc60czevlEF2BKYJekvdYsP3rl6oEbMhxgJ1vj3dCr6LDgPQXdnnjSGb/7+cq3EDZ3s6D+HRUQHNuxAVDbOsVhdf/FZNaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) by MW3PR12MB4507.namprd12.prod.outlook.com (2603:10b6:303:2c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Mon, 29 Jan 2024 17:34:19 +0000 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c]) by BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c%4]) with mapi id 15.20.7228.029; Mon, 29 Jan 2024 17:34:18 +0000 Message-ID: <594d75db-3230-4057-918a-1dbe6c057eb8@amd.com> Date: Mon, 29 Jan 2024 11:34:16 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 07/16] OvmfPkg/CcExitLib: Add support for the SVSM_CORE_PVALIDATE call To: Gerd Hoffmann Cc: devel@edk2.groups.io, Ard Biesheuvel , Erdem Aktas , Jiewen Yao , Laszlo Ersek , Liming Gao , Michael D Kinney , Min Xu , Zhiguang Liu , Rahul Kumar , Ray Ni , Michael Roth References: <7bd1171077a547173d35f95a89387d13abdc8301.1706307195.git.thomas.lendacky@amd.com> From: "Lendacky, Thomas via groups.io" Autocrypt: addr=thomas.lendacky@amd.com; keydata= xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmWDAegFCRKq1F8ACgkQ 3v+a5E8wTVOG3xAAlLuT7f6oj+Wud8dbYCeZhEX6OLfyXpZgvFoxDu62OLGxwVGX3j5SMk0w IXiJRjde3pW+Rf1QWi/rbHoaIjbjmSGXvwGw3Gikj/FWb02cqTIOxSdqf7fYJGVzl2dfsAuj aW1Aqt61VhuKEoHzIj8hAanlwg2PW+MpB2iQ9F8Z6UShjx1PZ1rVsDAZ6JdJiG1G/UBJGHmV kS1G70ZqrqhA/HZ+nHgDoUXNqtZEBc9cZA9OGNWGuP9ao9b+bkyBqnn5Nj+n4jizT0gNMwVQ h5ZYwW/T6MjA9cchOEWXxYlcsaBstW7H7RZCjz4vlH4HgGRRIpmgz29Ezg78ffBj2q+eBe01 7AuNwla7igb0mk2GdwbygunAH1lGA6CTPBlvt4JMBrtretK1a4guruUL9EiFV2xt6ls7/YXP 3/LJl9iPk8eP44RlNHudPS9sp7BiqdrzkrG1CCMBE67mf1QWaRFTUDPiIIhrazpmEtEjFLqP r0P7OC7mH/yWQHvBc1S8n+WoiPjM/HPKRQ4qGX1T2IKW6VJ/f+cccDTzjsrIXTUdW5OSKvCG 6p1EFFxSHqxTuk3CQ8TSzs0ShaSZnqO1LBU7bMMB1blHy9msrzx7QCLTw6zBfP+TpPANmfVJ mHJcT3FRPk+9MrnvCMYmlJ95/5EIuA1nlqezimrwCdc5Y5qGBbbOwU0EVo1liQEQAL7ybY01 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+ LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe /5rkTzBNUwUCZYMCBQUJEqrUfAAKCRDe/5rkTzBNU7pAD/9MUrEGaaiZkyPSs/5Ax6PNmolD h0+Q8Sl4Hwve42Kjky2GYXTjxW8vP9pxtk+OAN5wrbktZb3HE61TyyniPQ5V37jto8mgdslC zZsMMm2WIm9hvNEvTk/GW+hEvKmgUS5J6z+R5mXOeP/vX8IJNpiWsc7X1NlJghFq3A6Qas49 CT81ua7/EujW17odx5XPXyTfpPs+/dq/3eR3tJ06DNxnQfh7FdyveWWpxb/S2IhWRTI+eGVD ah54YVJcD6lUdyYB/D4Byu4HVrDtvVGUS1diRUOtDP2dBJybc7sZWaIXotfkUkZDzIM2m95K oczeBoBdOQtoHTJsFRqOfC9x4S+zd0hXklViBNQb97ZXoHtOyrGSiUCNXTHmG+4Rs7Oo0Dh1 UUlukWFxh5vFKSjr4uVuYk7mcx80rAheB9sz7zRWyBfTqCinTrgqG6HndNa0oTcqNI9mDjJr NdQdtvYxECabwtPaShqnRIE7HhQPu8Xr9adirnDw1Wruafmyxnn5W3rhJy06etmP0pzL6frN y46PmDPicLjX/srgemvLtHoeVRplL9ATAkmQ7yxXc6wBSwf1BYs9gAiwXbU1vMod0AXXRBym 0qhojoaSdRP5XTShfvOYdDozraaKx5Wx8X+oZvvjbbHhHGPL2seq97fp3nZ9h8TIQXRhO+aY vFkWitqCJg== In-Reply-To: X-ClientProxiedBy: SA0PR11CA0176.namprd11.prod.outlook.com (2603:10b6:806:1bb::31) To BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_|MW3PR12MB4507:EE_ X-MS-Office365-Filtering-Correlation-Id: 073bdac2-8ca9-484f-e96b-08dc20f085b4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: pKJSAl/ySqvrkHs49/2wlPogvGnTM58AEs14WzifqS22R0sgVC2+UZxa97Nz+ixu7XDIPskOqM7UKdhpVteA2Gl2Qzjgurr5l8ttsDh4KDTg0xjboXy4045nfaYatwoiR8StgzzXuWxo783effzHzTFpKWNMQmWXTXSyjtOlWBcneqkhJ59764SNVx2vg97VdkevOICZL22gfHunu9uE7pDT6gO5nF2VLZ3huRlL82LLbKG/EHcxAH9xzxYwu/UtaihpY6EDmB6Dbb8eCQVw+krnQQXimIBtngv5ykFGPT8VlAyp6MB7NwaE8Fj5QeyGYEv3fSn/16220mgWel3N5aEl807cDuyFSm0Gp24nRTXgEwjUwBfG+aOJIQk6BGdrWYvd2KsITAvrt0SFqaUuOUxvnRwxDFFjf/a6Po/j4g+u3kCmBZz5hxZsMEYObxR3nt3R06H67WBrugMgz+TZzuerHEwEVZIEbnbE5yFaUQ9EAyZ0OR5J1alXeGiFGc7nGk+T7yCYmtyJPtIm7FM5LJaIH3icDRxaeK6X0Up9BOtnah4HXYile776fSEvBdP7uMrh5yFM2bpzCvafdS5xRyk03ldJTRlMBss2RRqvZj3fJpOgX9AwA2wuNDJXW9JAI/unV5btmN5LEg6y1py3Eg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEVnd0MzVU4yL1ZrZ01aRmNlbGszMktoSFpGKzAzakdDUnRqZWJ3ajAwMUt0?= =?utf-8?B?SU9mdGNVR2twWldJVGppRWQrZGsveHdXdXR6Vmd3WlI2TVQ4UWJ4YTFzNTMr?= =?utf-8?B?ZW1RQWVvT2VjelVDcGFGbFlKTGxEUFpmSjZWUWRWMklUUm9VSElqcm1Va2Fh?= =?utf-8?B?YzVpdEdnMS9JdVgzdkpTWTBWdVloQXVEL0lTVE9oK0w3bTZYdGYyYzd3N0pT?= =?utf-8?B?NmUrY3RDY2NSRGI2ekhPOW5qVWRzK093L3J5UHJxcUJxYmN5SzFoTlB4RlBr?= =?utf-8?B?ZHRhck9Rcmg5STFITjlmMDdWY284aTJNQVQ3RUwxUDg2OXFCdy9mZTM1Zk1S?= =?utf-8?B?OFRnRnBTaFg3VlVSMWM0L3dGUTlHZCtVaEIyd2ZVTHljRGtFc0RTYUVyaGlP?= =?utf-8?B?cHFvZDVoZy90Uks4Q2xZekVCaENXQWtXMzNPcWdmRnIrMDIrQTMxdWlpM2Jm?= =?utf-8?B?VWpBRmNhejJLL29LZS9ndXBZK3BkUGh5c0JzTHJMNElIYVNBNzI4U0dzczlr?= =?utf-8?B?NTYwSlFmMVpaM0ZjZFFLdHJQNEQ1c1VDbG9SL0M2QkV6MWprQjlKeHhXSTRP?= =?utf-8?B?YTlBZll5cElLZUtFdGNmcVk1MFVHZlA1NkFRUXUrbzJhUG9mUXJQLzFmU3pY?= =?utf-8?B?WDd4cDNrMFlmNUk5cVpMOHNaaW1LMkxmZHh5aGEzY215N1BRTkhabldoZU80?= =?utf-8?B?cGl4MnpOMnh2eDFselNFWjZkSVByUmhjLys4RmxwSyt0aDZOcHkwNlpucTNH?= =?utf-8?B?TTVmaXhBbTRYT041YkxucUNuMmQ0QmZXN3IyRG5qcEVRSUxnOFE4SlVaM0J4?= =?utf-8?B?Wk9GZnFKbEhxSGRXUTk5dUNpYUpYeXE1L0srVGs5dGhUNkMyZGc4dzFMcVEx?= =?utf-8?B?NEZ0ZFJDbnl3R1BuV0FaTFVvbXpDTXV5eU9TVDI1MG9YWlMxQnh0OEloaVkw?= =?utf-8?B?RmdxbVprY1ZMUTBZa1prZmhtdFNTU3YwN3VFWVZEdVl2K00ydlNaSWpkTmQy?= =?utf-8?B?OCsveVlKZVFVUzVKZ2N3ZFpzRTI0UVRweTdqQ0xCb1VwSXZJSkh0ZWVNcDZq?= =?utf-8?B?QnV4WVp6UWJ1eDVoVFE0SDhSMUFyU0NVLzZiTGdjRXFkVnZFL3ovbjAzV1J0?= =?utf-8?B?SWZaTkl3TUVFT1BTaTI3ck5JNmwwdXZ3QlhJMm9KRExrc0VkY1grai8vd1BB?= =?utf-8?B?aDU3QlR3QnNMOVplWDhhVmlZSlhrT1o1M2p6c1d0R1FkMGJPR0tmVXZvWk56?= =?utf-8?B?eHF0SGJrMUZaWlZOSWlGN0ZJZnQ1SG85cllyRGIyZkNjQXcwTkNDa3ZoYjdx?= =?utf-8?B?b2NXeXBOM3E0V3hJTW02ZS92NlNacmxGcGswS0hkanQ3d1BkdmtobUQyUXln?= =?utf-8?B?WU1WNTBxRTFycHpObytLMkN6NzdiMWIwcnZVNnZaKzhxRVFVVmZmRDNWTUI3?= =?utf-8?B?MG9aZFpCcFVKUzRXeUpUa0szOHJaSngrb0N1VVFYS2RDZUpudWVvVm4vR05H?= =?utf-8?B?SllmRFgrWnRjN1U0ZmFwakxlN2NpUnZTRkIvQ0xvWk1GRGUycWtvQzFzcy8x?= =?utf-8?B?MjV1OWo2dFR3QjJtZ21HUFQ0YkNkQnRheG5kb21kd1NGakN5RkkzS3kwdzhF?= =?utf-8?B?b2hQYnZpRjBqQ0hMRkJQb0NtYlJFZmx2SFNVNDZUdnFmcFpUVWlZallnQ1Vx?= =?utf-8?B?akV2a3Q5QlRWS0dDelBXK1o5bTFHN3hxZkMxaHh5dUtLajlNZzBEOGRFS0J1?= =?utf-8?B?NWMrVU5kSnFKYkJPVlpRSE5TQm14Ui9iVDkwU1FJSVA4NkJ4Z0ttN0xBM01i?= =?utf-8?B?U3hHTE5sWkhYOE0vOERzaE4xWjhJQVNjQmN3RmpqTFFETk15cXFuU0FyemUx?= =?utf-8?B?SHU1N1EzMWJCRWhnOUpSRmY1OGFyT0RPMGpZOS8waUVtZkRaN3h2SVNsc0lk?= =?utf-8?B?dSsrWG1lNzRSL0lBV3hnZmM1MXZnMGlmcjZ3dVZkRm5CRHBYTmxHQ0ZyZkhp?= =?utf-8?B?NmdQWW1MckVidElycVhnQWhPbzhRalhXeHNjeWxjOThHWnpaM2RjWXFnbnNq?= =?utf-8?B?SmtoR0pCUzJ2TzVOQXlpTTRrT2pUQ1V3N1lNeitIOGpick96Tm93VmpQUEh3?= =?utf-8?Q?wEaoDg70Zw7BR5CBQ7HpSJLiW?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 073bdac2-8ca9-484f-e96b-08dc20f085b4 X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 17:34:18.8612 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4aIr9gwKoe9rxzjk0d22Inq8+vS5sdIuYIAQPLer2u6VKmNbKHTkM7yUF0HwU5P0hXQHZCWy3Kg7W89DDNMjmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4507 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: A6NRvvGsF3CvwTQh0FYyfHrqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=PT5LG+O2; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/29/24 08:40, Gerd Hoffmann wrote: >> -/** >> - This function issues the PVALIDATE instruction to validate or invalida= te the memory >> - range specified. If PVALIDATE returns size mismatch then it retry vali= dating with >> - smaller page size. >> - >> - */ >> -STATIC >> -VOID >> -PvalidateRange ( >> - IN SNP_PAGE_STATE_CHANGE_INFO *Info >> - ) >=20 >> --- a/OvmfPkg/Library/CcExitLib/CcExitSvsm.c >> +++ b/OvmfPkg/Library/CcExitLib/CcExitSvsm.c >=20 >> +#define PAGES_PER_2MB_ENTRY 512 >=20 >> +SvsmTerminate ( >> +SvsmGetCaa ( >> +SvsmMsrProtocol ( >=20 > Adding these three funcions can go to a separate patch. Ok. >=20 >> +SvsmPvalidate ( >=20 >> + GfnEnd =3D Gfn + 511; >=20 > Use PAGES_PER_2MB_ENTRY here? Ok. >=20 >> +BasePvalidate ( >> + IN SNP_PAGE_STATE_CHANGE_INFO *Info >> + ) >=20 > So you rename PvalidateRange() to BasePvalidate() and move it to this > place. Moving code without functional change should be done as separate > patch. >=20 > Also I'm wondering why you move the vmpl0 version of the function (which > does *not* call into the SVSM) into the CcExitSvsm.c file. The old > place looks like a better fit to me. Ok. Let me look at that again. That shouldn't be an issue to leave it=20 where it is and do a pre-patch to rename it. Thanks, Tom >=20 > take care, > Gerd >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114720): https://edk2.groups.io/g/devel/message/114720 Mute This Topic: https://groups.io/mt/103986455/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-