Re: [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G limitation

["Zeng, Star" <star.zeng@intel.com>]

Jiewen,

Minor comments added inline below.

On 2016/12/12 14:35, Jiewen Yao wrote:
> Tcg2Dxe allocates event log below 4G. It is unnecessary.
>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> index 9e8dfae..ca28301 100644
> --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> @@ -1396,7 +1396,7 @@ SetupEventLog (
>        mTcgDxeData.EventLogAreaStruct[Index].EventLogFormat = mTcg2EventInfo[Index].LogFormat;
>        Lasa = (EFI_PHYSICAL_ADDRESS) (SIZE_4GB - 1);

How about also removing this line to reduce confusion?

>        Status = gBS->AllocatePages (
> -                      AllocateMaxAddress,
> +                      AllocateAnyPages,
>                        EfiBootServicesData,
>                        EFI_SIZE_TO_PAGES (PcdGet32 (PcdTcgLogAreaMinLen)),
>                        &Lasa
> @@ -1498,7 +1498,7 @@ SetupEventLog (
>        if (mTcg2EventInfo[Index].LogFormat == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2) {
>          Lasa = (EFI_PHYSICAL_ADDRESS) (SIZE_4GB - 1);

Same comment with above.

Thanks,
Star

>          Status = gBS->AllocatePages (
> -                        AllocateMaxAddress,
> +                        AllocateAnyPages,
>                          EfiACPIMemoryNVS,
>                          EFI_SIZE_TO_PAGES (PcdGet32 (PcdTcg2FinalLogAreaLen)),
>                          &Lasa
>