From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <star.zeng@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 2DEC182104
 for <edk2-devel@lists.01.org>; Sun, 11 Dec 2016 22:54:13 -0800 (PST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga105.fm.intel.com with ESMTP; 11 Dec 2016 22:54:12 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,334,1477983600"; d="scan'208";a="1080613607"
Received: from shzintpr01.sh.intel.com (HELO [10.253.24.23]) ([10.239.4.80])
 by fmsmga001.fm.intel.com with ESMTP; 11 Dec 2016 22:54:11 -0800
To: Jiewen Yao <jiewen.yao@intel.com>, edk2-devel@lists.01.org
References: <1481524542-3492-1-git-send-email-jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>, star.zeng@intel.com
From: "Zeng, Star" <star.zeng@intel.com>
Message-ID: <59526493-8ec1-43f4-02e8-5db845f6223a@intel.com>
Date: Mon, 12 Dec 2016 14:53:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1481524542-3492-1-git-send-email-jiewen.yao@intel.com>
Subject: Re: [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G limitation
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2016 06:54:13 -0000
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

Jiewen,

Minor comments added inline below.

On 2016/12/12 14:35, Jiewen Yao wrote:
> Tcg2Dxe allocates event log below 4G. It is unnecessary.
>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> index 9e8dfae..ca28301 100644
> --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> @@ -1396,7 +1396,7 @@ SetupEventLog (
>        mTcgDxeData.EventLogAreaStruct[Index].EventLogFormat = mTcg2EventInfo[Index].LogFormat;
>        Lasa = (EFI_PHYSICAL_ADDRESS) (SIZE_4GB - 1);

How about also removing this line to reduce confusion?

>        Status = gBS->AllocatePages (
> -                      AllocateMaxAddress,
> +                      AllocateAnyPages,
>                        EfiBootServicesData,
>                        EFI_SIZE_TO_PAGES (PcdGet32 (PcdTcgLogAreaMinLen)),
>                        &Lasa
> @@ -1498,7 +1498,7 @@ SetupEventLog (
>        if (mTcg2EventInfo[Index].LogFormat == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2) {
>          Lasa = (EFI_PHYSICAL_ADDRESS) (SIZE_4GB - 1);

Same comment with above.

Thanks,
Star

>          Status = gBS->AllocatePages (
> -                        AllocateMaxAddress,
> +                        AllocateAnyPages,
>                          EfiACPIMemoryNVS,
>                          EFI_SIZE_TO_PAGES (PcdGet32 (PcdTcg2FinalLogAreaLen)),
>                          &Lasa
>