From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.84]) by mx.groups.io with SMTP id smtpd.web11.24314.1629121679964660141 for ; Mon, 16 Aug 2021 06:48:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=VhIgKkZX; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.84, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bRXkp/eZK1l3KyJR4nhE66TdQoDysgK+Yk8wa/tDlDoExiT20hsFI83O8RmpLOT2XYW3/fO7ms8qngaGUCLnoWoH4lC6kx53DP5vFPwZ05xKPGO7uW9h5SRoIzUDjTofzPtdv2b6oE6v+dA36e9o22LGnVSLL3TixzWrSl7F3NKMvCP71rPrCToom6B26YBx96ta/RF6vTWjYC6fqf7ckQ5O+L5abkAjab5eq4F3Kq69At0VMxezaKSiGOErWShLZ9l2zcJKdghY7crHlswCgwxd/nvsHeEU7WG9S2rsDAC1ClcKLASzsPcGqgIOzj2Hk66j2lAAXaiqbS6KyXEggw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ztxueqVVJo/WrJcuMTprOJ6GfiquNJ168QV7XanlXrA=; b=MhTS217PJAmZQcEJmsKKFQnWmSC2boK4Ri2+TODvAalsb2RObZ/AWgcjH6oeIFasCYyE0WrFZiJ94Jf4+vfL8uLgDtTX1mu1DD/PFZJGVTXlpvjHqitycsZPHATOT1DtSoAz20oIzkMB/4MsW3TKwEc+Dx8fxv6fAZkA3IUgq704CCbINlN4Ez+hZH/a+RwBJW7jKEfvovvLPzh7bHkC1Tz8x9LT46ogxebOotamjTXWMW/jZ4h4Oeeo1SUOIilwTLrnqAHy8jBE53paVUSIjh6+O7fmOZLVTvVpRVAk+WMtE+tDb/rQgahmgDUW8bShEq4HgIVtkEotRjVkG3Skag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ztxueqVVJo/WrJcuMTprOJ6GfiquNJ168QV7XanlXrA=; b=VhIgKkZXh0IJRWLz3fp3cHCfiwvknqT+fFj+DIGtbtt2ezMNFK8cYrZMptaJwKxRIFuw9QcPnQo1Eqcn3500TN50DFg5YT+ySUkzJnVFkKAijph1Kgiui4sQWiqiLrF/LjJYUMRJ+nNvoVs0NpoHVw6j2oQ6xpc/2S68KkQruWo= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2367.namprd12.prod.outlook.com (2603:10b6:802:26::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13; Mon, 16 Aug 2021 13:47:58 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4415.023; Mon, 16 Aug 2021 13:47:58 +0000 Cc: brijesh.singh@amd.com, James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Erdem Aktas , Michael Roth Subject: Re: [PATCH v2 0/3] reuse the SevEsWork area To: "Xu, Min M" , "devel@edk2.groups.io" References: <20210805204214.27792-1-brijesh.singh@amd.com> From: "Brijesh Singh" Message-ID: <59565887-628f-dd1b-f82f-22d5458e4019@amd.com> Date: Mon, 16 Aug 2021 08:47:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: X-ClientProxiedBy: SN4PR0401CA0003.namprd04.prod.outlook.com (2603:10b6:803:21::13) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.236.31.95] (165.204.77.1) by SN4PR0401CA0003.namprd04.prod.outlook.com (2603:10b6:803:21::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.15 via Frontend Transport; Mon, 16 Aug 2021 13:47:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b43cdfa-4622-46e7-62c3-08d960bc74e7 X-MS-TrafficTypeDiagnostic: SN1PR12MB2367: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0e8h30VeAmTF5qAbfee+0ymYDpzkJabUnhCUwnBYg0oLLQFlNc7WXHthwNjqfsiETlqufGIUAXSPKFMqa8/g0w2WG2jMhbfII0uVdSmRHeDmzQUdOXa12aNp7lKROk7sqtcNCBBTaTnDKa5l3Pg45AqHJDO6o29Y0hSAn4b8a1B2rOmPAl9wC/EV1/mLxoo768cH8quo+DQrq4wQtcvC3Nw1QskeOZWuLwc8N5mlAi0jyJpF/5RPZW98iySjKjY7Q+hQmi5B5ThKDyU1oweeKj+Z2wRxVDAzjOsx+er5zoLkJt8dlv/LFAWtPLjdTPLdSojsJD9uaTqBP7OF9RCeleu5AHJTWc97pmIcHgtchLB2mFJ3TDG396KB1Dlw/9a4DRjRDLlbXEejKe0MkS2TPQxYEPcegAfjFEm74sA/cMQFXG7DPDr8zAeNeI1Mrf2uVPjtqHqrZFknWSKdrVuhFwCAeBXDYck1uvWo40stqdopqYs8BMot53/InfOC7yaXBhEdfoR3vJVmqicPZAJo2B5wnTQiBPnms7TilF7NayCzRUtqUbqVAGxRwgS6neVwfdsXA7joj2ExMBra3i2zisBc1uN+mi9Wx5ep8p6Efe7sabUFHVJ/hiKBxcKkas/j6s/piFe73hmnlfNIPtSRcAgmERSP+p8enhE2t45yu9+hCTOvZdedaTbFjsiVn4UzePXXrTVW1vXBlCglB072y5Fzpc8hq97bHf6Xo/jJ14WssfcuHfkRgmRazt+cYd+Hn4yJgjcuyMksgp+3OZjoWaB3CYVXHSYGGnrWv4N6ZOKRQYs/fjR2fWavrJCShB9X8Ko+B+sobWxqFKkkDuzVkah0ETLBNYbiUDk2vGmxCtU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(66556008)(66476007)(44832011)(38350700002)(6486002)(53546011)(52116002)(38100700002)(36756003)(8676002)(31696002)(66946007)(508600001)(8936002)(45080400002)(86362001)(110136005)(16576012)(54906003)(31686004)(186003)(19627235002)(2616005)(2906002)(4326008)(966005)(956004)(5660300002)(83380400001)(316002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnRYS1NJQ28vNk5NTUFVT3NvdjBPSVEyZjRneXdnSG9hZ3dmQ2c1NnY4YVJT?= =?utf-8?B?VVJJQm90L3dCRzVnd0E4THBXOTYya0VKQUZOQk9VQmdDT2hpcklGR2F1SDdW?= =?utf-8?B?NTRHeXlQOGh2cytpdjQ4OHN6WVdIeFFRbERWLzREVGxEYittTklDdjU1ZjBv?= =?utf-8?B?cjhNV09TTjFYM0F4RjJUZmtGTlJJTWh5VWppWVczb1A5VHF2NlFOUEllTnVp?= =?utf-8?B?djJEaXU4NndobkZGd1ZSY3JxSFpPZlE2dzMzQnZIQ2ZPYUxVSnpEdENIeGwv?= =?utf-8?B?bGF6REtPNEZpdFBpMlprdWdoSEZ1UG1aU1lCUFBkbi9WM1Z1OTdmNm5iNXg3?= =?utf-8?B?SXd6YVJKclJvZFZUMVpBeUNwK1Z1OEp5WHMySGpzTDlVejJhb3kvcVJuWURM?= =?utf-8?B?cEk3NUdpaUFXVS9uazVYV21tTmI2TVphZGNNRFM2WkEzYW5BMlFPOExVem5Z?= =?utf-8?B?ZmtwYkkxVDBNSkNaazRmZ3hVZDg4UTBYQlgrUmptcE0zMVRkQXp0VCsrTUEy?= =?utf-8?B?TkIrZkdzQlA4aWQwM2h6blZuSzlQNEFocDJybEN0bWNSSHIrU0lqR0FoczZP?= =?utf-8?B?SU9SR2VrNkF6M1BIU0NDQUhZbUVkOXhpN2k0cDFidFpTc1VMSUVvNmdFRlF2?= =?utf-8?B?UTFCZ1JEZUk4aDZYWkNsUjlQcUJJMDkvTmZwd1FpalJOT1VSeGUrWDhwY2J3?= =?utf-8?B?SmM1V21yeStCN2V4SVU1akR6MzF5bjNXNVBpcVNWZjFEYjNzQWNXYlVOMExN?= =?utf-8?B?cUlPeDRtdVV1SXl0WEQzQTJhNnZhZzNvOFRZalVQR2ZBZVpvYllJRGZLNnUw?= =?utf-8?B?dHVZK2VDYVJ4SHh3bldKUGNFQTlvNjJUYURYWWw4NmxlUWlSalRCb0JBdklt?= =?utf-8?B?dTZqQmY5RWJycWRxU284MnFHWjVwcWJKRGUrV1RrY3VpWEEwVmYyZFlyeDJw?= =?utf-8?B?K21qZ1hoYUNhUm1rL1dJY1pZeS9Tb0w1cFJwZ29kTlA0RGU4SnY3c1dWN3Q1?= =?utf-8?B?eDFacjl2d1dvZGJsOXVyUE9mb2VuSFIzMG9hYWg2NUFxMnNvemFUY2JaeFFZ?= =?utf-8?B?TzhaWCt3RTFJN2NrU2s4UkJZTjA5aVAyenJvVldXR2RDU1RZK3pkRUdrNzdr?= =?utf-8?B?NmFCVFhPdGJ3dmJsRUtCeUZaL1dQQi9mRzFUTGpYY1ova1BQNEJQdDRxZ09z?= =?utf-8?B?RUJyQ3VUUVVjNkhBSWNEVFJSUkI3MGFmR0xWL1NKN0ZkVUFiZThZVWJ4VDRs?= =?utf-8?B?aWJ1clR6MEp5MnY1OFdiKzFvNnZOL3J6VHpsdGNkVVlBMS94WVFqRUJYMTND?= =?utf-8?B?WjIwem5BQUtoSHVRSE40VDRMZ0NxNVgvc1BNeG5UTnZTYnlPN1BpOVExMmlC?= =?utf-8?B?bnhWRFZ6dnNrNGd6Vzc4a2hNSmt6ZXRkUkRHSjd6T0Ixc1RTWVBCTGlja1kz?= =?utf-8?B?bDBDNTdUV3ZNaTcwa2l3ZERSU0ZRbGJackFqRmZUUzdkMGN4ckozTy8vUmhH?= =?utf-8?B?SDlEY1FZWUFzNnNUaEdwcUxxNThGN2xMNHZnbER0RnF6KzQ3WjJ4bStMaHlZ?= =?utf-8?B?VUZsWDZZeVJPTTRGU2tMSjd2cXpUUURVd0UzdllhR3lNVURPVTZCSFlDOVFT?= =?utf-8?B?ZXhyTjRJU3lHQzNkc0ZPRXUrNFZNamdPam9zbGhEbVV6bXNIa2lsSUpsbkM4?= =?utf-8?B?MU1MWEJlYXRIczJCWFBtcFVLbmJNbmpvUXBaVS9tbWwvNnVSZGtDVnBiNzhS?= =?utf-8?Q?N/v+3E9Exg71Ekc9aHAYZkDfdhjgI6p9SExNEv3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b43cdfa-4622-46e7-62c3-08d960bc74e7 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2021 13:47:58.3743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jo1Yp+jUmHbXDVoWJlkBuxCy2T/gPQDaNezgLsSDOpeWa2tt5X6/MNyW3vRnivoG+iADI1Cpa1UjnGJNWuamzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2367 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Min, I was giving sometime for other reviewers to comment. I will respin v3 this week with Tom's feedback addressed. thanks On 8/14/21 10:00 PM, Xu, Min M wrote: > Hi, Brijesh > May I know is there some progress of this patch set? I noticed some comments have been given to the patch-set. > > Thanks! > Min > >> -----Original Message----- >> From: Brijesh Singh >> Sent: Friday, August 6, 2021 4:42 AM >> To: devel@edk2.groups.io >> Cc: James Bottomley ; Xu, Min M >> ; Yao, Jiewen ; Tom >> Lendacky ; Justen, Jordan L >> ; Ard Biesheuvel ; >> Erdem Aktas ; Michael Roth >> ; Brijesh Singh >> Subject: [PATCH v2 0/3] reuse the SevEsWork area >> >> Based on the discussion on the mailing list, we agreed that instead of wasting >> extra page in the MEMFD, we can reuse the SevEsWorkArea buffer for the >> TDX. To avoid any confusion, lets introduce a OvmfWorkArea that will >> contains 32 bytes of header followed by the actual workarea. >> >> While at it, move the code to clear the GHCB page from PageTable build to >> AmdSev.asm. >> >> I have used the existing TDX BZ for it because the request came during the >> TDX patch review. if anyone have concern please let me know and I will >> happily create a new BZ. >> >> Full tree is at: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAMDESE%2Fovmf%2Ftree%2Fsev-new-work-area&data=04%7C01%7Cbrijesh.singh%40amd.com%7C0e9d9486a8974e77448a08d95f98d95e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637645932352135436%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2kSK48j5Nghl5F%2FCDyun6tGkFRwTpb1QAf5kpPAnbIA%3D&reserved=0 >> >> Brijesh Singh (3): >> OvmfPkg: introduce a common work area >> OvmfPkg/ResetVector: update SEV support to use new work area format >> OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm >> >> Cc: James Bottomley >> Cc: Min Xu >> Cc: Jiewen Yao >> Cc: Tom Lendacky >> Cc: Jordan Justen >> Cc: Ard Biesheuvel >> Cc: Erdem Aktas >> >> Changes since v1: >> - address Jiewen's feedback. >> >> Brijesh Singh (3): >> OvmfPkg: introduce a common work area >> OvmfPkg/ResetVector: update SEV support to use new work area format >> OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm >> >> OvmfPkg/OvmfPkg.dec | 12 +++ >> OvmfPkg/OvmfPkgX64.fdf | 9 +- >> OvmfPkg/PlatformPei/PlatformPei.inf | 4 +- >> OvmfPkg/ResetVector/ResetVector.inf | 1 + >> OvmfPkg/Sec/SecMain.inf | 2 + >> OvmfPkg/Include/Library/MemEncryptSevLib.h | 21 +--- >> OvmfPkg/Include/WorkArea.h | 67 +++++++++++++ >> OvmfPkg/PlatformPei/MemDetect.c | 32 +++--- >> OvmfPkg/Sec/SecMain.c | 32 +++++- >> OvmfPkg/OvmfPkgDefines.fdf.inc | 6 ++ >> OvmfPkg/ResetVector/Ia32/AmdSev.asm | 111 +++++++++++++++++--- >> - >> OvmfPkg/ResetVector/Ia32/PageTables64.asm | 57 ++--------- >> OvmfPkg/ResetVector/ResetVector.nasmb | 1 + >> 13 files changed, 247 insertions(+), 108 deletions(-) create mode 100644 >> OvmfPkg/Include/WorkArea.h >> >> -- >> 2.17.1 >