From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B01871A1E04 for ; Fri, 19 Aug 2016 07:28:45 -0700 (PDT) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3CFA985A06; Fri, 19 Aug 2016 14:28:45 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-13.phx2.redhat.com [10.3.116.13]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7JESh95006033; Fri, 19 Aug 2016 10:28:44 -0400 To: "Fan, Jeff" , "edk2-devel@ml01.01.org" References: <1470128388-17960-1-git-send-email-jeff.fan@intel.com> <1470128388-17960-49-git-send-email-jeff.fan@intel.com> <4f61b2b4-eeb4-8435-412f-20848347c88e@redhat.com> <542CF652F8836A4AB8DBFAAD40ED192A143D9CFD@shsmsx102.ccr.corp.intel.com> <795dd4fe-cd16-c0f1-7f04-f78601e2c7a8@redhat.com> Cc: "Kinney, Michael D" , "Tian, Feng" From: Laszlo Ersek Message-ID: <5968c47a-fb3c-138b-e097-bf2f62a9d9c0@redhat.com> Date: Fri, 19 Aug 2016 16:28:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <795dd4fe-cd16-c0f1-7f04-f78601e2c7a8@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 19 Aug 2016 14:28:45 +0000 (UTC) Subject: Re: [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2016 14:28:45 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 08/19/16 04:26, Laszlo Ersek wrote: > On 08/19/16 04:00, Fan, Jeff wrote: >> Laszlo, >> >> I could revert this patch firstly. > > Thank you, that would be very kind. > >> Could you please dig out the OVMF to address the potential issue, then I could re-commit it for those platforms required this patch. > > The problem is that this week (what remains of it) and the next week I > won't really have time for this -- tomorrow I'm hoping to finish up > something else in a mortal hurry. It was actually in preparation for > rebasing / pushing that work that I pulled "master", and found out about > the regression. > > Can we perhaps get help from the variable stack maintainers? What's the > design of the (lack of) depexes on those drivers? > > Anyway, if you could live with the patch reverted for one or two weeks, > then reverting it would be best, IMO. It results in a regression, even > if ultimately it might only expose a bug in something else. I can see the revert (commit eadf70bdfbc1cb14a1d52b4840ca831d172d0399), thank you! As I said, I hope I can look into this (as well...) the week after next, or maybe a bit later... Sorry about the inconvenience :( Laszlo