From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Jianyong Wu <Jianyong.Wu@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "sunilvl@ventanamicro.com" <sunilvl@ventanamicro.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
Date: Tue, 28 Mar 2023 07:45:12 +0000 [thread overview]
Message-ID: <59955856-9117-4FD4-8037-50D1F7BAF1F1@arm.com> (raw)
In-Reply-To: <DB9PR08MB7511E58AEC12DC738D2BCFE6F4889@DB9PR08MB7511.eurprd08.prod.outlook.com>
Hi Jianyong,
Thank you for this fix.
The subject line should have the package name as prefix followed by the short description for the patch e.g. "ArmVirtPkg: xxx".
Other than that, this change looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 28/03/2023, 04:28, "Jianyong Wu" <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>> wrote:
Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>> and Sunil V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>> to cc list.
> -----Original Message-----
> From: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
> Sent: 2023年2月17日 14:48
> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>
> Cc: Jianyong Wu <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>>
> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
>
> commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
> missing in CloudHvHasAcpiDtDxe.inf which leads to
> gUefiOvmfPkgTokenSpaceGuid found nowhere.
>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
> ---
> ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> index 7cad40e11f..6ff80b24d0 100644
> --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> @@ -23,6 +23,7 @@
> EmbeddedPkg/EmbeddedPkg.dec
> MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> + OvmfPkg/OvmfPkg.dec
>
> [LibraryClasses]
> BaseLib
> --
> 2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
prev parent reply other threads:[~2023-03-28 7:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 6:48 [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid Jianyong Wu
2023-03-28 3:28 ` Jianyong Wu
2023-03-28 4:41 ` Sunil V L
2023-03-28 4:59 ` Sunil V L
2023-03-28 7:52 ` Sami Mujawar
2023-03-28 8:17 ` Jianyong Wu
2023-03-28 8:33 ` Sami Mujawar
2023-03-28 8:54 ` Jianyong Wu
2023-03-28 7:45 ` Sami Mujawar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59955856-9117-4FD4-8037-50D1F7BAF1F1@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox