From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id A0FA881EDC
 for <edk2-devel@ml01.01.org>; Thu, 17 Nov 2016 15:46:48 -0800 (PST)
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
 (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 013EEBAF0;
 Thu, 17 Nov 2016 23:46:53 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-6.phx2.redhat.com
 [10.3.116.6])
 by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 uAHNkpOR017034; Thu, 17 Nov 2016 18:46:51 -0500
To: Michael Kinney <michael.d.kinney@intel.com>, edk2-devel@ml01.01.org
References: <1479417550-20400-1-git-send-email-michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>, Andrew Fish <afish@apple.com>,
 Jeff Fan <jeff.fan@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <59c5c3b5-b00e-40af-8499-047e950b5437@redhat.com>
Date: Fri, 18 Nov 2016 00:46:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1479417550-20400-1-git-send-email-michael.d.kinney@intel.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.28]); Thu, 17 Nov 2016 23:46:53 +0000 (UTC)
Subject: Re: [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Nov 2016 23:46:48 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 11/17/16 22:19, Michael Kinney wrote:
> Add volatile qualifier to mNumberToFinish to prevent GCC 5.4
> compiler from optimizing away required logic in ACPI S3 resume.
> 
> Update TransferApToSafeState() use UINTN params to reduce the
> number of type casts required in these calls and change
> the NumberToFinish parameter from UINT32* to UINTN
> NumberToFinishAddress to resolve compiler warnings from
> a volatile pointer to a non-volatile pointer conversion.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Jeff Fan <jeff.fan@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
> 
> Michael Kinney (2):
>   UefiCpuPkg/PiSmmCpuDxeSmm: TransferApToSafeState() use UINTN params
>   UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile to mNumberToFinish
> 
>  UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c             | 10 +++++-----
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 18 +++++++++---------
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h    | 12 ++++++------
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c  | 18 +++++++++---------
>  4 files changed, 29 insertions(+), 29 deletions(-)
> 

series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>