public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: gua.guo@intel.com, devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Oliver Steffen <osteffen@redhat.com>,
	Chris Fernald <chfernal@microsoft.com>
Subject: Re: [PATCH v2 2/2] .azurepipelines: Choose container that have installed lcov
Date: Wed, 26 Apr 2023 21:28:33 -0400	[thread overview]
Message-ID: <59daced5-5254-5c7c-6152-5ad82b7bac0b@linux.microsoft.com> (raw)
In-Reply-To: <20230427003416.315-2-gua.guo@intel.com>

I agree with Mike that there should be more context in the commit 
message about the change that added lcov installation to the container 
(https://github.com/tianocore/containers/commit/f1c7a20f641852034b0d7e8c1b209407c92560f2).

Ideally, a summary of changes from the previous container version to 
this one would be provided.

As for the container change itself, it looks fine and I'll add an R-b 
now. As discussed, I think it would be nice to move to the Fedora 37 
image when possible.

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 4/26/2023 8:34 PM, gua.guo@intel.com wrote:
> From: Gua Guo <gua.guo@intel.com>
> 
> Azure should install code coverage tool (lcov), it didn't
> exist on Fedora and Ubuntu by default.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Oliver Steffen <osteffen@redhat.com>
> Cc: Chris Fernald <chfernal@microsoft.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>   .azurepipelines/templates/defaults.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.azurepipelines/templates/defaults.yml b/.azurepipelines/templates/defaults.yml
> index 74d6b41783..8412a43cad 100644
> --- a/.azurepipelines/templates/defaults.yml
> +++ b/.azurepipelines/templates/defaults.yml
> @@ -9,4 +9,4 @@
>   
> 
>   variables:
> 
>     default_python_version: ">=3.10.6"
> 
> -  default_linux_image: "ghcr.io/tianocore/containers/fedora-35-test:47addc9"
> 
> +  default_linux_image: "ghcr.io/tianocore/containers/fedora-35-test:3b3eb8f"
> 

  parent reply	other threads:[~2023-04-27  1:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27  0:34 [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure Guo, Gua
2023-04-27  0:34 ` [PATCH v2 2/2] .azurepipelines: Choose container that have installed lcov Guo, Gua
2023-04-27  0:52   ` Michael D Kinney
2023-04-27  1:23     ` Guo, Gua
2023-04-27  1:28   ` Michael Kubacki [this message]
2023-04-27  1:38   ` [edk2-devel] " Chris Fernald
2023-05-03 11:54   ` Oliver Steffen
2023-04-27  0:50 ` [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure Michael D Kinney
2023-04-27  1:20 ` [edk2-devel] " Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59daced5-5254-5c7c-6152-5ad82b7bac0b@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox