From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web11.10355.1682558915743447396
 for <devel@edk2.groups.io>;
 Wed, 26 Apr 2023 18:28:35 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=o5mePXd3;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 9893321C33CE;
	Wed, 26 Apr 2023 18:28:34 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9893321C33CE
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1682558915;
	bh=MK2345pSbBL7Lbw+1+4khvdUX7Iy5+9DVbo83Ojb7JQ=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=o5mePXd3Ai46SB9no8UclS+gMcBUr2y/EEFSWXFfqUOfbjqs587MUus64in2FvVz/
	 yuqGPNZvIrHlSRDxBupsZn75ItqN9RjHtFBSKBw+Urqybtm2OD61efJhnBT+vxZgJT
	 T9dx6zhAiPCzU74ejaz93du7hgrpNlcai+w0o1o8=
Message-ID: <59daced5-5254-5c7c-6152-5ad82b7bac0b@linux.microsoft.com>
Date: Wed, 26 Apr 2023 21:28:33 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 2/2] .azurepipelines: Choose container that have installed lcov
To: gua.guo@intel.com, devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
 Sean Brogan <sean.brogan@microsoft.com>, Oliver Steffen
 <osteffen@redhat.com>, Chris Fernald <chfernal@microsoft.com>
References: <20230427003416.315-1-gua.guo@intel.com>
 <20230427003416.315-2-gua.guo@intel.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20230427003416.315-2-gua.guo@intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

I agree with Mike that there should be more context in the commit 
message about the change that added lcov installation to the container 
(https://github.com/tianocore/containers/commit/f1c7a20f641852034b0d7e8c1b209407c92560f2).

Ideally, a summary of changes from the previous container version to 
this one would be provided.

As for the container change itself, it looks fine and I'll add an R-b 
now. As discussed, I think it would be nice to move to the Fedora 37 
image when possible.

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 4/26/2023 8:34 PM, gua.guo@intel.com wrote:
> From: Gua Guo <gua.guo@intel.com>
> 
> Azure should install code coverage tool (lcov), it didn't
> exist on Fedora and Ubuntu by default.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Oliver Steffen <osteffen@redhat.com>
> Cc: Chris Fernald <chfernal@microsoft.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>   .azurepipelines/templates/defaults.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.azurepipelines/templates/defaults.yml b/.azurepipelines/templates/defaults.yml
> index 74d6b41783..8412a43cad 100644
> --- a/.azurepipelines/templates/defaults.yml
> +++ b/.azurepipelines/templates/defaults.yml
> @@ -9,4 +9,4 @@
>   
> 
>   variables:
> 
>     default_python_version: ">=3.10.6"
> 
> -  default_linux_image: "ghcr.io/tianocore/containers/fedora-35-test:47addc9"
> 
> +  default_linux_image: "ghcr.io/tianocore/containers/fedora-35-test:3b3eb8f"
>