From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=67.231.154.164; helo=dispatch1-us1.ppe-hosted.com; envelope-from=tpilar@solarflare.com; receiver=edk2-devel@lists.01.org Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5F65221B02822 for ; Wed, 26 Sep 2018 03:10:20 -0700 (PDT) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 1D1A3B00064; Wed, 26 Sep 2018 10:10:19 +0000 (UTC) Received: from tp-desktop.uk.solarflarecom.com (10.17.20.51) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 26 Sep 2018 03:10:15 -0700 To: "Ni, Ruiyu" , "Carsey, Jaben" , "edk2-devel@lists.01.org" References: <3570196b-4027-284a-e332-3121621bdc7e@solarflare.com> From: "Tomas Pilar (tpilar)" Message-ID: <59dba417-d80a-e661-4cf5-867f9fa3ee60@solarflare.com> Date: Wed, 26 Sep 2018 11:10:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.17.20.51] X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24118.005 X-TM-AS-Result: No-7.380100-4.000000-10 X-TMASE-MatchedRID: fgYTp5XatxboSitJVour/eYAh37ZsBDCo4jW7zSDg9kNcckEPxfz2AVM 9kPsaYx47QaT/u+qBLPPCFEOaRxFk+t6WPBCckMjngIgpj8eDcC063Wh9WVqgmWCfbzydb0gZK/ Hc48pqbXkwjHXXC/4I8prJP8FBOIaFgV994xERWhfCj1Fy1WiqSXWHQuU69kjQhtwaDN1k/8T38 WgmpZNcw== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.380100-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24118.005 X-MDID: 1537956619-XPT7-S0uuuaQ Subject: Re: [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 10:10:20 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US Thanks, I'll respin. On 26/09/18 05:54, Ni, Ruiyu wrote: > On 9/25/2018 10:50 PM, Carsey, Jaben wrote: >> I would prefer we just delete this. >> >> Ray, >> What do you think? >> > Not sure I sent it or not. > I also prefer to delete it. Git history can help in future if we need it again.