From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=quzChjT3; spf=pass (domain: apple.com, ip: 17.151.62.68, mailfrom: afish@apple.com) Received: from nwk-aaemail-lapp03.apple.com (nwk-aaemail-lapp03.apple.com [17.151.62.68]) by groups.io with SMTP; Mon, 06 May 2019 19:32:29 -0700 Received: from pps.filterd (nwk-aaemail-lapp03.apple.com [127.0.0.1]) by nwk-aaemail-lapp03.apple.com (8.16.0.27/8.16.0.27) with SMTP id x472RC5V005107; Mon, 6 May 2019 19:32:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=mime-version : content-transfer-encoding : content-type : sender : subject : from : in-reply-to : date : cc : message-id : references : to; s=20180706; bh=lhsrFtWV7MhJCy8U/ICmP6gfba4K66Txs4D9JghFLxg=; b=quzChjT3hHdVzGKQEeWESb0AHDovb+9COXTtOh1w+peafya3VBO+uOX2xJsyU2Hkay08 1nvMxHgrkhQLhjKzDHHKYuPgZusaOEQx+bym6XnwqQB0pfnA+1RCnqaQeu+WHUVpdtyc ZXxxt/Bj2q7l7lU1uEsW+LUwQgKFljbt8BLJ5na0oOnwoz4w8jhXVFO9ZgHtHf1lZZ6t h/bHyeRiOgFujRhVCZNHYKRReYl/XLThJ0CHtEdIIhS84yAiYp30zeqKdlAtYWsznQQH RXmXFi8AgmPQQGd7soYVQW1OFKuiEqttBIiKUIodcIXvF5pKeu87RGbUEP1poRCa+cm9 Dw== Received: from ma1-mtap-s01.corp.apple.com (ma1-mtap-s01.corp.apple.com [17.40.76.5]) by nwk-aaemail-lapp03.apple.com with ESMTP id 2s9tyjj5bn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 06 May 2019 19:32:28 -0700 MIME-version: 1.0 Received: from nwk-mmpp-sz09.apple.com (nwk-mmpp-sz09.apple.com [17.128.115.80]) by ma1-mtap-s01.corp.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) with ESMTPS id <0PR4005604DYC200@ma1-mtap-s01.corp.apple.com>; Mon, 06 May 2019 19:32:27 -0700 (PDT) Received: from process_milters-daemon.nwk-mmpp-sz09.apple.com by nwk-mmpp-sz09.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) id <0PR4002003HXPA00@nwk-mmpp-sz09.apple.com>; Mon, 06 May 2019 19:32:25 -0700 (PDT) X-Va-A: X-Va-T-CD: 8b5b9ad92c19d2345dcc537fae79b67d X-Va-E-CD: cc9402d0a6211c664e189619ee1fe487 X-Va-R-CD: 0dad72254792c385e1dc205ddae095c4 X-Va-CD: 0 X-Va-ID: ee437457-3166-4c09-9fc1-8eb2d2beca4e X-V-A: X-V-T-CD: 8b5b9ad92c19d2345dcc537fae79b67d X-V-E-CD: cc9402d0a6211c664e189619ee1fe487 X-V-R-CD: 0dad72254792c385e1dc205ddae095c4 X-V-CD: 0 X-V-ID: 6c6d8970-2c5f-4664-a3ac-df5850bfd8fd X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-07_01:,, signatures=0 Received: from [17.235.35.155] (unknown [17.235.35.155]) by nwk-mmpp-sz09.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) with ESMTPSA id <0PR400IPW4CCMM70@nwk-mmpp-sz09.apple.com>; Mon, 06 May 2019 19:31:26 -0700 (PDT) Sender: afish@apple.com Subject: Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes From: "Andrew Fish" In-reply-to: Date: Mon, 06 May 2019 19:31:14 -0700 Cc: "Gao, Liming" , "Feng, Bob C" Message-id: <5C1A24BA-648D-4A3F-AE88-034073AB5C13@apple.com> References: To: devel@edk2.groups.io, zhijux.fan@intel.com X-Mailer: Apple Mail (2.3445.6.18) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-07_01:,, signatures=0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII This brings up a question? Do we tests on a file system that is case sensitive? Is this just lack of a test case? Thanks, Andrew Fish > On May 6, 2019, at 7:22 PM, Fan, ZhijuX wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1773 > > Build break if C file suffixes of named .C instead of .c > Code not recognize filenames with .C suffixes. > > This patch adds code to Support both .c file and .C file > > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Zhiju.Fan > --- > BaseTools/Source/Python/AutoGen/GenMake.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py > index 0e0f9fd9b0..858ddedf8e 100644 > --- a/BaseTools/Source/Python/AutoGen/GenMake.py > +++ b/BaseTools/Source/Python/AutoGen/GenMake.py > @@ -1035,7 +1035,8 @@ cleanlib: > CmdTargetDict[CmdSign] = "%s %s" % (CmdTargetDict[CmdSign], SingleCommandList[-1]) > Index = CommandList.index(Item) > CommandList.pop(Index) > - if SingleCommandList[-1].endswith("%s%s.c" % (TAB_SLASH, CmdSumDict[CmdSign.lstrip('/Fo').rsplit(TAB_SLASH, 1)[0]])): > + if SingleCommandList[-1].endswith("%s%s.c" % (TAB_SLASH, CmdSumDict[T.Target.SubDir])) or \ > + SingleCommandList[-1].endswith("%s%s.C" % (TAB_SLASH, CmdSumDict[T.Target.SubDir])): > Cpplist = CmdCppDict[T.Target.SubDir] > Cpplist.insert(0, '$(OBJLIST_%d): $(COMMON_DEPS)' % list(self.ObjTargetDict.keys()).index(T.Target.SubDir)) > T.Commands[Index] = '%s\n\t%s' % (' \\\n\t'.join(Cpplist), CmdTargetDict[CmdSign]) > -- > 2.14.1.windows.1 > > > > >