* [edk2-devel][edk2-test][PATCH] EFI/Protocol: Fix to use VENDOR_DEVICE_PATH to create the Debug port device node for DevicePath related protocol tests.
@ 2019-05-06 3:10 Nick Wang
2019-05-06 16:42 ` Supreeth Venkatesh
0 siblings, 1 reply; 3+ messages in thread
From: Nick Wang @ 2019-05-06 3:10 UTC (permalink / raw)
To: devel
Cc: "@intel.com >> Jin", Eric, Supreeth.Venkatesh,
ruth.li, leon.chen, sunny.hsu@insyde.com >> sunny hsu
[-- Attachment #1: Type: text/plain, Size: 2997 bytes --]
Follow edk2 tree hash: 9343d0a1cd09544686b14dba5b428d7bc811f6b9 to use
VENDOR_DEVICE_PATH to create the Debug port device node.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nick Wang
---
.../BlackBoxTest/DevicePathFromTextBBTestCoverage.c | 13 +++++++------
.../BlackBoxTest/DevicePathToTextBBTestMain.c | 5 +++--
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
index 96cd84fd..56128f2a 100644
---
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
+++
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c
@@ -2,6 +2,7 @@
Copyright 2006 - 2017 Unified EFI, Inc.
Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
+ Copyright (c) 2019, Insyde Software Corp. All Rights Reserved.
This program and the accompanying materials
are licensed and made available under the terms and conditions of the
BSD License
@@ -1114,13 +1115,13 @@ CreateDebugPortDeviceNode (
IN CHAR16 *TextDeviceNode
)
{
- VENDOR_DEFINED_MESSAGING_DEVICE_PATH *Vend;
+ VENDOR_DEVICE_PATH *Vend;
- Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode (
- DebugPortNodeType,
- DebugPortNodeSubType,
- sizeof(VENDOR_DEFINED_MESSAGING_DEVICE_PATH)
- );
+ Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode (
+ DebugPortNodeType,
+ DebugPortNodeSubType,
+ sizeof(VENDOR_DEVICE_PATH)
+ );
Vend->Guid = gBlackBoxEfiDebugPortProtocolGuid;
return (EFI_DEVICE_PATH_PROTOCOL *) Vend;
diff --git
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestMain.c
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestMain.c
index d0809776..2fe58337 100644
---
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestMain.c
+++
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestMain.c
@@ -2,6 +2,7 @@
Copyright 2006 - 2017 Unified EFI, Inc.
Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
+ Copyright (c) 2019, Insyde Software Corp. All Rights Reserved.
This program and the accompanying materials
are licensed and made available under the terms and conditions of the
BSD License
@@ -1708,9 +1709,9 @@ BuildDebugPortDeviceNode (
IN CHAR16 *TextDeviceNode
)
{
- VENDOR_DEFINED_MESSAGING_DEVICE_PATH *Vend;
+ VENDOR_DEVICE_PATH *Vend;
- Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode (0x3,
0x0a, sizeof (VENDOR_DEFINED_MESSAGING_DEVICE_PATH));
+ Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode (0x3, 0x0a, sizeof
(VENDOR_DEVICE_PATH));
Vend->Guid = gBlackBoxEfiDebugPortProtocolGuid;
--
2.19.1.windows.1
[-- Attachment #2: Type: text/html, Size: 4187 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel][edk2-test][PATCH] EFI/Protocol: Fix to use VENDOR_DEVICE_PATH to create the Debug port device node for DevicePath related protocol tests.
2019-05-06 3:10 [edk2-devel][edk2-test][PATCH] EFI/Protocol: Fix to use VENDOR_DEVICE_PATH to create the Debug port device node for DevicePath related protocol tests Nick Wang
@ 2019-05-06 16:42 ` Supreeth Venkatesh
2019-05-08 1:12 ` Eric Jin
0 siblings, 1 reply; 3+ messages in thread
From: Supreeth Venkatesh @ 2019-05-06 16:42 UTC (permalink / raw)
To: devel@edk2.groups.io, nick.wang@insyde.com
Cc: @intel.com >> Jin, Eric, ruth.li@intel.com,
leon.chen@insyde.com, sunny.hsu@insyde.com >> sunny hsu
Hi Nick,
Thanks for the patch.
On Sun, 2019-05-05 at 22:10 -0500, via Groups.Io wrote:
> Follow edk2 tree hash: 9343d0a1cd09544686b14dba5b428d7bc811f6b9 to
> use VENDOR_DEVICE_PATH to create the Debug port device node.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Nick Wang
Please add your email E.g., Signed-off-by: Name <email>
> ---
> .../BlackBoxTest/DevicePathFromTextBBTestCoverage.c | 13 +++++++-----
> -
> .../BlackBoxTest/DevicePathToTextBBTestMain.c | 5 +++--
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c
> index 96cd84fd..56128f2a 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c
> @@ -2,6 +2,7 @@
>
> Copyright 2006 - 2017 Unified EFI, Inc.
>
> Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
>
> + Copyright (c) 2019, Insyde Software Corp. All Rights Reserved.
>
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the
> BSD License
> @@ -1114,13 +1115,13 @@ CreateDebugPortDeviceNode (
> IN CHAR16 *TextDeviceNode
> )
> {
> - VENDOR_DEFINED_MESSAGING_DEVICE_PATH *Vend;
> + VENDOR_DEVICE_PATH *Vend;
>
> - Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode (
> - DebugPortNodeType,
> - DebugPortNodeSubType,
> - sizeof(VENDOR_DEFINED_MESSAGING_DEVICE_PATH)
> - );
> + Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode (
> + DebugPortNodeType,
> + DebugPortNodeSubType,
> + sizeof(VENDOR_DEVICE_PATH)
> + );
> Vend->Guid = gBlackBoxEfiDebugPortProtocolGuid;
>
> return (EFI_DEVICE_PATH_PROTOCOL *) Vend;
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c
> index d0809776..2fe58337 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c
> @@ -2,6 +2,7 @@
>
> Copyright 2006 - 2017 Unified EFI, Inc.
>
> Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
>
> + Copyright (c) 2019, Insyde Software Corp. All Rights Reserved.
>
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the
> BSD License
> @@ -1708,9 +1709,9 @@ BuildDebugPortDeviceNode (
> IN CHAR16 *TextDeviceNode
> )
> {
> - VENDOR_DEFINED_MESSAGING_DEVICE_PATH *Vend;
> + VENDOR_DEVICE_PATH *Vend;
>
> - Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode
> (0x3, 0x0a, sizeof (VENDOR_DEFINED_MESSAGING_DEVICE_PATH));
> + Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode (0x3, 0x0a, sizeof
> (VENDOR_DEVICE_PATH));
Can you please define meaningful macros/constants for 0x03 and 0x0a
(E.g., DebugNodeType, DebugNodeSubType) ?
>
>
> Vend->Guid = gBlackBoxEfiDebugPortProtocolGuid;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel][edk2-test][PATCH] EFI/Protocol: Fix to use VENDOR_DEVICE_PATH to create the Debug port device node for DevicePath related protocol tests.
2019-05-06 16:42 ` Supreeth Venkatesh
@ 2019-05-08 1:12 ` Eric Jin
0 siblings, 0 replies; 3+ messages in thread
From: Eric Jin @ 2019-05-08 1:12 UTC (permalink / raw)
To: devel@edk2.groups.io, supreeth.venkatesh@arm.com,
nick.wang@insyde.com
Cc: @intel.com >> Jin, Li, Ruth, leon.chen@insyde.com,
sunny.hsu@insyde.com >> sunny hsu
Hi Nick,
Thank you for the patch.
Comments (same as Supreeth) as below.
1. Please add your email . E.g: Signed-off-by: Nick Wang <nick.wang@insyde.com>
2. replace 0x03 and 0x0a with meaningful macros. The macro can be defined in SctPkg/UEFI/Protocol/DevicePath.h
Best Regards
Eric
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Supreeth Venkatesh
Sent: Tuesday, May 7, 2019 12:42 AM
To: devel@edk2.groups.io; nick.wang@insyde.com
Cc: @intel.com >> Jin <IMCEAINVALID-+40intel+2Ecom+20+3E+3E+20Jin@arm.com>; Jin, Eric <eric.jin@intel.com>; Li, Ruth <ruth.li@intel.com>; leon.chen@insyde.com; sunny.hsu@insyde.com >> sunny hsu <sunny.hsu@insyde.com>
Subject: Re: [edk2-devel][edk2-test][PATCH] EFI/Protocol: Fix to use VENDOR_DEVICE_PATH to create the Debug port device node for DevicePath related protocol tests.
Hi Nick,
Thanks for the patch.
On Sun, 2019-05-05 at 22:10 -0500, via Groups.Io wrote:
> Follow edk2 tree hash: 9343d0a1cd09544686b14dba5b428d7bc811f6b9 to use
> VENDOR_DEVICE_PATH to create the Debug port device node.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Nick Wang
Please add your email E.g., Signed-off-by: Name <email>
> ---
> .../BlackBoxTest/DevicePathFromTextBBTestCoverage.c | 13 +++++++-----
> -
> .../BlackBoxTest/DevicePathToTextBBTestMain.c | 5 +++--
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c
> index 96cd84fd..56128f2a 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest
> /DevicePathFromTextBBTestCoverage.c
> @@ -2,6 +2,7 @@
>
> Copyright 2006 - 2017 Unified EFI, Inc.
>
> Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
>
> + Copyright (c) 2019, Insyde Software Corp. All Rights Reserved.
>
>
> This program and the accompanying materials are licensed and made
> available under the terms and conditions of the BSD License @@
> -1114,13 +1115,13 @@ CreateDebugPortDeviceNode ( IN CHAR16
> *TextDeviceNode
> )
> {
> - VENDOR_DEFINED_MESSAGING_DEVICE_PATH *Vend;
> + VENDOR_DEVICE_PATH *Vend;
>
> - Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode (
> - DebugPortNodeType,
> - DebugPortNodeSubType,
> - sizeof(VENDOR_DEFINED_MESSAGING_DEVICE_PATH)
> - );
> + Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode ( DebugPortNodeType,
> + DebugPortNodeSubType,
> + sizeof(VENDOR_DEVICE_PATH)
> + );
> Vend->Guid = gBlackBoxEfiDebugPortProtocolGuid;
>
> return (EFI_DEVICE_PATH_PROTOCOL *) Vend; diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c
> index d0809776..2fe58337 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/D
> evicePathToTextBBTestMain.c
> @@ -2,6 +2,7 @@
>
> Copyright 2006 - 2017 Unified EFI, Inc.
>
> Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
>
> + Copyright (c) 2019, Insyde Software Corp. All Rights Reserved.
>
>
> This program and the accompanying materials are licensed and made
> available under the terms and conditions of the BSD License @@ -1708,9
> +1709,9 @@ BuildDebugPortDeviceNode ( IN CHAR16 *TextDeviceNode
> )
> {
> - VENDOR_DEFINED_MESSAGING_DEVICE_PATH *Vend;
> + VENDOR_DEVICE_PATH *Vend;
>
> - Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode
> (0x3, 0x0a, sizeof (VENDOR_DEFINED_MESSAGING_DEVICE_PATH));
> + Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode (0x3, 0x0a, sizeof
> (VENDOR_DEVICE_PATH));
Can you please define meaningful macros/constants for 0x03 and 0x0a (E.g., DebugNodeType, DebugNodeSubType) ?
>
>
> Vend->Guid = gBlackBoxEfiDebugPortProtocolGuid;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-08 1:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-06 3:10 [edk2-devel][edk2-test][PATCH] EFI/Protocol: Fix to use VENDOR_DEVICE_PATH to create the Debug port device node for DevicePath related protocol tests Nick Wang
2019-05-06 16:42 ` Supreeth Venkatesh
2019-05-08 1:12 ` Eric Jin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox