Re: [edk2-devel] [PATCH v4 edk2-platforms 1/1] Silicon/DesignWare/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver

["Ooi, Tzy Way" <tzy.way.ooi@intel.com>]

Thanks Biesheuvel.

I would like to confirm with you on regards of one of the comment. There is one comment where you mentioned that:
"I am aware that TX is usually the hot path in UEFI, but we should still try to map a buffer directly rather than copy the contents into uncached memory"

I would like to confirm with you if do you mean I should do the DmaMap here instead of doing it at the beginning of the code while DmaAllocate is executed?
Or do you mean I shouldn’t copy it into a uncached memory region?

Thank you
-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@linaro.org> 
Sent: Wednesday, May 22, 2019 3:22 PM
To: edk2-devel-groups-io <devel@edk2.groups.io>; Ooi, Tzy Way <tzy.way.ooi@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Loh, Tien Hock <tien.hock.loh@intel.com>; leif.lindholm@linaro.org
Subject: Re: [edk2-devel] [PATCH v4 edk2-platforms 1/1] Silicon/DesignWare/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver

On Wed, 22 May 2019 at 03:37, Ooi, Tzy Way <tzy.way.ooi@intel.com> wrote:
>
> Hi Maintainers,
>
> Please could you help to review this patch? Thanks.
>

I already did, but my email response got rejected twice

https://edk2.groups.io/g/devel/message/40829?p=,,,20,0,0,0::Created,,emac,20,2,0,31541649