Re: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/Designware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver

["Ooi, Tzy Way" <tzy.way.ooi@intel.com>]

Hi Leif,

Thank you very much. The solution provided help to resolve the issue.

Best regards,
Tzy Way

-----Original Message-----
From: Leif Lindholm <leif.lindholm@linaro.org> 
Sent: Wednesday, July 17, 2019 7:44 PM
To: Ooi, Tzy Way <tzy.way.ooi@intel.com>
Cc: devel@edk2.groups.io; Ard BieSheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com>; Loh, Tien Hock <tien.hock.loh@intel.com>
Subject: Re: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/Designware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver

Hi Tzy Way,

On Wed, Jul 17, 2019 at 09:25:49AM +0000, Ooi, Tzy Way wrote:
> Ya. I am on Linux. I managed to replicated the warning that you have 
> provided in the previous email thread by using the gcc 8.3.

Excellent.

> Currently,  I'm looking at the compiler warning/error. While I am 
> fixing the issue when compiling the source code, I encountered another 
> issue where the compiler complain "undefined reference to 
> __stack_chk_fail". I check from google and it can be solved by setting 
> -fnostack-protector. Hence, I would like to ask if is it ok to set 
> this to the CFLAGs for the compiler?

We don't need that workaround - since we have a proper way of handling it in MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf

Adding a NULL resolution to the appropriate [LibraryClasses] section in the .dsc should resolve this for you.

See (for example) edk2/EmbeddedPkg/EmbeddedPkg.dsc for guidance.

Best Regards,

Leif