From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: tzy.way.ooi@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Thu, 18 Jul 2019 23:41:06 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 23:41:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,281,1559545200"; d="scan'208";a="367167085" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by fmsmga005.fm.intel.com with ESMTP; 18 Jul 2019 23:41:04 -0700 Received: from pgsmsx109.gar.corp.intel.com ([169.254.14.91]) by PGSMSX105.gar.corp.intel.com ([169.254.4.2]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 14:41:03 +0800 From: "Ooi, Tzy Way" To: Leif Lindholm CC: "devel@edk2.groups.io" , Ard BieSheuvel , "Kinney, Michael D" , "Loh, Tien Hock" Subject: Re: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/Designware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver Thread-Topic: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/Designware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver Thread-Index: AQHVNVuKD5Rtk2wLCkeu0fDmFzVf56bFHqYAgAfmojD////4gIABkeJg//+h7QCAA1WMYA== Date: Fri, 19 Jul 2019 06:41:02 +0000 Message-ID: <5F1105621EDF844291AF8B109E27C06D34D2F2EF@PGSMSX109.gar.corp.intel.com> References: <20190708070507.2493-1-tzy.way.ooi@intel.com> <20190711164316.o7cioscn55mv6bqi@bivouac.eciton.net> <5F1105621EDF844291AF8B109E27C06D34D2E67E@PGSMSX109.gar.corp.intel.com> <20190716172227.wuczvla67izm7ccr@bivouac.eciton.net> <5F1105621EDF844291AF8B109E27C06D34D2EC31@PGSMSX109.gar.corp.intel.com> <20190717114408.GA2712@bivouac.eciton.net> In-Reply-To: <20190717114408.GA2712@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTNmY2M0YTEtOWRhMS00NWNiLWI3ODUtZGYyN2QwMjliNDUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQVl0aW15MG5wNzN2T3ZaN1wvMytMMnlqM2UzYTFXWU80UmtBS1d0ZDhOUDJrNVdCTXJnM1RaYkI2WTRBamlRQUgifQ== x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, Thank you very much. The solution provided help to resolve the issue. Best regards, Tzy Way -----Original Message----- From: Leif Lindholm =20 Sent: Wednesday, July 17, 2019 7:44 PM To: Ooi, Tzy Way Cc: devel@edk2.groups.io; Ard BieSheuvel ; Kinne= y, Michael D ; Loh, Tien Hock Subject: Re: [edk2-devel] [PATCH v6 edk2-platforms 1/1] Silicon/Synopsys/De= signware/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver Hi Tzy Way, On Wed, Jul 17, 2019 at 09:25:49AM +0000, Ooi, Tzy Way wrote: > Ya. I am on Linux. I managed to replicated the warning that you have=20 > provided in the previous email thread by using the gcc 8.3. Excellent. > Currently, I'm looking at the compiler warning/error. While I am=20 > fixing the issue when compiling the source code, I encountered another=20 > issue where the compiler complain "undefined reference to=20 > __stack_chk_fail". I check from google and it can be solved by setting=20 > -fnostack-protector. Hence, I would like to ask if is it ok to set=20 > this to the CFLAGs for the compiler? We don't need that workaround - since we have a proper way of handling it i= n MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf Adding a NULL resolution to the appropriate [LibraryClasses] section in the= .dsc should resolve this for you. See (for example) edk2/EmbeddedPkg/EmbeddedPkg.dsc for guidance. Best Regards, Leif