public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre Gondois <Pierre.Gondois@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Thomas Abraham <thomas.abraham@arm.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v6 0/3] Platform/ARM: Enable _CPC/_PSD generation on Juno-r2
Date: Tue, 30 Jan 2024 14:30:34 +0000	[thread overview]
Message-ID: <5FDE0607-04F1-4E2D-9A74-EC7B1D3632C6@arm.com> (raw)
In-Reply-To: <20240129120825.139755-1-Pierre.Gondois@arm.com>

Merged as 14b8c793e685..d9070fb98d5d

Thanks.

Regards,

Sami Mujawar

On 29/01/2024, 12:08, "Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com>" <Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com>> wrote:


From: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>


v1:
- https://edk2.groups.io/g/devel/message/104127 <https://edk2.groups.io/g/devel/message/104127>
v2:
- https://edk2.groups.io/g/devel/message/110048 <https://edk2.groups.io/g/devel/message/110048>
- Rebase patches on latest version.
- Correct frequency values which were advertised in KHz
when CPPC spec require them to be in MHz.
v3:
- https://edk2.groups.io/g/devel/message/111579 <https://edk2.groups.io/g/devel/message/111579>
- Rebase on latest master
- Use ACPI 6.5 definitions instead of 6.4 previously
- Renamed ArmScmiInfoLib to DynamicTablesScmiInfoLib
v4:
- https://edk2.groups.io/g/devel/message/112378 <https://edk2.groups.io/g/devel/message/112378>
- Removed Change-id left in commit messages.
v5:
[PATCH v4 3/3] Platform/ARM: Juno: Generate _CPC objects for JunoR2
- Removed unnecessary _CPC initialization
- Moved PopulateCpcInfo() to InitializePlatformRepository()
- Moved Juno revision check to InitializePlatformRepository()
Added new patch
- 'Platform/ARM: Juno: Use PcdDevelopmentPlatformRelaxations for _CPC'
v6:
-Merged patches into one patch:
- 'Platform/ARM: Juno: Use PcdDevelopmentPlatformRelaxations for _CPC'
- 'Platform/ARM: Juno: Generate _CPC objects for JunoR2'
- Return correct error code in GetCpcInfo()/GetpsdInfo()
- Make PopulateCpcObjects() use an input parameter: PlatformRepo
- Add ENABLE_CPC build parameter to enable CPC generation via command
line.




A recent patchset [1] allows the generation of _PSD/_CPC ACPI objects by
querying the relevant information through the SCMI protocol.
- The _PSD object describes to which performance domain a CPU belongs.
CPUs in the same performance domain have the same frequency.
- The _CPC object describes an interface to control the performance level
of a CPU (i.e. its frequency).


Demonstrate the _PSD/_CPC generation functionality on Juno-r2 platforms.


In order to work, the SCP must describe performance levels on a unified
scale (i.e. not as frequencies). The following performance level values
where used for testing:
- little CPUs OPPs: [181, 322, 383] * 1000
- big CPUs OPPs: [512, 833, 1024] * 1024


The SCP should also:
- have fast channel enabled
- set the `approximate_level` feature to allow performance level requests
in between OPP leveles.


[1] https://edk2.groups.io/g/devel/message/114410 <https://edk2.groups.io/g/devel/message/114410>


Pierre Gondois (3):
Platform/ARM: Juno: Fix typo
Platform/ARM: Juno: Generate _PSD objects
Platform/ARM: Juno: Generate _CPC objects for JunoR2


Platform/ARM/JunoPkg/ArmJuno.dsc | 11 +
.../ConfigurationManager.c | 352 +++++++++++++++++-
.../ConfigurationManager.h | 31 +-
.../ConfigurationManagerDxe.inf | 3 +
4 files changed, 384 insertions(+), 13 deletions(-)


-- 
2.25.1







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114788): https://edk2.groups.io/g/devel/message/114788
Mute This Topic: https://groups.io/mt/104029700/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2024-01-30 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 12:08 [edk2-devel] [PATCH v6 0/3] Platform/ARM: Enable _CPC/_PSD generation on Juno-r2 PierreGondois
2024-01-29 12:08 ` [edk2-devel] [PATCH v6 1/3] Platform/ARM: Juno: Fix typo PierreGondois
2024-01-29 12:08 ` [edk2-devel] [PATCH v6 2/3] Platform/ARM: Juno: Generate _PSD objects PierreGondois
2024-01-29 12:08 ` [edk2-devel] [PATCH v6 3/3] Platform/ARM: Juno: Generate _CPC objects for JunoR2 PierreGondois
2024-01-29 14:54   ` Sami Mujawar
2024-01-30 14:30 ` Sami Mujawar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5FDE0607-04F1-4E2D-9A74-EC7B1D3632C6@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox