Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg

["Laszlo Ersek" <lersek@redhat.com>]

Abner,

On 10/07/20 04:15, Abner Chang wrote:
> Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to
>              save time on CI test.
>              In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue
>              this change is not required in v4 pacth set.

you really need to collect the CC's from *all* the commit messages
across the entire series, and manually add those to your cover letter.

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23

"This will ensure that even if a maintainer is involved in reviewing one
or two of your patches across the series, he or she will get a copy of
your cover letter, which outlines the full feature or bugfix"

No need to repost this, but please remember it in the future.

Thanks
Laszlo

> 
> Note for v5: Add reviewers's tags.
> 
> Note for v4: NOOPT is removed from RedfishPkg.dsc and
>              pr-gate-build-job.yml because we don't have host-based
>              unit test on Redfish yet. We keep NO-TARGET for the
>              non build CI test on RedfishPkg.
> 
> Initial version of RedfishPkg and the CI test
> on RedfishPkg.
> 
> CI Test result:
> https://github.com/tianocore/edk2/pull/986
> 
> There is no components in RedfishPkg in this commit,
> the further edk2 Redfish components will be committed
> base on this version.
> 
> Abner Chang (4):
>   RedfishPkg: Initial commit of RedfishPkg.
>   .pytool: Add CI on RedfishPkg
>   .azurepipelines/templates: Add RedfishPkg to target build
>   edk2: Add maintainers to RedfishPkg
> 
>  .../templates/pr-gate-build-job.yml           |  2 +-
>  .pytool/CISettings.py                         |  3 +-
>  Maintainers.txt                               |  5 ++
>  RedfishPkg/RedfishPkg.ci.yaml                 | 67 +++++++++++++++++++
>  RedfishPkg/RedfishPkg.dec                     | 18 +++++
>  RedfishPkg/RedfishPkg.dsc                     | 40 +++++++++++
>  6 files changed, 133 insertions(+), 2 deletions(-)
>  create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
>  create mode 100644 RedfishPkg/RedfishPkg.dec
>  create mode 100644 RedfishPkg/RedfishPkg.dsc
>