From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.10375.1602067773208303683 for ; Wed, 07 Oct 2020 03:49:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZqdVfV8T; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602067772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QqRAU+d7SknXDaFJrHLhduYZZmHHh/uE1tMOebrks7s=; b=ZqdVfV8TBGJMG3io2k40H7ab8ZXpml+IwPhDXIT8eNd0FUTbH8SXzbERWAuKHnLznQND1X jqw0QuG+iEvKDh5AxhgvxXiRX5DGjSb1mmfL8t0+drAkSdFMSxcSxgHlVEFZbIQ3Q7Q1Av PrdeferGDHKxDrbQECFMhyFYUkRxNfE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-edGeFmJAOsOWaIzLGuSeZA-1; Wed, 07 Oct 2020 06:49:29 -0400 X-MC-Unique: edGeFmJAOsOWaIzLGuSeZA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 60A471074640; Wed, 7 Oct 2020 10:49:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-94.ams2.redhat.com [10.36.113.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB1971000320; Wed, 7 Oct 2020 10:49:27 +0000 (UTC) Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg To: devel@edk2.groups.io, abner.chang@hpe.com References: <20201007021545.25936-1-abner.chang@hpe.com> From: "Laszlo Ersek" Message-ID: <5a054523-061b-dea6-54ac-5ce0aaaf8932@redhat.com> Date: Wed, 7 Oct 2020 12:49:26 +0200 MIME-Version: 1.0 In-Reply-To: <20201007021545.25936-1-abner.chang@hpe.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Abner, On 10/07/20 04:15, Abner Chang wrote: > Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to > save time on CI test. > In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue > this change is not required in v4 pacth set. you really need to collect the CC's from *all* the commit messages across the entire series, and manually add those to your cover letter. https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 "This will ensure that even if a maintainer is involved in reviewing one or two of your patches across the series, he or she will get a copy of your cover letter, which outlines the full feature or bugfix" No need to repost this, but please remember it in the future. Thanks Laszlo > > Note for v5: Add reviewers's tags. > > Note for v4: NOOPT is removed from RedfishPkg.dsc and > pr-gate-build-job.yml because we don't have host-based > unit test on Redfish yet. We keep NO-TARGET for the > non build CI test on RedfishPkg. > > Initial version of RedfishPkg and the CI test > on RedfishPkg. > > CI Test result: > https://github.com/tianocore/edk2/pull/986 > > There is no components in RedfishPkg in this commit, > the further edk2 Redfish components will be committed > base on this version. > > Abner Chang (4): > RedfishPkg: Initial commit of RedfishPkg. > .pytool: Add CI on RedfishPkg > .azurepipelines/templates: Add RedfishPkg to target build > edk2: Add maintainers to RedfishPkg > > .../templates/pr-gate-build-job.yml | 2 +- > .pytool/CISettings.py | 3 +- > Maintainers.txt | 5 ++ > RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++ > RedfishPkg/RedfishPkg.dec | 18 +++++ > RedfishPkg/RedfishPkg.dsc | 40 +++++++++++ > 6 files changed, 133 insertions(+), 2 deletions(-) > create mode 100644 RedfishPkg/RedfishPkg.ci.yaml > create mode 100644 RedfishPkg/RedfishPkg.dec > create mode 100644 RedfishPkg/RedfishPkg.dsc >