From: "Tinh Nguyen" <tinhnguyen@os.amperecomputing.com>
To: abner.chang@amd.com, devel@edk2.groups.io
Cc: Isaac Oram <isaac.w.oram@intel.com>,
Abdul Lateef Attar <abdattar@amd.com>,
Nickle Wang <nicklew@nvidia.com>
Subject: Re: [edk2-platforms][PATCH 3/3] ManageabilityPkg: Support AARCH64
Date: Mon, 17 Apr 2023 17:43:55 +0700 [thread overview]
Message-ID: <5a32accb-8c00-cac3-e575-9b6aefc56013@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20230415115727.805-3-abner.chang@amd.com>
Reviewed-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
On 15/04/2023 18:57, abner.chang@amd.com wrote:
> [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.]
>
>
> From: Abner Chang <abner.chang@amd.com>
>
> Add AARCH64 support in Manageability.dsc
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
> ---
> .../ManageabilityPkg/Include/Dsc/Manageability.dsc | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> index 0d868fdf4a..7f8d8df3f0 100644
> --- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> @@ -15,11 +15,18 @@
> NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
>
> -[Components.IA32]
> +[LibraryClasses.AARCH64.PEIM]
> + PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
> +
> +[Components.IA32, Components.AARCH64]
> ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
>
> -[Components.X64]
> +[Components.X64, Components.AARCH64]
> ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf
> +
> +[Components.X64]
> ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf
>
> --
> 2.37.1.windows.1
>
next prev parent reply other threads:[~2023-04-17 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 11:57 [edk2-platforms][PATCH 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance Chang, Abner
2023-04-15 11:57 ` [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Chang, Abner
2023-04-17 4:50 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-17 5:22 ` Chang, Abner
2023-04-15 11:57 ` [edk2-platforms][PATCH 3/3] ManageabilityPkg: Support AARCH64 Chang, Abner
2023-04-17 4:51 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-17 10:43 ` Tinh Nguyen [this message]
2023-04-17 4:41 ` [edk2-platforms][PATCH 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance Attar, AbdulLateef (Abdul Lateef)
2023-04-17 10:40 ` Tinh Nguyen
2023-04-17 12:56 ` Chang, Abner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a32accb-8c00-cac3-e575-9b6aefc56013@amperemail.onmicrosoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox