From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Eric Dong <eric.dong@intel.com>,
Jaben Carsey <jaben.carsey@intel.com>,
Star Zeng <star.zeng@intel.com>
Subject: Re: [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency
Date: Tue, 13 Feb 2018 10:50:07 +0800 [thread overview]
Message-ID: <5a64e188-74aa-648f-dd29-c14dd1324064@Intel.com> (raw)
In-Reply-To: <20180212134513.6882-4-lersek@redhat.com>
On 2/12/2018 9:45 PM, Laszlo Ersek wrote:
> In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the
> useless perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData()
> function was removed. No TimerLib API calls are left, thus remove the
> TimerLib class dependency from "InternalBm.h" and "UefiBootManagerLib.inf"
> as well.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 -
> MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index 1adffd70d06a..8d5b89ea2970 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -52,7 +52,6 @@ [LibraryClasses]
> PcdLib
> BaseLib
> UefiLib
> - TimerLib
> DebugLib
> PrintLib
> BaseMemoryLib
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
> index ed0cd16ef322..25a1d522fe84 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
> @@ -68,7 +68,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> #include <Library/PcdLib.h>
> #include <Library/PeCoffGetEntryPointLib.h>
> #include <Library/UefiBootManagerLib.h>
> -#include <Library/TimerLib.h>
> #include <Library/DxeServicesLib.h>
> #include <Library/ReportStatusCodeLib.h>
> #include <Library/CapsuleLib.h>
>
Thanks!
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
next prev parent reply other threads:[~2018-02-13 2:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 13:45 [PATCH 0/4] minuscule cleanups for Shell library resolutions Laszlo Ersek
2018-02-12 13:45 ` [PATCH 1/4] OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions Laszlo Ersek
2018-02-12 14:25 ` Ard Biesheuvel
2018-02-12 13:45 ` [PATCH 2/4] EmulatorPkg: " Laszlo Ersek
2018-02-12 13:45 ` [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency Laszlo Ersek
2018-02-13 0:51 ` Zeng, Star
2018-02-13 2:50 ` Ni, Ruiyu [this message]
2018-02-12 13:45 ` [PATCH 4/4] ShellPkg: remove superfluous TimerLib resolution Laszlo Ersek
2018-02-13 2:50 ` Ni, Ruiyu
2018-02-12 15:25 ` [PATCH 0/4] minuscule cleanups for Shell library resolutions Carsey, Jaben
2018-02-13 12:32 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a64e188-74aa-648f-dd29-c14dd1324064@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox