From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C3F6021CF1CF7 for ; Mon, 12 Feb 2018 18:44:18 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2018 18:50:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,505,1511856000"; d="scan'208";a="17258788" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.37]) ([10.239.9.37]) by fmsmga007.fm.intel.com with ESMTP; 12 Feb 2018 18:50:07 -0800 To: Laszlo Ersek , edk2-devel-01 Cc: Eric Dong , Jaben Carsey , Star Zeng References: <20180212134513.6882-1-lersek@redhat.com> <20180212134513.6882-4-lersek@redhat.com> From: "Ni, Ruiyu" Message-ID: <5a64e188-74aa-648f-dd29-c14dd1324064@Intel.com> Date: Tue, 13 Feb 2018 10:50:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180212134513.6882-4-lersek@redhat.com> Subject: Re: [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 02:44:19 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/12/2018 9:45 PM, Laszlo Ersek wrote: > In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the > useless perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData() > function was removed. No TimerLib API calls are left, thus remove the > TimerLib class dependency from "InternalBm.h" and "UefiBootManagerLib.inf" > as well. > > Cc: Eric Dong > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 - > MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > index 1adffd70d06a..8d5b89ea2970 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > @@ -52,7 +52,6 @@ [LibraryClasses] > PcdLib > BaseLib > UefiLib > - TimerLib > DebugLib > PrintLib > BaseMemoryLib > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h > index ed0cd16ef322..25a1d522fe84 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h > +++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h > @@ -68,7 +68,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > #include > #include > #include > -#include > #include > #include > #include > Thanks! Reviewed-by: Ruiyu Ni -- Thanks, Ray