Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Sinha, Ankit]

Reviewed-by: Ankit Sinha <ankit.sinha@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Monday, April 11, 2022 1:58 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add
> FADT duty offset and width PCDs
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
> 
> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values in
> their build files.
> 
> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep the
> change in sync with the source MinPlatformPkg module.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (3):
>   MinPlatformPkg: Add FADT duty offset and duty width PCDs
>   MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>   SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
> 
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> |  3 +++
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |
> 4 ++--
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Acp
> iPlatform.c   |  3 +++
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fad
> t/Fadt.c      |  4 ++--
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> |  2 ++
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15
> +++++++++++++++
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Acp
> iPlatform.inf |  2 ++
>  7 files changed, 29 insertions(+), 4 deletions(-)
> 
> --
> 2.28.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#88721): https://edk2.groups.io/g/devel/message/88721
> Mute This Topic: https://groups.io/mt/90405218/1772825
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ankit.sinha@intel.com]
> -=-=-=-=-=-=
> 

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Reminder to review this series.

Ankit Sinha has reviewed it but need a maintainer to review and merge.

On 4/11/2022 4:58 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
> 
> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
> values in their build files.
> 
> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
> keep the change in sync with the source MinPlatformPkg module.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (3):
>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
> 
>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        |  3 +++
>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |  4 ++--
>   Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   |  3 +++
>   Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      |  4 ++--
>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      |  2 ++
>   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15 +++++++++++++++
>   Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf |  2 ++
>   7 files changed, 29 insertions(+), 4 deletions(-)
> 

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Another reminder to merge this series. Chasel has added his review and 
that is in this branch:

https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1

Thanks,
Michael

On 4/22/2022 10:04 AM, Michael Kubacki wrote:
> Reminder to review this series.
> 
> Ankit Sinha has reviewed it but need a maintainer to review and merge.
> 
> On 4/11/2022 4:58 PM, Michael Kubacki wrote:
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>
>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
>> values in their build files.
>>
>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
>> keep the change in sync with the source MinPlatformPkg module.
>>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Michael Kubacki (3):
>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>
>>   
>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        
>> |  3 +++
>>   
>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           
>> |  4 ++--
>>   
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   
>> |  3 +++
>>   
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      
>> |  4 ++--
>>   
>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      
>> |  2 ++
>>   
>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    
>> | 15 +++++++++++++++
>>   
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf 
>> |  2 ++
>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Another reminder to look at this patch.

Thanks,
Michael


On 4/29/2022 4:07 PM, Michael Kubacki wrote:
> Another reminder to merge this series. Chasel has added his review and 
> that is in this branch:
> 
> https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 
> 
> 
> Thanks,
> Michael
> 
> On 4/22/2022 10:04 AM, Michael Kubacki wrote:
>> Reminder to review this series.
>>
>> Ankit Sinha has reviewed it but need a maintainer to review and merge.
>>
>> On 4/11/2022 4:58 PM, Michael Kubacki wrote:
>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>>
>>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
>>> values in their build files.
>>>
>>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
>>> keep the change in sync with the source MinPlatformPkg module.
>>>
>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Eric Dong <eric.dong@intel.com>
>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> Michael Kubacki (3):
>>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>
>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c |  3 +++
>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c |  4 ++--
>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c 
>>> |  3 +++
>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c 
>>> |  4 ++--
>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf |  2 ++
>>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++++
>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf 
>>> |  2 ++
>>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>>

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Reminder

On 5/10/2022 1:34 PM, Michael Kubacki wrote:
> Another reminder to look at this patch.
> 
> Thanks,
> Michael
> 
> 
> On 4/29/2022 4:07 PM, Michael Kubacki wrote:
>> Another reminder to merge this series. Chasel has added his review and 
>> that is in this branch:
>>
>> https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 
>>
>>
>> Thanks,
>> Michael
>>
>> On 4/22/2022 10:04 AM, Michael Kubacki wrote:
>>> Reminder to review this series.
>>>
>>> Ankit Sinha has reviewed it but need a maintainer to review and merge.
>>>
>>> On 4/11/2022 4:58 PM, Michael Kubacki wrote:
>>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>
>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>>>
>>>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>>>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
>>>> values in their build files.
>>>>
>>>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
>>>> keep the change in sync with the source MinPlatformPkg module.
>>>>
>>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>>> Cc: Eric Dong <eric.dong@intel.com>
>>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>
>>>> Michael Kubacki (3):
>>>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>>
>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c |  3 +++
>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c |  4 ++--
>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c 
>>>> |  3 +++
>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c 
>>>> |  4 ++--
>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf |  2 ++
>>>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++++
>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf 
>>>> |  2 ++
>>>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>>>

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Can someone seriously respond?

This was approved over 3 weeks ago and sent 5 weeks ago. I know Ankit 
now has a similar change out but I'd like to see if this can get in and 
that be rebased on it since this has been out for so long and has the 
primary change needed for our integration.

Thanks,
Michael

On 5/13/2022 1:42 PM, Michael Kubacki wrote:
> Reminder
> 
> On 5/10/2022 1:34 PM, Michael Kubacki wrote:
>> Another reminder to look at this patch.
>>
>> Thanks,
>> Michael
>>
>>
>> On 4/29/2022 4:07 PM, Michael Kubacki wrote:
>>> Another reminder to merge this series. Chasel has added his review 
>>> and that is in this branch:
>>>
>>> https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 
>>>
>>>
>>> Thanks,
>>> Michael
>>>
>>> On 4/22/2022 10:04 AM, Michael Kubacki wrote:
>>>> Reminder to review this series.
>>>>
>>>> Ankit Sinha has reviewed it but need a maintainer to review and merge.
>>>>
>>>> On 4/11/2022 4:58 PM, Michael Kubacki wrote:
>>>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>>
>>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>>>>
>>>>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>>>>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
>>>>> values in their build files.
>>>>>
>>>>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
>>>>> keep the change in sync with the source MinPlatformPkg module.
>>>>>
>>>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>>>> Cc: Eric Dong <eric.dong@intel.com>
>>>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>>
>>>>> Michael Kubacki (3):
>>>>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>>>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width 
>>>>> PCDs
>>>>>
>>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c |  3 +++
>>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c |  4 ++--
>>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c 
>>>>> |  3 +++
>>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c 
>>>>> |  4 ++--
>>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf |  2 ++
>>>>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++++
>>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf 
>>>>> |  2 ++
>>>>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>>>>