public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Qin Long <qin.long@intel.com>, edk2-devel@lists.01.org
Cc: ard.biesheuvel@linaro.org, ting.ye@intel.com,
	David Woodhouse <dwmw2@infradead.org>,
	ronald.cron@arm.com, jiaxin.wu@intel.com, glin@suse.com
Subject: Re: [PATCH v1 2/9] CryptoPkg/OpensslLib: Remove patch file and installation scripts.
Date: Wed, 22 Mar 2017 13:05:52 +0100	[thread overview]
Message-ID: <5a8cc73f-8cdf-1c2f-3269-1c07cb81dbce@redhat.com> (raw)
In-Reply-To: <20170321155612.1192-3-qin.long@intel.com>

On 03/21/17 16:56, Qin Long wrote:
> This patch removes the EDKII-openssl-xxxx.patch, installation scripts
> and old opensslconf.h.
> And old Patch-HOWTO.txt was replaced by OpenSSL-HOWTO.txt to state
> how to download the latest OpenSSL sources for build.
> 
> Cc: Ting Ye <ting.ye@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Gary Lin <glin@suse.com>
> Cc: Ronald Cron <ronald.cron@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Qin Long <qin.long@intel.com>
> ---
>  .../Library/OpensslLib/EDKII_openssl-1.0.2k.patch  | 2094 --------------------
>  CryptoPkg/Library/OpensslLib/Install.cmd           |   80 -
>  CryptoPkg/Library/OpensslLib/Install.sh            |   82 -
>  CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt     |   36 +
>  CryptoPkg/Library/OpensslLib/Patch-HOWTO.txt       |   61 -
>  CryptoPkg/Library/OpensslLib/buildinf.h            |    2 +-
>  CryptoPkg/Library/OpensslLib/opensslconf.h         |  497 -----
>  7 files changed, 37 insertions(+), 2815 deletions(-)
>  delete mode 100644 CryptoPkg/Library/OpensslLib/EDKII_openssl-1.0.2k.patch
>  delete mode 100755 CryptoPkg/Library/OpensslLib/Install.cmd
>  delete mode 100755 CryptoPkg/Library/OpensslLib/Install.sh
>  create mode 100644 CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
>  delete mode 100644 CryptoPkg/Library/OpensslLib/Patch-HOWTO.txt
>  delete mode 100644 CryptoPkg/Library/OpensslLib/opensslconf.h
> 

snip

> diff --git a/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
> new file mode 100644
> index 0000000000..c6f7ace9b2
> --- /dev/null
> +++ b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
> @@ -0,0 +1,36 @@
> +
> +================================================================================
> +                                 Introduction
> +================================================================================
> +  OpenSSL is a well-known open source implementation of SSL and TLS protocols.
> +The core library implements the basic cryptographic functions and provides various
> +utility functions. The OpenSSL library is widely used in variety of security
> +products development as base crypto provider. (See http://www.openssl.org/ for more
> +information on OpenSSL).
> +  UEFI (Unified Extensible Firmware Interface) is a specification detailing the
> +interfaces between OS and platform firmware. Several security features were
> +introduced (e.g. Authenticated Variable Service, Driver Signing, etc) from UEFI
> +2.2 (http://www.uefi.org/). These security features highly depend on the
> +cryptography. This HOWTO documents OpenSSL building under UEFI environment.
> +
> +
> +================================================================================
> +                                OpenSSL-Version
> +================================================================================
> +  EDKII supports building with the master branch of OpenSSL. The latest stable
> +  version is the 1.1.0e release.
> +  NOTE: Only latest stable version was validated. No guarantee on OpenSSL HEAD.
> +
> +================================================================================
> +                      HOW to Install OpenSSL for UEFI Building
> +================================================================================
> +1. Clone the latest stable OpenSSL branch into the directory
> +       CryptoPkg/Library/OpensslLib/openssl/
> +   For example:
> +       > cd CryptoPkg/Library/OpensslLib
> +       > git clone -b OpenSSL_1_1_0e https://github.com/openssl/openssl openssl
> +Or
> +2. Download the lastest stable OpenSSL release from the official website:
> +       https://www.openssl.org/source/
> +   and unpack the OpenSSL source into:
> +       CryptoPkg/Library/OpensslLib/openssl/

Can you please rewrap this file so that no line is longer than 79
characters?

Thanks
Laszlo



  reply	other threads:[~2017-03-22 12:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 15:56 [PATCH v1 0/9] *** Upgrade CryptoPkg to use the latest OpenSSL 1.1.0xx/stable release *** Qin Long
2017-03-21 15:56 ` [PATCH v1 1/9] CryptoPkg/OpensslLib: Update INF files to support OpenSSL-1.1.0xx build Qin Long
2017-03-22 12:02   ` Laszlo Ersek
2017-03-22 12:18   ` Laszlo Ersek
2017-03-21 15:56 ` [PATCH v1 2/9] CryptoPkg/OpensslLib: Remove patch file and installation scripts Qin Long
2017-03-22 12:05   ` Laszlo Ersek [this message]
2017-03-21 15:56 ` [PATCH v1 3/9] CryptoPkg: Fix handling of &strcmp function pointers Qin Long
2017-03-22 10:11   ` Gary Lin
2017-03-23  2:16     ` Long, Qin
2017-03-23  3:39       ` Long, Qin
2017-03-21 15:56 ` [PATCH v1 4/9] CryptoPkg/OpensslLib: Use new Perl script for file list generation Qin Long
2017-03-21 15:56 ` [PATCH v1 5/9] CryptoPkg: Clean-up CRT Library Wrapper Qin Long
2017-03-21 15:56 ` [PATCH v1 6/9] CryptoPkg: Add extra build option to disable VS build warning Qin Long
2017-03-21 15:56 ` [PATCH v1 7/9] CryptoPkg: Update HMAC Wrapper implementation with opaque HMAC_CTX object Qin Long
2017-03-21 15:56 ` [PATCH v1 8/9] CryptoPkg: Update PK Ciphers Wrapper Implementations work with opaque objects Qin Long
2017-03-21 15:56 ` [PATCH v1 9/9] CryptoPkg/TlsLib: Update TLS Wrapper Library to align with OpenSSL changes Qin Long
2017-03-21 17:42   ` Palmer, Thomas
2017-03-22  1:32     ` Long, Qin
2017-03-23  1:20       ` Wu, Jiaxin
2017-03-23 16:23         ` Palmer, Thomas
2017-03-22  2:22 ` [PATCH v1 0/9] *** Upgrade CryptoPkg to use the latest OpenSSL 1.1.0xx/stable release *** Gao, Liming
2017-03-22  2:44   ` Long, Qin
2017-03-22 13:02 ` Laszlo Ersek
2017-03-22 16:20   ` Long, Qin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a8cc73f-8cdf-1c2f-3269-1c07cb81dbce@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox