From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2E89C802A0 for ; Wed, 22 Mar 2017 05:05:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8A3EF8050A; Wed, 22 Mar 2017 12:05:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8A3EF8050A Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8A3EF8050A Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-105.phx2.redhat.com [10.3.116.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6747117974; Wed, 22 Mar 2017 12:05:54 +0000 (UTC) To: Qin Long , edk2-devel@lists.01.org References: <20170321155612.1192-1-qin.long@intel.com> <20170321155612.1192-3-qin.long@intel.com> Cc: ard.biesheuvel@linaro.org, ting.ye@intel.com, David Woodhouse , ronald.cron@arm.com, jiaxin.wu@intel.com, glin@suse.com From: Laszlo Ersek Message-ID: <5a8cc73f-8cdf-1c2f-3269-1c07cb81dbce@redhat.com> Date: Wed, 22 Mar 2017 13:05:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170321155612.1192-3-qin.long@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 22 Mar 2017 12:05:56 +0000 (UTC) Subject: Re: [PATCH v1 2/9] CryptoPkg/OpensslLib: Remove patch file and installation scripts. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 12:05:56 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/21/17 16:56, Qin Long wrote: > This patch removes the EDKII-openssl-xxxx.patch, installation scripts > and old opensslconf.h. > And old Patch-HOWTO.txt was replaced by OpenSSL-HOWTO.txt to state > how to download the latest OpenSSL sources for build. > > Cc: Ting Ye > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Gary Lin > Cc: Ronald Cron > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: David Woodhouse > Signed-off-by: Qin Long > --- > .../Library/OpensslLib/EDKII_openssl-1.0.2k.patch | 2094 -------------------- > CryptoPkg/Library/OpensslLib/Install.cmd | 80 - > CryptoPkg/Library/OpensslLib/Install.sh | 82 - > CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt | 36 + > CryptoPkg/Library/OpensslLib/Patch-HOWTO.txt | 61 - > CryptoPkg/Library/OpensslLib/buildinf.h | 2 +- > CryptoPkg/Library/OpensslLib/opensslconf.h | 497 ----- > 7 files changed, 37 insertions(+), 2815 deletions(-) > delete mode 100644 CryptoPkg/Library/OpensslLib/EDKII_openssl-1.0.2k.patch > delete mode 100755 CryptoPkg/Library/OpensslLib/Install.cmd > delete mode 100755 CryptoPkg/Library/OpensslLib/Install.sh > create mode 100644 CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt > delete mode 100644 CryptoPkg/Library/OpensslLib/Patch-HOWTO.txt > delete mode 100644 CryptoPkg/Library/OpensslLib/opensslconf.h > snip > diff --git a/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt > new file mode 100644 > index 0000000000..c6f7ace9b2 > --- /dev/null > +++ b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt > @@ -0,0 +1,36 @@ > + > +================================================================================ > + Introduction > +================================================================================ > + OpenSSL is a well-known open source implementation of SSL and TLS protocols. > +The core library implements the basic cryptographic functions and provides various > +utility functions. The OpenSSL library is widely used in variety of security > +products development as base crypto provider. (See http://www.openssl.org/ for more > +information on OpenSSL). > + UEFI (Unified Extensible Firmware Interface) is a specification detailing the > +interfaces between OS and platform firmware. Several security features were > +introduced (e.g. Authenticated Variable Service, Driver Signing, etc) from UEFI > +2.2 (http://www.uefi.org/). These security features highly depend on the > +cryptography. This HOWTO documents OpenSSL building under UEFI environment. > + > + > +================================================================================ > + OpenSSL-Version > +================================================================================ > + EDKII supports building with the master branch of OpenSSL. The latest stable > + version is the 1.1.0e release. > + NOTE: Only latest stable version was validated. No guarantee on OpenSSL HEAD. > + > +================================================================================ > + HOW to Install OpenSSL for UEFI Building > +================================================================================ > +1. Clone the latest stable OpenSSL branch into the directory > + CryptoPkg/Library/OpensslLib/openssl/ > + For example: > + > cd CryptoPkg/Library/OpensslLib > + > git clone -b OpenSSL_1_1_0e https://github.com/openssl/openssl openssl > +Or > +2. Download the lastest stable OpenSSL release from the official website: > + https://www.openssl.org/source/ > + and unpack the OpenSSL source into: > + CryptoPkg/Library/OpensslLib/openssl/ Can you please rewrap this file so that no line is longer than 79 characters? Thanks Laszlo