From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.83]) by mx.groups.io with SMTP id smtpd.web11.1106.1639588018624141802 for ; Wed, 15 Dec 2021 09:06:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=cQB0VFWQ; spf=pass (domain: arm.com, ip: 40.107.22.83, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5PfUHcHpVTGp869O9EC9QMbbCODfYVdR01V82YvYr80=; b=cQB0VFWQgdhLGshyQoU4ubYVCe92DbSvfptM8q7l+n+0Vii5U9B6WbzQGG96Qb12B7SxyUDSUxh1S3I+8eFXAB+cLYiiTk7lkJk1683aoZTfRMs298G0aIkwnFxqdVvFuOQQKb34FpqgASlup0tYD44dbk+h5jxCyozdKRV4XCY= Received: from AM6PR10CA0104.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::45) by DB9PR08MB7131.eurprd08.prod.outlook.com (2603:10a6:10:2c9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Wed, 15 Dec 2021 17:06:54 +0000 Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::56) by AM6PR10CA0104.outlook.office365.com (2603:10a6:209:8c::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14 via Frontend Transport; Wed, 15 Dec 2021 17:06:54 +0000 X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Wed, 15 Dec 2021 17:06:52 +0000 Received: ("Tessian outbound dbb52aec1fa6:v110"); Wed, 15 Dec 2021 17:06:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1c7e0529f002ae3f X-CR-MTA-TID: 64aa7808 Received: from 1a328b3990ac.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 982E08BD-A982-40A6-ABE7-4FE911436427.1; Wed, 15 Dec 2021 17:06:35 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1a328b3990ac.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 15 Dec 2021 17:06:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XZbbHeDHb3ltKwkpQgiUjsTVclOZp4Wgq+m3gXeAyfV69B0yiHhb4tnbfiz3rR+eoyM5XmZ++iQ1xLD5zzXIMPhUPeVWeN/qOm+iSSDBYZ1mwqe2JXvjk2z/Z5xYBPVT3qDx7/yA00kk0ZdpBql2iE6/Z8+w4/Txm14GDyLqPbgLyBxOIliXoLxwpku7z3mNqXbt9Mfv0Np0h+jlprs1eXckC6tzxI92lqyeXtsj9GND0NvloTmgWhITtUzYlFs5gFE+45S9Qv9gqKPJyR2sS/UKUT1gI23Hs9LAW2I4/dLkGfZrjd2VaYQ9wF5UhbXTEvICe1bb1mdqZbVn0SHy8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5PfUHcHpVTGp869O9EC9QMbbCODfYVdR01V82YvYr80=; b=UHijnx9FntcCXvJx0nQMZhXtuNA5tKMY3zB5SJCVfxKtqk9updQ6DSqJRtCHwT8Swk+j60s9vyk6dm4Inai/8c9ghKJ0UQhXCmfnXB5BSIYLK6ys/qHHeXd1VEQ7aDD1DGTFaVevSOuk9U3PwdgfKCOyXrUNVp2jbdPUbYMFgPWbqSfjBF+anHbnF7bmyXLy9F2aaGS/uzCJH6tmyLJGEc+Zd1BxTmGz7S9bJO2KGP3gAaqVeXsOLu/oJBxwPR9GDuqQ3BX5m76rFlYY/bbJD+pU4A0N36va+4DYwagU8EukpY/R8s/TcjbY0d45Z64spKno/rC8snB6AjUNjlxRhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5PfUHcHpVTGp869O9EC9QMbbCODfYVdR01V82YvYr80=; b=cQB0VFWQgdhLGshyQoU4ubYVCe92DbSvfptM8q7l+n+0Vii5U9B6WbzQGG96Qb12B7SxyUDSUxh1S3I+8eFXAB+cLYiiTk7lkJk1683aoZTfRMs298G0aIkwnFxqdVvFuOQQKb34FpqgASlup0tYD44dbk+h5jxCyozdKRV4XCY= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3621.eurprd08.prod.outlook.com (2603:10a6:20b:4b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Wed, 15 Dec 2021 17:06:33 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Wed, 15 Dec 2021 17:06:33 +0000 Subject: Re: [edk2-devel] [PATCH 0/3] ArmPkg/SMBIOS: Update HII string settings for SMBIOS To: devel@edk2.groups.io, nhi@os.amperecomputing.com Cc: patches@amperecomputing.com, Leif Lindholm , Ard Biesheuvel , Rebecca Cran , nd References: <20211201041031.31824-1-nhi@os.amperecomputing.com> From: "Sami Mujawar" Message-ID: <5a8dddbb-d327-1ae7-e269-63fc5649c124@arm.com> Date: Wed, 15 Dec 2021 17:06:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211201041031.31824-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: LO2P265CA0167.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::35) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO2P265CA0167.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::35) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Wed, 15 Dec 2021 17:06:33 +0000 X-MS-Office365-Filtering-Correlation-Id: 704a83a1-d6ef-42fb-53d2-08d9bfed4a2f X-MS-TrafficTypeDiagnostic: AM6PR08MB3621:EE_|AM5EUR03FT027:EE_|DB9PR08MB7131:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:792;OLM:792; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0vAVxhTqGN6JcGWU0rOPhGh00wJHh4ZZcuygYdz6W77qiYpznaSIMXYv5hDfmU3/JzKoFANmusYHQw1se8alWOcBeu+nORJEkq3L0i5Q8dML8s4gaFBBTdvywa03vt4KjSxxrRm3aiTNT+j9PmnvKSA3WO7Hp3esRvWqppxXR/mGM53Eskna31TMdV9b0xVfueOgu6WuQxenE9oiO2fXSV1nBOQk0eOME/6HY4E9l0Re0BoUaUnFP7SWeMz8P66ffIPtGj5madygAZpU2Y23OwAwv/4cmmKWvA2XzI0EX4Rfm28Ltnq/bitcm/rt0EZpOCt+j5oUsUvDhwc9HinibzmSldaXHXAG6Z2rHz40URwYY4j4+tcNUfkUmBBo3UGEZ6C/YXKvDVU0hSSfs3G33CFMYK++vzAXjLUS7jd2YtDPMOlU79eRyzGbBb9rDHId7lsR82U8ZjKzYiIUIj2XRShNmjfLFVD4TNXeba4GLf2227M+TEFpebu83XfScjM/3US8y21ZYlYg6uZ0xfzcv8IX16AzAaMbdOGfiOShLRF1y3ptzDKrPhiOgKMD7p7DCJDXvjSzeCQ//RwTaeU860oHSOhuKtoYQvZWIwrqC9xRppVIDHU+q/p6n6e4JATVr3OUr0rH9g0d+PpB4/wkk+1GH0eKf5TSKJ70gP4ABwKjjmSv79jlysBHwNlIPFYJPjSjD0mjKFTMrtnB0D+/Tg2V+p8NXE5SCkYhFAUZFhBN/yQITSdJ2ekuVcw6x/IDuW71Lp6H3lINZT/0q85OrA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(956004)(2616005)(6666004)(8936002)(8676002)(38100700002)(19627235002)(44832011)(16576012)(86362001)(5660300002)(6486002)(4326008)(316002)(15650500001)(38350700002)(2906002)(45954011)(31696002)(54906003)(186003)(26005)(66946007)(66556008)(66476007)(83380400001)(31686004)(36756003)(52116002)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3621 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a083e925-1cba-4983-cc14-08d9bfed3f06 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DfME2GH175qIWVc/wk+eKZCeWfTXpxqx4dvJ4DAD86DJUebf6kyJCusAk6gxioSzTVVyvRVlYxfu+a4TjOR1TC3w21gluyTqErhm+BRD7iaHcwgca+mG4C4ME+ojUW6PtyUOBhTdGXTgHuSbC1hdBDuMcLEVOAz2DRDdS/jBrhbHJvpBd35dLzmhE3mfjdm2MjK/ZWnM2dxNDLwTWVCBT7IvBHgVDGiBzWdGb3rWIUyT9KuPtK6zl6PkLyznXSZ8awf1VU7sU1bYZPDH9qpxXyLpwoT6uM5zhW2NPcFjouEBLqIYNN/wgVwLow12CIBYrsj6ubOwp7dlmJWijIh8HiaQuc8y6DaoKSSvglpHpGj6NqNY/BJljEP5LddgX42HbB29rsf+x0WMEZcYn9csVZ+ewWa5/QYEMz+In8s7jHZiKdTfJxWWel+Q43z45N8JEPP3xAH3GWZmEKH2wYLbWKkubpC3tt0djt4fJ8MPWxbQaQrICsxG1Qm3aAPR47eFObassC1SwSXDvv0ELQbTsV0ujrZ4p6DFM8p3K24Ni3g+ceDjNhRmbjQGi1+r8NIvEl4tPAfrPUhuR6Z6YTtWDY4DnNtYdrLbBJjYrgJRmI3jrrJ/VGAKsMpImZfgXY8Vh7o9XtC4EvItd2h7kBVHJYQJWbQXehuhwGfii2U5idb5CRTl5FUyG8OKlVKG2PfwolS7K7pR8ZohsmA3AkoTQHzu8Eov+w9V9VEeLIITc6y+IV7H7V61Y+/zWPqnHlAo/j3rigkIcKqW7Bz3ruuV6isZvoQd0q7RxP5XDS0oAsfD3dZV90RRCuyScr8AxPe00xmA8UDZFz8pGdcQ4FM9eg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(36756003)(45954011)(40460700001)(83380400001)(356005)(508600001)(2906002)(53546011)(15650500001)(44832011)(316002)(81166007)(8676002)(16576012)(86362001)(54906003)(82310400004)(956004)(31696002)(336012)(6666004)(63370400001)(19627235002)(186003)(8936002)(4326008)(2616005)(47076005)(70586007)(70206006)(26005)(36860700001)(6486002)(5660300002)(63350400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 17:06:52.1780 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 704a83a1-d6ef-42fb-53d2-08d9bfed4a2f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7131 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Nhi, These patches do not cleanly apply. I guess you would need to run uncrustify for these patches. Can you check, please? Regards, Sami Mujawar On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote: > This patchset leverages the OemUpdateSmbiosInfo API functions from > OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4 > because they may be updated dynamically during UEFI booting with the > data being passed from the pre-UEFI firmware. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Rebecca Cran > Signed-off-by: Nhi Pham > > Nhi Pham (3): > ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition > ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscLib > ArmPkg/ProcessorSubClassDxe: Get serial and part number from > OemMiscLib > > ArmPkg/Include/Library/OemMiscLib.h | 5 +++++ > .../ProcessorSubClassDxe/ProcessorSubClass.c | 14 ++++++++++++-- > .../Type01/MiscSystemManufacturerFunction.c | 10 ++++++++++ > .../Type02/MiscBaseBoardManufacturerFunction.c | 15 +++++++++++++++ > .../Type01/MiscSystemManufacturer.uni | 1 - > 5 files changed, 42 insertions(+), 3 deletions(-) >